public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	bpf@vger.kernel.org
Subject: Re: [PATCH v3] tracing: Guard __DECLARE_TRACE() use of __DO_TRACE_CALL() with SRCU-fast
Date: Mon, 8 Dec 2025 19:38:49 -0500	[thread overview]
Message-ID: <20251208193849.3a51648a@debian> (raw)
In-Reply-To: <075fd9e5-2db8-4030-9364-0be5e22e9902@paulmck-laptop>

On Mon, 8 Dec 2025 12:46:32 -0800
"Paul E. McKenney" <paulmck@kernel.org> wrote:

> >             bash-1165    [001] DBZ.f   269.955762: sys_rt_sigaction -> 0x0
> >                                ^^^^^
> >                             This is just garbage.  
> 
> Yes, but is is the original garbage, and garbage obtained by acceding
> to your request.  ;-)

Yes, here's what it looks like before patch:

            bash-1168    [001] .....    77.498737: sys_wait4 -> 0xfffffffffffffff6
            bash-1168    [001] .....    77.498740: sys_rt_sigreturn()
            bash-1168    [001] .....    77.498765: sys_rt_sigaction(sig: 2, act: 0x7ffef2f08c50, oact: 0x7ffef2f08cf0, sigsetsize: 8)
            bash-1168    [001] .....    77.498770: sys_rt_sigaction -> 0x0
            bash-1168    [001] .....    77.498794: sys_rt_sigprocmask(how: 0, nset: 0, oset: 0x7ffef2f08c70, sigsetsize: 8)
            bash-1168    [001] .....    77.498795: sys_rt_sigprocmask -> 0x0
            bash-1168    [001] .....    77.499055: sys_write(fd: 1, buf: 0x562f0f3aba90 (1b:5d:38:30:30:33:3b:65:6e:64:3d:36:62:62:34:38:38:39:38:2d:32:33:31:33:2d:34:64:38:30:2d:39:30:62:39
:2d:66:33:63:31:36:36:37:62:63:37:37:34:3b:65:78:69:74:3d:73:75:63:63:65:73:73:1b:5c) ".]8003;end=6bb48898-2313-4d80-90b9-f3c1667bc774;exit=success.\", count: 0x3e)
            bash-1168    [001] .l...    77.499099: sys_write -> 0x3e
            bash-1168    [001] .....    77.499196: sys_rt_sigprocmask(how: 0, nset: 0, oset: 0x7ffef2f080c0, sigsetsize: 8)
            bash-1168    [001] .....    77.499198: sys_rt_sigprocmask -> 0x0

[ that lone "l" (el not one) is LAZY_NEED_RESCHED ]

After adding the patch:

            bash-1212    [005] DBZ.f    72.179808: sys_rt_sigprocmask -> 0x0
            bash-1212    [005] DBZ.f    72.179811: sys_ioctl(fd: 0xff, cmd: 0x5401, arg: 0x7ffcaef0e1b0)
            bash-1212    [005] DBZ.f    72.179815: sys_ioctl -> 0x0
            bash-1212    [005] DBZ.f    72.179818: sys_ioctl(fd: 0xff, cmd: 0x5413, arg: 0x7ffcaef0e1c0)
            bash-1212    [005] DBZ.f    72.179823: sys_ioctl -> 0x0
            bash-1212    [005] DBZ.f    72.179862: sys_rt_sigprocmask(how: 2, nset: 0x7ffcaef0e290, oset: 0, sigsetsize: 8)
            bash-1212    [005] DBZ.f    72.179866: sys_rt_sigprocmask -> 0x0
            bash-1212    [005] DBZ.f    72.179884: sys_wait4(upid: 0xffffffffffffffff, stat_addr: 0x7ffcaef0db50, options: 0xb, ru: 0)
            bash-1212    [005] DBZ.f    72.179891: sys_wait4 -> 0xfffffffffffffff6
            bash-1212    [005] DBZ.f    72.179894: sys_rt_sigreturn()


> 
> Perhaps a little bit more constructively, have your conflicting changes
> hit mainline yet?

All my changes have hit mainline.

I believe I did have a solution for fixing the above issue but I was
planning to implement it after the merge window. I can probably do that
today during the keynotes ;-)

-- Steve

  reply	other threads:[~2025-12-09  0:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08  4:20 [PATCH v3] tracing: Guard __DECLARE_TRACE() use of __DO_TRACE_CALL() with SRCU-fast Paul E. McKenney
2025-12-08  9:43 ` Steven Rostedt
2025-12-08 20:46   ` Paul E. McKenney
2025-12-09  0:38     ` Steven Rostedt [this message]
2025-12-09 22:29       ` Paul E. McKenney
2025-12-10  3:11         ` Steven Rostedt
2025-12-11 20:02 ` Joel Fernandes
2025-12-11 20:23   ` Paul E. McKenney
2025-12-12  0:12     ` Joel Fernandes
2025-12-12  0:47       ` Paul E. McKenney
2025-12-12  3:43         ` Joel Fernandes
2025-12-12  7:50           ` Paul E. McKenney
2025-12-12  9:28             ` Joel Fernandes
2025-12-12 23:10               ` Paul E. McKenney
2025-12-12 23:54                 ` Joel Fernandes
2025-12-13  0:06                   ` Paul E. McKenney
2025-12-13  2:18                     ` Steven Rostedt
2025-12-13  4:19                       ` Mathieu Desnoyers
2025-12-13  6:20                         ` Steven Rostedt
2025-12-12  1:13     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251208193849.3a51648a@debian \
    --to=rostedt@goodmis.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox