From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81D1315624B for ; Mon, 8 Dec 2025 20:07:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765224435; cv=none; b=gfMfWntUKSIoOXXWx2Yoa6vqpqX9ARfST8LO7qNx1qtV051I+3q//a1Ut13tJLyvLMacJD4ucP6hn+r0ON0Aq/2K+Ufs1G/ijGwoTmHPc3VdRqMes2w4UPny5ADN9i5aoO05WSfn6US7QSjHdy4qIscCTPNgF+2fINqFCuWnTaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765224435; c=relaxed/simple; bh=m+BNO923fUUwh6oi+dk6ZYzw+TMsFpaZhVsv05o4gFg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dk5jOSn69HJF0tka+6IbIPHuOFtTmmc+lbXbL3Qk7QCSd13qIiwoTNqmcdjSzwp3krNc7v8JDbdTkIyYX1EbviaSbUZGjsOpiv2ki4SC7Pn6PWMSwOEljse8aa3zxdX0tmcH54Vmmlz8FXdCWsrRlld+SxwKJOJONATCi9UOkJ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=KOCCbPin; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="KOCCbPin" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5B8DWtUh032406; Mon, 8 Dec 2025 20:07:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=LRERr/q7Ky3iBNAhVHTu9wrcenLHEaYCVxPTwj9K2 2k=; b=KOCCbPingQvLq3dJq9iroRB88F4YMeue5NZY8JGWf8ZaCpvskoh//IhAL 64ue6rvJEjdfg1KRuNz/4+MtHa8OYxqPAKryJDh98cdkUpvSjhMVZAN5wptVkUUc 4Klnwixv2swDPgtHn6zMb6qR533aEU/QbapYy1CkwsFp1wjOqH4usFyMyMvcY6yg GxT8QPcMajOsU2CC4CyxMvKaRtNoDIf1OL9j3k3UF85Hj3O6jKclb1tyAjvH7Td+ Xll2Bd2uCdidyIyNx/CL5Mvi72hMwIDQRYysmRqF1FROPU/2BCJ4hsO3zsGtidDC jWfdj5MvtTlvZRxETSzAlzK/iOHnA== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4avawv16t9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Dec 2025 20:07:01 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5B8IEe7e008412; Mon, 8 Dec 2025 20:07:00 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4avytmqfav-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Dec 2025 20:07:00 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5B8K6w8B40632580 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 8 Dec 2025 20:06:59 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CDDBE2004B; Mon, 8 Dec 2025 20:06:58 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A6E3F20043; Mon, 8 Dec 2025 20:06:58 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 8 Dec 2025 20:06:58 +0000 (GMT) From: Heiko Carstens To: Peter Zijlstra , Josh Poimboeuf , Ingo Molnar Cc: linux-kernel@vger.kernel.org Subject: [PATCH] bug: Let report_but_entry() provide the correct bugaddr Date: Mon, 8 Dec 2025 21:06:58 +0100 Message-ID: <20251208200658.3431511-1-hca@linux.ibm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: f529txOQ5zVR3mKphAv6m5A6rlH1BJQP X-Proofpoint-ORIG-GUID: f529txOQ5zVR3mKphAv6m5A6rlH1BJQP X-Authority-Analysis: v=2.4 cv=aY9sXBot c=1 sm=1 tr=0 ts=69372fe5 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=Wyi5XojOnXuFXYwSNToA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA2MDAwNyBTYWx0ZWRfX0SgxDBAANnTX tbdP9ULijB4ijtHgmKPu8voo6UwKPbG82CdkmvTyMxPeqhh039VDtDLDY+qH0R1udXK+aSO0+Pu KwSeqBXE02sWf/BXWhpV9R95FrrseKEEXFPPnHXNTXSnxaRxKKCgoUpR287931JUZf+CTalunku xWzjQM3oVzYyTSdJqB7LLL9oEAnxn/Q3jUggTUZ//UfhJuJ8BUu58jsDwVqBLPT+4uqPKDJlo7z CZ93plRUd1lNaKWAvS/dSDyyPUtz6S5bw5e+YSRLVJxxj09dudX+yFCYnmnn4Mt8mvAdstIHLl1 g23HDVHZIumxrWht5Ow2CYXQxMkgFcMNSpR/EXqM8IfSflK27oABAwupOqyBmgecHpt/AJioZNc v5NghhIGMh9c/hiVbrzmKnFasNJSXw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510240000 definitions=main-2512060007 report_bug_entry() always provides zero for bugaddr but could easily extract the correct address from the provided bug_entry. Just do that to have proper warning messages. E.g. adding an artificial void foo(void) { WARN_ONCE(1, "bar"); } function generates this warning message: WARNING: arch/s390/kernel/setup.c:1017 at 0x0, CPU#0: swapper/0/0 ^^^ With the correct bug address this changes to: WARNING: arch/s390/kernel/setup.c:1017 at foo+0x1c/0x40, CPU#0: swapper/0/0 ^^^^^^^^^^^^^ Fixes: 7d2c27a0ec5e ("bug: Add report_bug_entry()") Signed-off-by: Heiko Carstens --- lib/bug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bug.c b/lib/bug.c index edd9041f89f3..c6f691f3d42d 100644 --- a/lib/bug.c +++ b/lib/bug.c @@ -262,7 +262,7 @@ enum bug_trap_type report_bug_entry(struct bug_entry *bug, struct pt_regs *regs) bool rcu = false; rcu = warn_rcu_enter(); - ret = __report_bug(bug, 0, regs); + ret = __report_bug(bug, bug_addr(bug), regs); warn_rcu_exit(rcu); return ret; -- 2.51.0