From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8152B8F4A for ; Tue, 9 Dec 2025 08:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765267819; cv=none; b=N0ipxF1rDWOvUjvArGf1pVjPirWu/h3CuayUKdHoUbvIxnAfKxcnIvEY18PuYSQUOzxhbbB3ecYhbywPalaO89msnd/6b2dsAo4MhVfjOKajLvmivrZJNJBVk+z2Y5tqzmVjQ1foObanNCoDlcQWQjzYDoGfeuZDTxSfdLKRW5s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765267819; c=relaxed/simple; bh=7gniuGys6H7+WxWWXaMfm1YwOTO7kOhCA9PYKfonc2g=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=gBfHX3+mgi2kPi0vN3Gbzyf4IAR1DIGVSOAAm4c+Uk+B9GVu+5H74M9+CyrgKX2PpxNWOBkPTQNixtJQYgUzt1LPSRBYcRnWwBj/6V/6SrMY25V4bT6j7zfSTmkKJ7DHD8LEhmvHydj0EbroeEvxoOjcgGCrNNR5CBdMRiW6GT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=h3G/SW1W; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h3G/SW1W" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-477632b0621so38140725e9.2 for ; Tue, 09 Dec 2025 00:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765267816; x=1765872616; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=spRySZyV+VOtRcH5DjORY7pppljB96Ce+Il4WCp5AM8=; b=h3G/SW1W1Uu8BctUT8s5iGlR5ozyHisluOscs9xpN1fSS7HWmWzFSAsiOMv5JfkblF BbOP9q1jz4dhGZ6RUXumCo3w//4ie+EdVUtejOymxplPSN6of/5Q6CQeEPcKfZnsXx0O zhN3Cz2E6BVzW50ldA2ICvvZ/DX3y038dH87hkcbUuow0BBTiGIj5/q7Jt2ZSoeYXeLR 687huSUCjORE0mgFb0BruPb5B/Uhp7vhbbBx7XWcr3GyA3BzxrCafD7LuGKOdKpyskTa pcV+r/rxlOrv2jPtMWCbcOJNXLxka+gjxZ56cS7YJnhXODaf7dVRUp8bAw2m7RdikNmb uZRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765267816; x=1765872616; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=spRySZyV+VOtRcH5DjORY7pppljB96Ce+Il4WCp5AM8=; b=ZN/fbas0zuqFDrvFEZpSaXqUihXj76Y7X4Up8nUCdpb0QZDcCOzuJrLwl+KF1SerbD ZtHtERBoLVVGKqcr0tmjXLvMOcoMzp9LVFm3vOc3ovYsMGCMhA/nSVyL+2Kh1v46PT1t waUM3nYdryGYezte1lOtAl1MVNqwrlq6Fc2KhGwxhnd4Narqq6gf6uOa95ody6/J6Rgb 4ukkEs+rpA93aD9bC55sX/VAJz4InuZC0H0UJwf8TdoDEb6hz31XSuXKh49NqPd/k5vj CWuLAJQWaJqqVb2xouU1QV337+s+BoMszGZFWiSpVMVZocYPPpt1ZMU50z53evz4ffid QSYw== X-Forwarded-Encrypted: i=1; AJvYcCWBWaM4mmFWWyePuffKEOZ9IaXQFK0sM4s9oUu9ENFxdQsk/sP8bfKeIL8y8DwqzTMFt8JG4kzFp9ahxJE=@vger.kernel.org X-Gm-Message-State: AOJu0YxReNlpduUf4QcfsqMH1aYbk/hQN16EONWfNt6OfTtv4+EL4aDf 1/OjQtyGUU8jO8ChOVy7CMZiX6FbBqTIynA3nlcSnF0aj99kiE2yrVhLE7J6hJPfQRc= X-Gm-Gg: ASbGncuy7SlkrbbiicdDXn6FRwC2ZOloDXgki+weJhcCyQae13+dvRZRCtpvye42rv0 gZ1u657IeiTDbSK+IMpZAT6VXqTvob2GeiVbWLZOg0OBsEA2dNfx477ImEB/c7oEkpsLLHenatU F6P0toeyjq+ti8PkUHllLLYhfCRTp3xbhw3MOrXZy7b5T04I3MFjwIxxeouTv/iryrUH8/Mq2M9 vFoYHQhX6Lm5k0vOS0aREvMpS341DIwpaOsQrJPsqCuLS3kafl3/epYAisqOW/oWB5Q8tezGcmy v5sfl7zj6gyPflHlTqg5NE3j9xJAveRy+8woSsz9xF9C6/ZBufeEOFTRkHUyfn6LxTMKJO9rH/w V/Ok3WAjzdWvU3dRgCZYdxMdSftuVf5adXi4ZYzRWK0QJN59VcQSIl4PwQ1umx5wbptqUossvi3 0fNICbXWOexHiwlk0H X-Google-Smtp-Source: AGHT+IFDA3qG7tfHKOUMmoIHKf4R4Il2Eu0O9T+v7vLC242anRcuYF8kcvLH3Eyq2rSRJwwYxrLuCQ== X-Received: by 2002:a05:600c:354d:b0:475:dc5c:3a89 with SMTP id 5b1f17b1804b1-47939e49338mr102941665e9.34.1765267815724; Tue, 09 Dec 2025 00:10:15 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a7da1dff5sm10650055e9.15.2025.12.09.00.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 00:10:15 -0800 (PST) Date: Tue, 9 Dec 2025 11:10:12 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Akhil P Oommen Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Rob Clark Subject: drivers/gpu/drm/msm/adreno/a2xx_gpu.c:503 a2xx_gpu_init() warn: variable dereferenced before check 'pdev' (see line 500) Message-ID: <202512082235.2rH8XoPX-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: c2f2b01b74be8b40a2173372bcd770723f87e7b2 commit: 491fadb2b818e1d900229a1f8243de6458381306 drm/msm/adreno: Move adreno_gpu_func to catalogue config: arm64-randconfig-r072-20251207 (https://download.01.org/0day-ci/archive/20251208/202512082235.2rH8XoPX-lkp@intel.com/config) compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project a805147ac1ba123916de182babb0831fbb148756) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202512082235.2rH8XoPX-lkp@intel.com/ smatch warnings: drivers/gpu/drm/msm/adreno/a2xx_gpu.c:503 a2xx_gpu_init() warn: variable dereferenced before check 'pdev' (see line 500) drivers/gpu/drm/msm/adreno/a3xx_gpu.c:530 a3xx_gpu_init() warn: variable dereferenced before check 'pdev' (see line 525) drivers/gpu/drm/msm/adreno/a4xx_gpu.c:642 a4xx_gpu_init() warn: variable dereferenced before check 'pdev' (see line 637) vim +/pdev +503 drivers/gpu/drm/msm/adreno/a2xx_gpu.c 491fadb2b818e1 Akhil P Oommen 2025-11-18 493 static struct msm_gpu *a2xx_gpu_init(struct drm_device *dev) 21af872cd8c695 Jonathan Marek 2018-11-21 494 { 21af872cd8c695 Jonathan Marek 2018-11-21 495 struct a2xx_gpu *a2xx_gpu = NULL; 21af872cd8c695 Jonathan Marek 2018-11-21 496 struct adreno_gpu *adreno_gpu; 21af872cd8c695 Jonathan Marek 2018-11-21 497 struct msm_gpu *gpu; 21af872cd8c695 Jonathan Marek 2018-11-21 498 struct msm_drm_private *priv = dev->dev_private; 21af872cd8c695 Jonathan Marek 2018-11-21 499 struct platform_device *pdev = priv->gpu_pdev; 491fadb2b818e1 Akhil P Oommen 2025-11-18 @500 struct adreno_platform_config *config = pdev->dev.platform_data; ^^^^^^^^^ Patch adds a dereference. 21af872cd8c695 Jonathan Marek 2018-11-21 501 int ret; 21af872cd8c695 Jonathan Marek 2018-11-21 502 21af872cd8c695 Jonathan Marek 2018-11-21 @503 if (!pdev) { but the old code checked for NULL. Probably this NULL check can be removed? 21af872cd8c695 Jonathan Marek 2018-11-21 504 dev_err(dev->dev, "no a2xx device\n"); 21af872cd8c695 Jonathan Marek 2018-11-21 505 ret = -ENXIO; 21af872cd8c695 Jonathan Marek 2018-11-21 506 goto fail; 21af872cd8c695 Jonathan Marek 2018-11-21 507 } 21af872cd8c695 Jonathan Marek 2018-11-21 508 21af872cd8c695 Jonathan Marek 2018-11-21 509 a2xx_gpu = kzalloc(sizeof(*a2xx_gpu), GFP_KERNEL); 21af872cd8c695 Jonathan Marek 2018-11-21 510 if (!a2xx_gpu) { 21af872cd8c695 Jonathan Marek 2018-11-21 511 ret = -ENOMEM; 21af872cd8c695 Jonathan Marek 2018-11-21 512 goto fail; 21af872cd8c695 Jonathan Marek 2018-11-21 513 } 21af872cd8c695 Jonathan Marek 2018-11-21 514 21af872cd8c695 Jonathan Marek 2018-11-21 515 adreno_gpu = &a2xx_gpu->base; 21af872cd8c695 Jonathan Marek 2018-11-21 516 gpu = &adreno_gpu->base; 21af872cd8c695 Jonathan Marek 2018-11-21 517 21af872cd8c695 Jonathan Marek 2018-11-21 518 gpu->perfcntrs = perfcntrs; 21af872cd8c695 Jonathan Marek 2018-11-21 519 gpu->num_perfcntrs = ARRAY_SIZE(perfcntrs); 21af872cd8c695 Jonathan Marek 2018-11-21 520 491fadb2b818e1 Akhil P Oommen 2025-11-18 521 ret = adreno_gpu_init(dev, pdev, adreno_gpu, config->info->funcs, 1); db07ce5da8b26b Fabio Estevam 2023-06-20 522 if (ret) db07ce5da8b26b Fabio Estevam 2023-06-20 523 goto fail; db07ce5da8b26b Fabio Estevam 2023-06-20 524 21af872cd8c695 Jonathan Marek 2018-11-21 525 if (adreno_is_a20x(adreno_gpu)) 21af872cd8c695 Jonathan Marek 2018-11-21 526 adreno_gpu->registers = a200_registers; 21af872cd8c695 Jonathan Marek 2018-11-21 527 else if (adreno_is_a225(adreno_gpu)) 21af872cd8c695 Jonathan Marek 2018-11-21 528 adreno_gpu->registers = a225_registers; 21af872cd8c695 Jonathan Marek 2018-11-21 529 else 21af872cd8c695 Jonathan Marek 2018-11-21 530 adreno_gpu->registers = a220_registers; 21af872cd8c695 Jonathan Marek 2018-11-21 531 21af872cd8c695 Jonathan Marek 2018-11-21 532 return gpu; 21af872cd8c695 Jonathan Marek 2018-11-21 533 21af872cd8c695 Jonathan Marek 2018-11-21 534 fail: 21af872cd8c695 Jonathan Marek 2018-11-21 535 if (a2xx_gpu) 21af872cd8c695 Jonathan Marek 2018-11-21 536 a2xx_destroy(&a2xx_gpu->base.base); 21af872cd8c695 Jonathan Marek 2018-11-21 537 21af872cd8c695 Jonathan Marek 2018-11-21 538 return ERR_PTR(ret); 21af872cd8c695 Jonathan Marek 2018-11-21 539 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki