From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DA251E2606 for ; Tue, 9 Dec 2025 14:17:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765289821; cv=none; b=XlC4xkUIfGupklgXiaAyQhJNOjS4Eii03crak7cWDx8grZWz39t7ZHrzZ8gk3+34Qg55pngkZmq1Yai6Crs5as0jKhdMWBzSJkRzjol1vQf2Jdy9ojlXCIYxWP5aJHhorgsFWGBxjqZKqYuSshNR59qjUXGA0C4IM04eWN4EKYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765289821; c=relaxed/simple; bh=re7ktCouPs6agxyacY1S9Dr4ldvps2d8xXP04n6KHZk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X++mPrjo/ljUN2/sXMQwmbOfo4G7tYtn09HX36a7zWFimfEu9dkVs4i44sB0xDjmfiuHkXlt721Mi1Od5YpePcgH0V5YYqOrUolBqkRo48CYQ/OHbqlrt2qnu8DsSZs7NK4ohr10UkkONddATP1801ehQBf4F1f6fXwD0hLR5TM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lULy/rf8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lULy/rf8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B91FC4CEF5; Tue, 9 Dec 2025 14:17:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765289821; bh=re7ktCouPs6agxyacY1S9Dr4ldvps2d8xXP04n6KHZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lULy/rf85/iEt1JTXX9f4FuZ+PdypwhtX8K1Dmg/yFbRtzEZSFigk4p5Sci4VJogg XFtyt1jVPPJE1yPOro6odzd3mJWEKpAbJIS2tJt7zSfDSfE0XtQTabYq5NBLahMbub YgtJWvGyqsEJqwo1Ip0+Ow12KAEjCMixLh5MMaKlvCEvh8iVTzkRSzCdjuzZVrj3eI MmIOUN/y++lshSZeTYjNS47j3l0ycf1YohGgUVg8GKhYQZqaqyXf0E68ohAfsadqU2 foc2HYUGmY78txauG2xcHhHDg4wzf5kimGxgygf6m/6WsYgvGFmZvUKIynQv30Odpq UIrPoG1MiVnhA== Date: Tue, 9 Dec 2025 15:16:58 +0100 From: Maxime Ripard To: Nicolas Frattaroli Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , David Airlie , Simona Vetter , Maarten Lankhorst , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v5 05/17] drm/display: hdmi-state-helper: Act on color format DRM property Message-ID: <20251209-uptight-radical-chupacabra-ac3d6d@houat> References: <20251128-color-format-v5-0-63e82f1db1e1@collabora.com> <20251128-color-format-v5-5-63e82f1db1e1@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="7dtovcletdpwfi6p" Content-Disposition: inline In-Reply-To: <20251128-color-format-v5-5-63e82f1db1e1@collabora.com> --7dtovcletdpwfi6p Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v5 05/17] drm/display: hdmi-state-helper: Act on color format DRM property MIME-Version: 1.0 On Fri, Nov 28, 2025 at 10:05:41PM +0100, Nicolas Frattaroli wrote: > With the introduction of the "color format" DRM property, which allows > userspace to request a specific color format, the HDMI state helper > should implement this. >=20 > Implement it by checking whether the property is set and set to > something other than auto. If so, pass the requested color format, and > otherwise set RGB. >=20 > Signed-off-by: Nicolas Frattaroli > --- > drivers/gpu/drm/display/drm_hdmi_state_helper.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gp= u/drm/display/drm_hdmi_state_helper.c > index a561f124be99..5da956bdd68c 100644 > --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c > +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c > @@ -649,11 +649,21 @@ hdmi_compute_config(const struct drm_connector *con= nector, > unsigned int max_bpc =3D clamp_t(unsigned int, > conn_state->max_bpc, > 8, connector->max_bpc); > + enum hdmi_colorspace hdmi_colorspace =3D > + drm_color_format_to_hdmi_colorspace(conn_state->color_format); > int ret; > =20 > ret =3D hdmi_compute_format_bpc(connector, conn_state, mode, max_bpc, > - HDMI_COLORSPACE_RGB); > + hdmi_colorspace); > if (ret) { > + /* If a color format was explicitly requested, don't fall back */ > + if (conn_state->color_format) { > + drm_dbg_kms(connector->dev, > + "Explicitly set color format '%s' doesn't work.\n", > + drm_get_color_format_name(conn_state->color_format)); > + return ret; > + } > + I think the following would be more readable: if (conn_state->color_format && conn_state->color_format !=3D DRM_COLOR_FOR= MAT_AUTO) { enum hdmi_colorspace hdmi_colorspace =3D drm_color_format_to_hdmi_colorspace(conn_state->color_format); return hdmi_compute_format_bpc(connector, conn_state, mode, max_bpc, hd= mi_colorspace) } ret =3D ret =3D hdmi_compute_format_bpc(connector, conn_state, mode, max_bp= c, HDMI_COLORSPACE_RGB); =2E.. Maxime --7dtovcletdpwfi6p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaTgvWQAKCRAnX84Zoj2+ dsTYAYCnsq4IINrpmEbQVfvZqzEXkFALMdooT+3vTv5FYb6D28/FDX4dwiypkgVc Zd6A6m4Bf3JYjaDiWfKCks0opK33MCwdhIj7KM2EqsBB4p86nA4zPE0+JmVqVbyI pjLOkixd2A== =Wym1 -----END PGP SIGNATURE----- --7dtovcletdpwfi6p--