From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BF142153FB for ; Tue, 9 Dec 2025 13:09:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765285795; cv=none; b=Io+xJxjw1XzcXwVGCKaUbYqOdtbRhZAb5Oeq5Bs4yELXGti1uRdRJ+1WuH41hnlKMSJKAEbWcHUeeSDoIehb0vM9A5CGsiEBm9Awkj2AuNse0NCX3OqC8jrHrCgMY133GL0WoeLHt4SuN7lcmCr+4FZsdyjfyaPW5WdVCgSoKbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765285795; c=relaxed/simple; bh=Touvqf8WHt04tp99eC4EM9XyIpIcTPJtbic0gP2X3FY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N9a1l8LWbJl4sEoWZYy/GtCkoar8ozKNv7JGibKWjS0n9ZQU6NedGG0p9uocX54DYgGpOEFA/Y03ifPpR//NkV8L2d81kP1T5ahqpVGSbyKUZ4vkNeUzuB1sQOI/mZ5bF5iJLg3uW1smoA93WJNZ3TgzKV0iCOefEDfe9S8FV+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Jg9h79mo; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=mOzNg/sn; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Jg9h79mo"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="mOzNg/sn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765285793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o5P38QWOVcSU59TQGZzDoAFjcxq1O9ed/yD/2cqZSQI=; b=Jg9h79mowLR8A3ERA0b/wSMTR9JkJ1Oo6b50aecT6+1FVOKiqDFXfnRoTtlZXYHwCgWO5c EdvSmolEMeI4Bk7Hw1DVXXzw1oKHqitIOYjOq8Gpge8vL2iqMSvPcnSdIw2qXG8wZfgzw5 Od+KaAXp2mOnqirDNRCMCMPkFiRwt20= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-eXEKDyWdMUW3_K--JVarkg-1; Tue, 09 Dec 2025 08:09:50 -0500 X-MC-Unique: eXEKDyWdMUW3_K--JVarkg-1 X-Mimecast-MFC-AGG-ID: eXEKDyWdMUW3_K--JVarkg_1765285789 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-37a35d16347so23276041fa.1 for ; Tue, 09 Dec 2025 05:09:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765285789; x=1765890589; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o5P38QWOVcSU59TQGZzDoAFjcxq1O9ed/yD/2cqZSQI=; b=mOzNg/sncbpdmSz9dPkYZyt/fJN/3AzjndSSe6/TtLehDfKe17Bp4jDOZJDIH7n8h2 4R/9TuMdvgJvqtDPqEItC9ztCpI3Ks68ccxfbBDdndg4mk9HiqgpUdXxKNb+QzAn6GsC Icaw9oYRbZewVGGw7ptgP6HdwTsEvMhCZl/aUOKbd9zzrewAslfMyoTDATb8w2aR3UKL cDlF/aXLPzXzOnPQ/g4b3ZiCz92lfBegpKSX5eYKkht/VBKkWSPxa/ZzepuVPiwlkrKB 3rr/tlNmXzDAUSH9Ov5u6P21FxDAaJncJiZbiiUqUpl1BREoc+yGnXhJt/wkAEXVtGdg /1mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765285789; x=1765890589; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o5P38QWOVcSU59TQGZzDoAFjcxq1O9ed/yD/2cqZSQI=; b=b4aoCpf8Ow5fEI4ww+Ganxbo+MwDRql/PJtO9/EooFbeEWAh9NVFfrx2EmAR2p1Lu3 UVhEE5w871yrsZcsKsgow5FRaCPJ65/Gpj1rLXGae8ER5ly09k+1nPBCI5123Hq9ILPL LuEDUAQjbuGV1WW/DNV2uZ8QAmyvS4KikofmZfraqnxWldUV6oNPIr2dSBeEuD/Lh3S4 s6QRP0g1VekzTlDNiacADEXdpOThxNEh2zkkQB0nc41wpPU/n9m0mi/ZhYeGSnvWSbPq JDNsmNAzjGE4rSSV6gCa5/uj+CNIE6/GErRZlh2283Eyl7uHGEnr6vDhdJxQthIBMjmz GKww== X-Gm-Message-State: AOJu0YwThHxJW3xMRGxqJ8C50stTouHrvAQfRMGFrVl24RFbUOoP7o8+ rbfbZyNUBz034wQhk/Vg9QvU/SJu6qsWLPazD8QTCw0SHvmPMdGJYgMSOOopGOysAML8wu/76iH hnuFMpO6CQec+RHzgRcgFYOLWN7TslAtRThQuaI326F7btDlVOQSA/OOTAdjD/oGcIAF/r/eI/b mkjdhHbkDQBNTU+qioNtpqLQ7B9dmxxYVD2ZiToRXSy8M= X-Gm-Gg: ASbGnctNzr4yk+STtwib7FK8dPJEuNOe0Jjm03N1GX6MZeHpJaKJbUSwRW/NfWT25qn Cc8lIbGlqnIUGWiy/8yBHgkyvf6qmEtdj6PzkV81V6GMp+Ae7Zwo54LoiY4RzrkD1Ia3x58xI7p VPe5HZwuhdr4aRcOxq1QTWgnO4a81Blo2kcpq/JHVqJAZSvZYA/5TlDXNcm+puczsfmJ5CWZIcx rJ4mxmKohMVE8KlDoU0F4WAcnZShZmicy5CYX6btokgORHUpSFiYv9h2pf8/anX6YooKy5Tzwjy QBMeGl3EQWrNJgv+QNle2JNWheV/+rzjrL3CKB5FRDocZ/3X4n4THh7YF1nB8yV/snrRzXGAYFW RErbSQUCbPhKHq+5LbQcu4oWJKMpyi38dlg== X-Received: by 2002:a2e:bc2a:0:b0:37b:9e0b:e0d8 with SMTP id 38308e7fff4ca-37ed1feec4cmr27411711fa.14.1765285789028; Tue, 09 Dec 2025 05:09:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IG6qF6On+XjEQa7Vpebeq/+5jUjnAJbF/ap+lr+2JnwmaX++R35vbR7XHiCdci98pl68Pm6CQ== X-Received: by 2002:a2e:bc2a:0:b0:37b:9e0b:e0d8 with SMTP id 38308e7fff4ca-37ed1feec4cmr27411621fa.14.1765285788446; Tue, 09 Dec 2025 05:09:48 -0800 (PST) Received: from redhat.com (IGLD-80-230-38-228.inter.net.il. [80.230.38.228]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-37e705e8292sm49532871fa.37.2025.12.09.05.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 05:09:47 -0800 (PST) Date: Tue, 9 Dec 2025 08:09:45 -0500 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Jason Wang , virtualization@lists.linux-foundation.org Subject: Re: [PATCH 00/14] tools/virtio: cleanups, fixes Message-ID: <20251209080926-mutt-send-email-mst@kernel.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 04, 2025 at 01:46:01PM -0500, Michael S. Tsirkin wrote: > Recent virtio changes brought about build errors for tools/virtio, > as usual. I did some refactoring to hopefully reduce maintainance > load going forward. > > Adding stubs is tedious and seemed a perfect fit for cursor - > so I used it for that, then rewrote some commits and accepted > others. commit logs I've rewritten. > > Found and fixed a couple of minor bugs while doing this - that > part's all mine. Jason, any feedback? > Michael S. Tsirkin (14): > tools/virtio: fix up compiler.h stub > virtio: make it self-contained > tools/virtio: use kernel's virtio.h > tools/virtio: add struct module forward declaration > tools/virtio: stub DMA mapping functions > tools/virtio: add dev_WARN_ONCE and is_vmalloc_addr stubs > tools/virtio: add ucopysize.h stub > tools/virtio: pass KCFLAGS to module build > tools/virtio: add struct cpumask to cpumask.h > tools/virtio: stub might_sleep and synchronize_rcu > tools/virtio: switch to kernel's virtio_config.h > virtio_features: make it self-contained > tools/virtio: fix up oot build > tools/virtio: add device, device_driver stubs > > include/linux/virtio.h | 2 + > include/linux/virtio_features.h | 2 + > tools/virtio/Makefile | 8 ++- > tools/virtio/linux/compiler.h | 6 ++ > tools/virtio/linux/cpumask.h | 4 ++ > tools/virtio/linux/device.h | 8 +++ > tools/virtio/linux/dma-mapping.h | 4 ++ > tools/virtio/linux/kernel.h | 16 +++++ > tools/virtio/linux/module.h | 2 + > tools/virtio/linux/ucopysize.h | 21 ++++++ > tools/virtio/linux/virtio.h | 73 +-------------------- > tools/virtio/linux/virtio_config.h | 102 +---------------------------- > tools/virtio/oot-stubs.h | 10 +++ > 13 files changed, 82 insertions(+), 176 deletions(-) > create mode 100644 tools/virtio/linux/ucopysize.h > create mode 100644 tools/virtio/oot-stubs.h > > -- > MST >