From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E01821DB125 for ; Tue, 9 Dec 2025 09:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765273479; cv=none; b=GG8O538PsVzzDGvhOi4UvPR9a5DkcLP3WFrKY/mhfu0E4KLcP28GXl89d8bpyYPljT9Li6rMOFC6BB71YZzaOMb8KwKHzIzEzoK/yMmBnlypsf5/OdfunCRGc4lofEbj+si+FwAT2pOlsFzIM/5XfMA2fdM1+UoaCCXawWqP75o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765273479; c=relaxed/simple; bh=8vdv4yr8ba5Mi4hoItSJoOgm+sx3gDJTt66t3a7BHyc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VAa0Xm1OUMT2wDFPnTCj4T2YpyHes/2taYNezt1YQYvXWCMrONpzwU/KpCwSLIoXZ5RJA/L4A7uWyg42kv3ww7cgNz/T8/AQ02N1eAUJLbh3W8Is3AkZAtxpAtOmc+Rns8s1Ib2xH+1Z7RqPuuuYTHmupRAL1hRyauS8HH0f3YE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bAOqwt/I; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bAOqwt/I" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42e29739ff1so2233951f8f.1 for ; Tue, 09 Dec 2025 01:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765273476; x=1765878276; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=eTFO6ZSVbqg5cNw3sne2kKUbTWQNeVaUcpcLa/7h/qo=; b=bAOqwt/IYqF6oG8i8/v6a5PdK3yoIxBSoGS1cCcfxQQpfQ6B7hJU7AXJ1zcitb35p6 CBxcvua4BnxDapiT4gXl1I6FEMyVU8QZVC5lFwrybRlB1lk2u8PCXda9u5fFNAJvwMt2 KanAxLwvyWwRpuk4FJ7cq07rz6d+ycDe/xhcG7u2FFQkvqJ1LRJGagR/3F3fDRqQ9h8x cwsAc44P/0hCyQKAaZOVRifGN8DpFOhre27gn1dB6I16n6ThvktljwUNXLnaQ4TNrgDy 7tmjqfR3aAgD3gGaKauSdMftJeSOutT9OXlnv0JI1qKKXJOD1gMFKSohygb1Knpd1RZj C3WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765273476; x=1765878276; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eTFO6ZSVbqg5cNw3sne2kKUbTWQNeVaUcpcLa/7h/qo=; b=s5SFHqvE3TRYB1CKx1lJzxLZwwux9/DXWZOetyTpqr9dhDYiHRM6kmKkGyX3NdGzl6 6IO/zhMbhkquIvwEU2iaBrKQWAVg1rKuMw75ZAWATz78eOs1qeQyPEkE5VFnVvdYfEaY o2DEqyUfLvhA/NKpwofwzjHMilIpswDyAvOSfbL6rmkU04l3pDvwgsKxSnpoRFZXSf+i IF6Xo0LYq8ov0EkI/n422RjHfl+R5BLqhAin9dFuF/DGxnfHPgRs/ncr+ttlFfQ2Z12E 8r84sWUoimhQ6ZWX12y6rxjmEjJnIc3DVwzp9pfsKwEK9JDcB587/NxH4N6jPIArYu98 glyg== X-Forwarded-Encrypted: i=1; AJvYcCWKvt9eQuqNGnxkDGMuHhe4pOPJQi3/+8r6M0HRBJS/BB1+GcU51kV1rcxiH/HyM6s3yaXuM5xOOd6+0ks=@vger.kernel.org X-Gm-Message-State: AOJu0YxBtN/EFlGWH8zgR287Ti1PUb2okkYI7Gpsk7SpKMVoGSDhCKGN 2fcjdx+qrRoR/lkU1UTbqLOrHKukLrS+YuPTsLWixHtsNRDVpnFd+Kq3 X-Gm-Gg: AY/fxX4BN1WijZ9FjzNTHAYGOplR1MWBltozoY0dMS6ysDz9tmm+mxFGA8xtSzv1Vrh TFrEvRbyLHU0+Sy+Q9I2DB8ZM4JNzqPFwBlwXmsjX6/5jafP3TZOyWS3qzcQHx8/owsdjLLB60G EHX/n0Cn1UX/jUxtWF7PbtZanQcGmMLXNS5JFr/mWlaytrLfktx0UARLP+VTtUCqdzGtkPqm8kG exuPXBvWDo/Fsbm2/zB+eDBXJNDtqZEY+EZoumnatfoZLuE/FaFieN7XQjn+FoOdZDiCsMfBMBL ILH0ToilBg80wJWEW6ZFlUykmy1lkuV5/CaxvxzxmITjI71vdmanVHr9K52UQmPQoRVpwOHe9RO QQqCzEMaU8TGUtiocdM5uhs5MJMDcfWESjuknC14oLvVUESslUKOUTteFOPPHtng/Y4BuihtWq6 2OnoCEWqvrlhs/qh2ZaybzMHWWJKBngKqqpX4jI4aK9nXA1T7A2TfE X-Google-Smtp-Source: AGHT+IHrJDrWaABHIRTeuvG2zFhXIU+ST2jOsXds0P3glgaBQZcSHGkgwT0Qbc1qhO2zyeSs/kfp/w== X-Received: by 2002:a5d:6952:0:b0:42f:8816:ee6d with SMTP id ffacd0b85a97d-42fa091ec48mr832773f8f.31.1765273476003; Tue, 09 Dec 2025 01:44:36 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7cbfeae9sm30973774f8f.13.2025.12.09.01.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 01:44:35 -0800 (PST) Date: Tue, 9 Dec 2025 09:44:33 +0000 From: David Laight To: Mika Westerberg Cc: Yury Norov , Rasmus Villemoes , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Geert Uytterhoeven , Alexandre Belloni , Jonathan Cameron , Crt Mori , Richard Genoud , Andy Shevchenko , Luo Jie , Peter Zijlstra , Jakub Kicinski , netdev@vger.kernel.org, "David S . Miller" , Simon Horman , Andreas Noever , Yehezkel Bernat Subject: Re: [PATCH 0/9] bitfield: tidy up bitfield.h Message-ID: <20251209094433.768a76ae@pumpkin> In-Reply-To: <20251209070806.GB2275908@black.igk.intel.com> References: <20251208224250.536159-1-david.laight.linux@gmail.com> <20251209070806.GB2275908@black.igk.intel.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 9 Dec 2025 08:08:06 +0100 Mika Westerberg wrote: > Hi David, > > On Mon, Dec 08, 2025 at 10:42:41PM +0000, david.laight.linux@gmail.com wrote: > > From: David Laight > > > > I noticed some very long (18KB) error messages from the compiler. > > Turned out they were errors on lines that passed GENMASK() to FIELD_PREP(). > > Since most of the #defines are already statement functions the values > > can be copied to locals so the actual parameters only get expanded once. > > > > The 'bloat' is reduced further by using a simple test to ensure 'reg' > > is large enough, slightly simplifying the test for constant 'val' and > > only checking 'reg' and 'val' when the parameters are present. > > > > The first two patches are slightly problematic. > > > > drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp_eth.c manages to use > > a #define that should be an internal to bitfield.h, the changed file > > is actually more similar to the previous version. > > > > drivers/thunderbolt/tb.h passes a bifield to FIELD_GET(), these can't > > be used with sizeof or __auto_type. The usual solution is to add zero, > > but that can't be done in FIELD_GET() because it doesn't want the value > > promoted to 'int' (no idea how _Generic() treated it.) > > The fix is just to add zero at the call site. > > (The bitfield seems to be in a structure rad from hardware - no idea > > how that works on BE (or any LE that uses an unusual order for bitfields.) > > Okay but can you CC me the actual patch too? I only got the cover letter > ;-) Ah, sorry I'd changed the git settings.. I'll resend it all. David