From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: [GIT PULL v2] tracing: Fix for v6.19
Date: Tue, 9 Dec 2025 21:48:34 -0500 [thread overview]
Message-ID: <20251209214834.0c185482@fedora> (raw)
Linus,
tracing fix for v6.19:
- Fix unused tracepoint build for modules only using exported tracepoints
The tracepoint-update.c code that looks for unused tracepoints expects
if tracepoints are used then it will have tracepoints defined. If
not, it errors out which fails the build.
In most cases this the way things work. A tracepoint can't be used if
it is not defined. There is one exception; If a module only uses
tracepoints that are defined in other modules or the vmlinux proper,
where the tracepoints are exported. In this case, the
tracepoint-update.c code thinks tracepoints are used but not defined
and errors out, failing the build.
When tracepoint-update.c detects this case, if it is a module that is
being processed, exit out normally as it is a legitimate case.
- Add tracepoint-update.c to MAINTAINERS file
The tracepoint-update.c file is specific to tracing so add it to the
tracing subsystem in the MAINTAINERS file.
Please pull the latest trace-v6.19-4 tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
trace-v6.19-4
Tag SHA1: ee4b6dd23fc915e0745099f0b9d236570858b828
Head SHA1: 2c22361ab628adbca82ab2da6d41b7cfeb14b83c
Steven Rostedt (2):
tracing: Fix unused tracepoints when module uses only exported ones
MAINTAINERS: Add tracepoint-update.c to TRACING section
----
MAINTAINERS | 1 +
scripts/tracepoint-update.c | 3 +++
2 files changed, 4 insertions(+)
---------------------------
Changes since v1: https://lore.kernel.org/all/20251209202032.4430caac@fedora/
- Fixed typos and grammar in change log of patch
- Added MAINTAINERS patch
diff --git a/MAINTAINERS b/MAINTAINERS
index 27bd8a9cf0ad..44036a5b4e3a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -26298,6 +26298,7 @@ F: include/trace/
F: kernel/trace/
F: kernel/tracepoint.c
F: scripts/tracing/
+F: scripts/tracepoint-update.c
F: tools/testing/selftests/ftrace/
TRACING MMIO ACCESSES (MMIOTRACE)
diff --git a/scripts/tracepoint-update.c b/scripts/tracepoint-update.c
index 7f7d90df14ce..90046aedc97b 100644
--- a/scripts/tracepoint-update.c
+++ b/scripts/tracepoint-update.c
@@ -210,6 +210,9 @@ static int process_tracepoints(bool mod, void *addr, const char *fname)
}
if (!tracepoint_data_sec) {
+ /* A module may reference only exported tracepoints */
+ if (mod)
+ return 0;
fprintf(stderr, "no __tracepoint_strings in file: %s\n", fname);
return -1;
}
next reply other threads:[~2025-12-10 2:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 2:48 Steven Rostedt [this message]
2025-12-10 8:01 ` [GIT PULL v2] tracing: Fix for v6.19 pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251209214834.0c185482@fedora \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox