public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Joshua Kinard <kumba@gentoo.org>
Subject: [PATCH 0/6] genirq: Post 6.19-rc1 API cleanup
Date: Wed, 10 Dec 2025 08:22:36 +0000	[thread overview]
Message-ID: <20251210082242.360936-1-maz@kernel.org> (raw)

Fixing the issue reported at [1] pushed me to look into some of the
ugly corners of the percpu IRQ configuration, and to notice that:

- we only have 3 users left of setup_percpu_irq(), all MIPS timers

- none of the timer drivers using request_percpu_irq() are passing the
  IRQF_TIMER flag (this function doesn't take a flag argument)

- the IRQ_TIMINGS subsystem therefore cannot identify that it should
  consider these interrupts as timer interrupts, and would mistakenly
  take them into account

- but as it turns out, nobody can enable IRQ_TIMINGS the first place

- so passing flags at percpu IRQ request time is not required

The cumulative effects of the above is that we can:

- drop the IRQ_TIMINGS stuff -- it was never used, and Daniel
  indicates[2] that there is no immediate path to finishing it

- replace __request_percpu_irq() with request_percpu_irq_affinity()

- convert all three MIPS timers to request_percpu_irq()

- finally kill setup_percpu_irq() for good

Note that when it comes to MIPS, I have only tested the GIC timer
change, as I don't have any SGI HW anymore. And even that was on
QEMU. I'd appreciate someone with the necessary zoo to give it a go on
actual metal.

Patches on top of [3].

[1] https://lore.kernel.org/r/aTFozefMQRg7lYxh@aspen.lan
[2] https://lore.kernel.org/r/3f3d42d2-13e3-43ef-b839-f77424769add@linaro.org
[3] https://patch.msgid.link/20251205091814.3944205-1-maz@kernel.org

Marc Zyngier (6):
  genirq: Remove IRQ timing tracking infrastructure
  genirq: Remove __request_percpu_irq() helper
  mips: Move IP30 timer to request_percpu_irq()
  mips: Move IP27 timer to request_percpu_irq()
  clocksource: mips-gic-timer: Move GIC timer to request_percpu_irq()
  genirq: Kill setup_percpu_irq()

 arch/mips/include/asm/cevt-r4k.h     |   1 -
 arch/mips/kernel/cevt-r4k.c          |  11 -
 arch/mips/sgi-ip27/ip27-timer.c      |  10 +-
 arch/mips/sgi-ip30/ip30-timer.c      |   5 +-
 drivers/clocksource/mips-gic-timer.c |  10 +-
 include/linux/interrupt.h            |  24 +-
 include/linux/irq.h                  |   3 -
 kernel/irq/Kconfig                   |   3 -
 kernel/irq/Makefile                  |   4 -
 kernel/irq/handle.c                  |   2 -
 kernel/irq/internals.h               | 110 ---
 kernel/irq/manage.c                  |  49 +-
 kernel/irq/timings.c                 | 959 ---------------------------
 lib/Kconfig.debug                    |   8 -
 14 files changed, 16 insertions(+), 1183 deletions(-)
 delete mode 100644 kernel/irq/timings.c

-- 
2.47.3


             reply	other threads:[~2025-12-10  8:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10  8:22 Marc Zyngier [this message]
2025-12-10  8:22 ` [PATCH 1/6] genirq: Remove IRQ timing tracking infrastructure Marc Zyngier
2025-12-11  1:32   ` Jinjie Ruan
2025-12-15 21:27   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-12-10  8:22 ` [PATCH 2/6] genirq: Remove __request_percpu_irq() helper Marc Zyngier
2025-12-11  1:46   ` Jinjie Ruan
2025-12-15 21:27   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2025-12-10  8:22 ` [PATCH 3/6] mips: Move IP30 timer to request_percpu_irq() Marc Zyngier
2025-12-11  1:58   ` Jinjie Ruan
2025-12-11  8:20     ` Marc Zyngier
2025-12-15 21:27   ` [tip: irq/core] MIPS: " tip-bot2 for Marc Zyngier
2025-12-10  8:22 ` [PATCH 4/6] mips: Move IP27 " Marc Zyngier
2025-12-15 21:27   ` [tip: irq/core] MIPS: " tip-bot2 for Marc Zyngier
2025-12-10  8:22 ` [PATCH 5/6] clocksource: mips-gic-timer: Move GIC " Marc Zyngier
2025-12-15 21:27   ` [tip: irq/core] clocksource/drivers/mips-gic-timer: " tip-bot2 for Marc Zyngier
2026-01-29 21:32   ` [tip: timers/clocksource] " tip-bot2 for Marc Zyngier
2025-12-10  8:22 ` [PATCH 6/6] genirq: Kill setup_percpu_irq() Marc Zyngier
2025-12-15 21:27   ` [tip: irq/core] genirq: Remove setup_percpu_irq() tip-bot2 for Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251210082242.360936-1-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=kumba@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox