From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 901D723EAA3 for ; Wed, 10 Dec 2025 15:01:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765378920; cv=none; b=b+CTIwXtcGsZqqcQpyYo1TeET99AhBeCyRfan5aowxhiqwnV8hiEtkhka7LGDWKIHh26x09p1bM1rpof7HqMfOwX5C+r5W/ZVqZkh6ZzU4s6SE9LLyjiIBFv6dLdBLerMCIr0qIDgrBXOKeI23ImuiZvda3+Hlm7rVl4cARIeV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765378920; c=relaxed/simple; bh=FTxDmILWZKByIw//KW3Bb5wdfTrbrKdINwI+mXvEOkQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Wu8O9jotJvaW/nZuPU+Q51JP7bv3zsG4XjNfpLq0yPZsI8qplDoEtbEZk+l9kOGSgNDSGwnGg8fDQiJqyNMpsI2e8EktXV68BBWosz3A00TC8T6AQ9gbb7lYbN1qW0tD938u+5U3OIgYAQHea4+tZNnhksdE7AN64S3NdxKur6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=FBVKl0GQ; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="FBVKl0GQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1765378916; bh=FTxDmILWZKByIw//KW3Bb5wdfTrbrKdINwI+mXvEOkQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FBVKl0GQl7AWep2KgvLWrEzvaEScSPb/Z+BosXWvlV34kxq5Z3QASXbLzwZaeiC2S C0G9OBI4wTVJYULECARbOheeuAueBNISWxq20jDRxRuhTCH/fULp3df7ea8z5EV2xm FwEv1EpU1JhXPqW2lw3KSSQXp/F54DIsiutMZPf7pDztv9gh1dqJjuGA0JSgVk68hQ /EbyPZbwaarFPjw4RPYKHKFtchWNqxtZIOgMNJDxT7INzXkLyyPjfqNLNf1tI/DJ6h dquwki2xNrax+s4LgR57kAzQgxB/kgao+ReCuhqS9vhtjXZIQaWbg0N4UHAvXDOXuh 3/nNJDV1hUMTg== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 1FBE517E0F05; Wed, 10 Dec 2025 16:01:56 +0100 (CET) Date: Wed, 10 Dec 2025 16:01:50 +0100 From: Boris Brezillon To: Tvrtko Ursulin Cc: =?UTF-8?B?TG/Dr2M=?= Molinari , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , =?UTF-8?B?TWlrb8WCYWo=?= Wasiak , Andi Shyti , Christopher Healy , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kernel@collabora.com, Chaitanya Kumar Borah Subject: Re: [PATCH] drm/i915: Fix BO alloc flags Message-ID: <20251210160150.4dc8f146@fedora> In-Reply-To: References: <20251210110952.691446-1-loic.molinari@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 10 Dec 2025 15:08:02 +0100 Tvrtko Ursulin wrote: > On 10/12/2025 12:09, Lo=C3=AFc Molinari wrote: > > I915_BO_ALLOC_NOTHP must be added to the I915_BO_ALLOC_FLAGS mask in > > order to pass GEM_BUG_ON() valid flags checks. > > > > Reported-by: Chaitanya Kumar Borah > > Closes: https://lore.kernel.org/intel-gfx/d73adfa8-d61b-46b3-9385-dde53= d8db8ad@intel.com/ > > Fixes: a8a9a590221c ("drm/i915: Use huge tmpfs mountpoint helpers") > > Suggested-by: Tvrtko Ursulin > > Signed-off-by: Lo=C3=AFc Molinari > > --- > > drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h b/drivers= /gpu/drm/i915/gem/i915_gem_object_types.h > > index f94409e8ec4c..35d4c7d0c579 100644 > > --- a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h > > @@ -363,6 +363,7 @@ struct drm_i915_gem_object { > > I915_BO_ALLOC_PM_EARLY | \ > > I915_BO_ALLOC_GPU_ONLY | \ > > I915_BO_ALLOC_CCS_AUX | \ > > + I915_BO_ALLOC_NOTHP | \ > > I915_BO_PREALLOC) > > #define I915_BO_READONLY BIT(10) > > #define I915_TILING_QUIRK_BIT 11 /* unknown swizzling; do not rel= ease! */ =20 >=20 > Acked-by: Tvrtko Ursulin >=20 > It is passing BAT so I think it is fine to go ahead and merge it. Of=20 > course via the same branch where the breakage is ie. drm-misc. Pushed to drm-misc-next.