Re: [PATCH 0/9] bitfield: tidy up bitfield.h

Yury Norov
2025-12-10T18:20:18Z

On Tue, Dec 09, 2025 at 10:03:04AM +0000, david.laight.linux@gmail.com wrote:
> From: David Laight <david.laight.linux@gmail.com>
>
> Re-send with patches going to everyone.
> (I'd forgotten I'd set 'ccCover = 0'.)

And this one again appeared in my spambox. Have you any ideas why?

> I noticed some very long (18KB) error messages from the compiler.
> Turned out they were errors on lines that passed GENMASK() to FIELD_PREP().
> Since most of the #defines are already statement functions the values
> can be copied to locals so the actual parameters only get expanded once.
>
> The 'bloat' is reduced further by using a simple test to ensure 'reg'
> is large enough, slightly simplifying the test for constant 'val' and
> only checking 'reg' and 'val' when the parameters are present.

So, can you share the before/after?

> The first two patches are slightly problematic.
>
> drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp_eth.c manages to use
> a #define that should be an internal to bitfield.h, the changed file
> is actually more similar to the previous version.
>
> drivers/thunderbolt/tb.h passes a bifield to FIELD_GET(), these can't
> be used with sizeof or __auto_type. The usual solution is to add zero,
> but that can't be done in FIELD_GET() because it doesn't want the value
> promoted to 'int' (no idea how _Generic() treated it.)
> The fix is just to add zero at the call site.
> (The bitfield seems to be in a structure rad from hardware - no idea
> how that works on BE (or any LE that uses an unusual order for bitfields.)
>
> Both changes may need to to through the same tree as the header file changes.
>
> The changes are based on 'next' and contain the addition of field_prep()
> and field_get() for non-constant values.
>
> I also know it is the merge window.
> I expect to be generating a v2 in the new year (someone always has a comment).
>
> David Laight (9):
> nfp: Call FIELD_PREP() in NFP_ETH_SET_BIT_CONFIG() wrapper
> thunderblot: Don't pass a bitfield to FIELD_GET
> bitmap: Use FIELD_PREP() in expansion of FIELD_PREP_WM16()
> bitfield: Copy #define parameters to locals
> bitfield: FIELD_MODIFY: Only do a single read/write on the target
> bitfield: Update sanity checks
> bitfield: Reduce indentation
> bitfield: Add comment block for the host/fixed endian functions
> bitfield: Update comments for le/be functions
>
> .../netronome/nfp/nfpcore/nfp_nsp_eth.c | 16 +-
> drivers/thunderbolt/tb.h | 2 +-
> include/linux/bitfield.h | 278 ++++++++++--------
> include/linux/hw_bitfield.h | 17 +-
> 4 files changed, 166 insertions(+), 147 deletions(-)
>
> --
> 2.39.5