Re: [PATCH 1/9] nfp: Call FIELD_PREP() in NFP_ETH_SET_BIT_CONFIG() wrapper

Jakub Kicinski
2025-12-10T09:29:52Z

On Tue, 9 Dec 2025 10:03:05 +0000 david.laight.linux@gmail.com wrote:
> Rather than use a define that should be internal to the implementation
> of FIELD_PREP(), pass the shifted 'val' to nfp_eth_set_bit_config()
> and change the test for 'value unchanged' to match.
>
> This is a simpler change than the one used to avoid calling both
> FIELD_GET() and FIELD_PREP() with non-constant mask values.

I'd like this code to be left out of the subjective churn please.
I like it the way I wrote it. I also liked the bitfield.h the way
I wrote it but I guess that part "belongs" to the community at large.

FWIW - thumbs up for patch 8, no opinion on the rest.