public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: Lance Yang <lance.yang@linux.dev>,
	sean@ashe.io, linux-kernel@vger.kernel.org, mhiramat@kernel.org,
	akpm@linux-foundation.org, Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH 1/2] hung_task: Consolidate hung task warning into an atomic log block
Date: Wed, 10 Dec 2025 16:37:03 +0900	[thread overview]
Message-ID: <2025121023-cabdriver-pyromania-80c6@gregkh> (raw)
In-Reply-To: <hnysi7a375k5qlud6d6pirqxvvv4bapkdxypknw4oj7ahzjowf@2cwflngr2dyw>

On Tue, Dec 09, 2025 at 05:14:40PM -0500, Aaron Tomlin wrote:
> On Tue, Dec 09, 2025 at 03:56:58PM +0900, Greg KH wrote:
> > > "%s\n" forces an unconditional newline, causing a spurious blank line when
> > > the flag isn't set, right?
> > 
> > The first \n should not be there, this should be all one line.
> 
> Hi Greg,
> 
> I agree. This will be resolved in a subsequent patch.
> 
> > If you have multiple lines wanting to be printed, use multiple pr_err()
> > calls.
> 
> Unfortunately, sequential pr_err() calls risk having their lines separated
> by other log messages, rendering the warning incoherent. The single-call
> implementation is necessary to ensure the entire message is atomically
> written.

Then perhaps you all shouldn't be dumping all that amount of information
if that's the only api you all are attempting to rely on here?

What is the goal, this should just be debugging information, no tool
should be requiring this, right?

thanks,

greg k-h

  reply	other threads:[~2025-12-10  7:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09  4:12 [PATCH 0/2] hung_task: Provide runtime reset interface for hung task detector Aaron Tomlin
2025-12-09  4:12 ` [PATCH 1/2] hung_task: Consolidate hung task warning into an atomic log block Aaron Tomlin
2025-12-09  5:12   ` Lance Yang
2025-12-09  6:56     ` Greg KH
2025-12-09 22:14       ` Aaron Tomlin
2025-12-10  7:37         ` Greg KH [this message]
2025-12-10 13:08         ` Petr Mladek
2025-12-09 22:11     ` Aaron Tomlin
2025-12-09  4:12 ` [PATCH 2/2] hung_task: Provide runtime reset interface for hung task detector Aaron Tomlin
2025-12-09  4:54   ` Lance Yang
2025-12-09 22:06     ` Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025121023-cabdriver-pyromania-80c6@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@atomlin.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=pmladek@suse.com \
    --cc=sean@ashe.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox