From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FBA82D9EC9 for ; Wed, 10 Dec 2025 07:53:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765353219; cv=none; b=outMRDYkZ/bz+ep7Oi2xvgpPbr8BErORJWnsuqlsyPJyRXjimqYDtUziv+OGTP2BQgCcPtIZ33UTzwnB+AmBMyB5id37mbtslzOrXII/9cxrQIaFJM6vALoD+JqyDIcSrpvvvTOj8tD0np3X9del4lDE04Wd65DvdeizIZX333g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765353219; c=relaxed/simple; bh=5ck6ULO2cIizgcuZw28MV7AU58hyeq9SzH4J/++ZdZw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B5L9Lh4R2ER+2PAGbih/1C7WRKk0qvWN1/wgt0FiYH2uNVCvLJ9gp69y3Pp4WcFAkjCse2CyVikkr7/Dp6Eh+YeO7jXn3jCGYw2ZKsREg+i3rMsB5mcjoU/aeW9rm1+Bu1Y3yKqHK80/fGgIkfH3LsLjFwYNHZ4j5UlrpeXlGXM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GYr/PNhx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GYr/PNhx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0DBCC116B1; Wed, 10 Dec 2025 07:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765353218; bh=5ck6ULO2cIizgcuZw28MV7AU58hyeq9SzH4J/++ZdZw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GYr/PNhxTSZK0OfAqnYJsw7OV6G/4uHApJCZk7WTZMiDc8ard4r/o9Q/thkqbI0NH E8djupaSV6Knfdms6D21ENOWQiYVAzM+/2cUHvlwGvVDSKI1A+MoGYR56TqZ4Rbe24 qSOsJL4ZjbrszV00J7oMaoGci0WGzRGzXXceow+4= Date: Wed, 10 Dec 2025 16:37:03 +0900 From: Greg KH To: Aaron Tomlin Cc: Lance Yang , sean@ashe.io, linux-kernel@vger.kernel.org, mhiramat@kernel.org, akpm@linux-foundation.org, Petr Mladek Subject: Re: [PATCH 1/2] hung_task: Consolidate hung task warning into an atomic log block Message-ID: <2025121023-cabdriver-pyromania-80c6@gregkh> References: <20251209041218.1583600-1-atomlin@atomlin.com> <20251209041218.1583600-2-atomlin@atomlin.com> <2025120902-residence-maggot-c5f4@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 09, 2025 at 05:14:40PM -0500, Aaron Tomlin wrote: > On Tue, Dec 09, 2025 at 03:56:58PM +0900, Greg KH wrote: > > > "%s\n" forces an unconditional newline, causing a spurious blank line when > > > the flag isn't set, right? > > > > The first \n should not be there, this should be all one line. > > Hi Greg, > > I agree. This will be resolved in a subsequent patch. > > > If you have multiple lines wanting to be printed, use multiple pr_err() > > calls. > > Unfortunately, sequential pr_err() calls risk having their lines separated > by other log messages, rendering the warning incoherent. The single-call > implementation is necessary to ensure the entire message is atomically > written. Then perhaps you all shouldn't be dumping all that amount of information if that's the only api you all are attempting to rely on here? What is the goal, this should just be debugging information, no tool should be requiring this, right? thanks, greg k-h