From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB2B7145B3F for ; Fri, 12 Dec 2025 02:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765507550; cv=none; b=QHHql7u/7+58zz0h6LQdWkidgQlhaHQYkc1wyhUrtqYPx8gr97Y5nhEAZVizYT7834IEFd6AiyxpwcxLBdSNVriQ1jRFpYq+Y2/OCXGAWJ04xZLEBW0e9QzdeViix53d1qCk1TSXuabwuB9ex4XmYc5SE9Px4HlF56gH+/yDW7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765507550; c=relaxed/simple; bh=m4docKzSN6U3IisnQGU0vDNlqcdF+sgdQ/746l+2whQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p0ejSK5Eu9fijzZsxfJnXnqlBQELd9UGDIBa1KCbhCtZ7J2XdRJIQZFKCkvqwMGaZCyFsNqOALGbbl/r0eQ2DiMZyBLS9OfEuCIXBmRzPwUZXxVZ1/K+HPsFpGYnccBpVdm6hbzEVzSsdB/hlsTBol/3Tb3GoEmereOuDUNVCxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SaoAKfpK; arc=none smtp.client-ip=209.85.221.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SaoAKfpK" Received: by mail-vk1-f179.google.com with SMTP id 71dfb90a1353d-55b26461e78so236934e0c.3 for ; Thu, 11 Dec 2025 18:45:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765507546; x=1766112346; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SZxE86UOpBkEr43S5oO3m/muydq3y/4ppHxIwZHfNzc=; b=SaoAKfpKRDp+Pf5nRlOYCPsBb7uyOwpVe/VI0nsJxnOuf0MDhieXaKaoR2djWH/j13 m4qPp2GzDxJ2W6qMy2+rWzfE8EAsnpJjhNET5mdt68Gykh/SBTafbDkhyZ8kpc8wFE5L nxdxVz63trEvcAyOgyj4CTGJEu8WLq6liXe/hXbA/g5zZO+a7wunqoTctT4NNX6UdhPJ DFuVtvmi+eHYQ0jgdt6kv3rGPUPD/jycAoCkAjvy8OmRYgE0+lmH9hExB81vfsJJXbZa rvIiZsrKJ+ZkqTKJO29VLGZDyYLRfe/WQ+TDRZXp0tsLMNWqtSE5mv3UNJC6lT/60Xh6 8+sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765507546; x=1766112346; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SZxE86UOpBkEr43S5oO3m/muydq3y/4ppHxIwZHfNzc=; b=b9Jq0VJQUp8hJciw2Ak8fBT521IUP+J9356Mdsdy7+h/lP8ASYpuUTtMYGI0prOnVT 1ZTBXVQu8Ms2nv3+74E7VhNZJMQ+cEFbNDJzAsgKGpNEijaNkKCo4sVCZfllxKvFOO15 ypUvL4dws3ytagPSzK4mIL07IhYCtXMh80zDWHH24ZZEQ1pAdIL65ZwIdUf5IIq4IYnK lwha8yN+lW+uck48NPdFlEUNHMhVHGzgKQX4sCdm4g/GiHX4tTpFN7IoSqzjjeyoKoqb 97UOmQVMEnCrfpu2Iw+GEet/btGIMxP+RX3PAoD9PbCEsXGqkAnF86FpNegrOClaRcuP 2q/A== X-Forwarded-Encrypted: i=1; AJvYcCWel/hHSOKSluNI8sOcRguU4MPAk/39fxM7qfwlB5y4KJAn4aWF3gPu7EIB/g2dEblYeItUha9qYziY7MY=@vger.kernel.org X-Gm-Message-State: AOJu0YxN+nYpdHMBOtBGFO/yWlwCh4f2648O1kcFd6x2h5m1NZTlOFq3 XEo8MUD7CTzszXHOocGPZU6XFavNwdu3Co/tFHqkYRY9X+MTRiIDIMbATgqynA== X-Gm-Gg: AY/fxX55NMf8tRGlK/4n+BXEiwMLApvYddEB+AOMuD+nsnDUcicokOgVSdnlSgzMouX HRxtOdGKfnVnweOySwuhPQEszfHgWs2fkK8UCTsOyn44qENKu/wBd+nWkp4RpNP6Q0aHcHfLNmd 3rpQsUc29HapYhTJPCujpPY2hK7FiDbbTyAx407sZtFpTWFjLbdq1QaOyp3coxT7mFgjwOMLSQf lN+szH2B649CkiIq0ZoIf3oAwhrRrd4CLvWQ3SKiMRxCd1k5pJTrNtkHSSggSqueWK3YxMMqNpC rG0RhHK/36nl0UA6BKOO5oRs06musWZdaOkgNae+eMaYJJ40oBRei9W0fctnNJvAJ58qpZ/LpL2 d+97emm5YNtsyc6GscHe6/wx6AFCjUIJcNyv/zeuph/mgBZ+WeAFjCo8HkIfezTurVfyD6lvQAt GPQxVVEAg/E9cb X-Google-Smtp-Source: AGHT+IE6R1SPTPYAVrVVaJYQAbRBZp7N0gNjOqqIWn71FlnxAZHPp5xMi1+R7KzVuAZ/J+ZqU/BtQg== X-Received: by 2002:a05:6102:5a9a:b0:5dd:84f1:b51a with SMTP id ada2fe7eead31-5e82788200bmr94910137.43.1765507546232; Thu, 11 Dec 2025 18:45:46 -0800 (PST) Received: from [192.168.100.70] ([2800:bf0:82:3d2:875c:6c76:e06b:3095]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5e7d0f25ce2sm1693762137.8.2025.12.11.18.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 18:45:45 -0800 (PST) From: Kurt Borja Date: Thu, 11 Dec 2025 21:45:24 -0500 Subject: [PATCH v2 6/7] iio: health: max30102: Use IIO cleanup helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251211-lock-impr-v2-6-6fb47bdaaf24@gmail.com> References: <20251211-lock-impr-v2-0-6fb47bdaaf24@gmail.com> In-Reply-To: <20251211-lock-impr-v2-0-6fb47bdaaf24@gmail.com> To: Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Benson Leung , Antoniu Miclaus , Gwendal Grignou , Shrikant Raskar , Per-Daniel Olsson Cc: David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Guenter Roeck , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, Kurt Borja X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1978; i=kuurtb@gmail.com; h=from:subject:message-id; bh=m4docKzSN6U3IisnQGU0vDNlqcdF+sgdQ/746l+2whQ=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDJnWjSf782TM12mtP8/XLVE3/SujM+vX+E7D3v0PsgoT4 7rSlvN2lLIwiHExyIopsrQnLPr2KCrvrd+B0Pswc1iZQIYwcHEKwEQO8TEyXOz/F91xtu8Zq0IN k7oqW+9J0QJmwWzmaWVZK+Sm75UqYmSYWfog54KZl+KBeV8agr+f2KM/yclxx5tNi3Y3TJomx2f MBQA= X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Use IIO_DEV_GUARD_ANY_MODE() cleanup helper to simplify and drop busy-waiting code in max30102_read_raw(). Signed-off-by: Kurt Borja --- drivers/iio/health/max30102.c | 33 +++++++++------------------------ 1 file changed, 9 insertions(+), 24 deletions(-) diff --git a/drivers/iio/health/max30102.c b/drivers/iio/health/max30102.c index 288c2f37a4a2..94e15598ffe7 100644 --- a/drivers/iio/health/max30102.c +++ b/drivers/iio/health/max30102.c @@ -467,44 +467,29 @@ static int max30102_read_raw(struct iio_dev *indio_dev, int *val, int *val2, long mask) { struct max30102_data *data = iio_priv(indio_dev); - int ret = -EINVAL; + int ret; switch (mask) { - case IIO_CHAN_INFO_RAW: + case IIO_CHAN_INFO_RAW: { /* * Temperature reading can only be acquired when not in * shutdown; leave shutdown briefly when buffer not running */ -any_mode_retry: - if (!iio_device_claim_buffer_mode(indio_dev)) { - /* - * This one is a *bit* hacky. If we cannot claim buffer - * mode, then try direct mode so that we make sure - * things cannot concurrently change. And we just keep - * trying until we get one of the modes... - */ - if (!iio_device_claim_direct(indio_dev)) - goto any_mode_retry; + IIO_DEV_GUARD_ANY_MODE(indio_dev); - ret = max30102_get_temp(data, val, true); - iio_device_release_direct(indio_dev); - } else { - ret = max30102_get_temp(data, val, false); - iio_device_release_buffer_mode(indio_dev); - } + ret = max30102_get_temp(data, val, !iio_buffer_enabled(indio_dev)); if (ret) return ret; - ret = IIO_VAL_INT; - break; + return IIO_VAL_INT; + } case IIO_CHAN_INFO_SCALE: *val = 1000; /* 62.5 */ *val2 = 16; - ret = IIO_VAL_FRACTIONAL; - break; + return IIO_VAL_FRACTIONAL; + default: + return -EINVAL; } - - return ret; } static const struct iio_info max30102_info = { -- 2.52.0