From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Cezary Rojewski" <cezary.rojewski@intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.dev>,
"Daniel Baluta" <daniel.baluta@nxp.com>,
"Takashi Iwai" <tiwai@suse.de>, "Mark Brown" <broonie@kernel.org>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v1 1/1] ASoC: Fix acronym for Intel Gemini Lake
Date: Thu, 11 Dec 2025 09:17:52 -0600 [thread overview]
Message-ID: <20251211151752.GA3592429@bhelgaas> (raw)
In-Reply-To: <aTrH1H4otA-cQyXa@smile.fi.intel.com>
On Thu, Dec 11, 2025 at 03:32:04PM +0200, Andy Shevchenko wrote:
> On Thu, Dec 11, 2025 at 09:45:54AM +0100, Cezary Rojewski wrote:
> > On 2025-12-10 12:55 PM, Andy Shevchenko wrote:
> > > While the used GML is consistent with the pattern for other Intel * Lake
> > > SoCs, the de facto use is GLK. Update the acronym and users accordingly.
> > > -#define PCI_DEVICE_ID_INTEL_HDA_GML 0x3198
> > > +#define PCI_DEVICE_ID_INTEL_HDA_GLK 0x3198
> >
> > If two #defines are no-go (PCI_DEVICE_ID_INTEL_HDA_GLK and _GML), then
> > perhaps at least a comment to the right of the ID mentioning the "GML" would
> > help.
>
> Bjorn, are you agree on adding a comment to PCI IDs to point out that in a
> couple of Intel documents the machine's acronym is GML?
Sure, that would be fine.
next prev parent reply other threads:[~2025-12-11 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 11:55 [PATCH v1 1/1] ASoC: Fix acronym for Intel Gemini Lake Andy Shevchenko
2025-12-10 15:38 ` Bjorn Helgaas
2025-12-11 8:45 ` Cezary Rojewski
2025-12-11 13:32 ` Andy Shevchenko
2025-12-11 15:17 ` Bjorn Helgaas [this message]
2025-12-16 16:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251211151752.GA3592429@bhelgaas \
--to=helgaas@kernel.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox