Re: [PATCH 01/11] rust: pin-init: internal: remove proc-macro[2] and quote workarounds

Christian Schrefl
2025-12-11T21:50:40Z

Hi Gary,

On 12/11/25 7:56 PM, Gary Guo wrote:
> From: Benno Lossin <lossin@kernel.org>
>
> The kernel only had the `proc-macro` library available, whereas the
> user-space version also used `proc-macro2` and `quote`. Now both are
> available to the kernel, making it possible to remove the workarounds.
>
> Signed-off-by: Benno Lossin <lossin@kernel.org>
> Co-developed-by: Gary Guo <gary@garyguo.net>
> Signed-off-by: Gary Guo <gary@garyguo.net>
> ---

Its good to see some workarounds/hacks get removed!

Overall seems fine, but maybe the imports should be changed to the
multiline kernel style?

Anyways:

Reviewed-by: Christian Schrefl <chrisi.schrefl@gmail.com>

Cheers
Christian