Re: [PATCH 01/11] rust: pin-init: internal: remove proc-macro[2] and quote workarounds

Gary Guo
2025-12-15T13:02:01Z

On Thu, 11 Dec 2025 22:50:35 +0100
Christian Schrefl <chrisi.schrefl@gmail.com> wrote:

> Hi Gary,
>
> On 12/11/25 7:56 PM, Gary Guo wrote:
> > From: Benno Lossin <lossin@kernel.org>
> >
> > The kernel only had the `proc-macro` library available, whereas the
> > user-space version also used `proc-macro2` and `quote`. Now both are
> > available to the kernel, making it possible to remove the workarounds.
> >
> > Signed-off-by: Benno Lossin <lossin@kernel.org>
> > Co-developed-by: Gary Guo <gary@garyguo.net>
> > Signed-off-by: Gary Guo <gary@garyguo.net>
> > ---
>
> Its good to see some workarounds/hacks get removed!
>
> Overall seems fine, but maybe the imports should be changed to the
> multiline kernel style?
>
> Anyways:
>
> Reviewed-by: Christian Schrefl <chrisi.schrefl@gmail.com>

`pin-init` is its own subproject as it's also intended for userspace (or
other baremetal/embedded users). I'll let Benno to decide if he would like
to use kernel multiline import for `pin-init`.

The rest of this series convert files to use kernel import style when
depednencies are changed.

Best,
Gary