From: Greg KH <gregkh@linuxfoundation.org>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: akpm@linux-foundation.org, lance.yang@linux.dev,
mhiramat@kernel.org, pmladek@suse.com, sean@ashe.io,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] hung_task: Consolidate hung task warning into an atomic log block
Date: Thu, 11 Dec 2025 17:02:08 +0900 [thread overview]
Message-ID: <2025121152-gradient-unstylish-4de3@gregkh> (raw)
In-Reply-To: <20251211033004.1628875-2-atomlin@atomlin.com>
On Wed, Dec 10, 2025 at 10:30:03PM -0500, Aaron Tomlin wrote:
> Consolidate the multi-line console output in check_hung_task() into a new
> helper function, hung_task_diagnostics().
>
> This patch ensures the entire diagnostic block (task info, kernel
> version, and sysctl advice) is logged to the ring buffer via a single
> pr_err() call. This is critical in a concurrent environment to prevent
> message lines from interleaving with other CPU activity, thus
> maintaining contextual integrity of the warning message.
If this message is "critical", then it should not be going through the
syslog as that is NOT a "critical" way to communicate things to
userspace.
What is currently breaking today with the multi-line message that you
have? Why is this so much more special than the normal oops / warning /
oom and other type messages that are multi-lines today?
I'm all for moving this to a single function, but I'm not ok with
multi-line messages in one pr_err() call like this, sorry.
Especially one that contains a "here is how to disable this" message
like this one does, that surely is NOT a "critical" thing.
thanks,
greg k-h
next prev parent reply other threads:[~2025-12-11 8:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 3:30 [PATCH v2 0/2] hung_task: Provide runtime reset interface for hung task detector Aaron Tomlin
2025-12-11 3:30 ` [PATCH v2 1/2] hung_task: Consolidate hung task warning into an atomic log block Aaron Tomlin
2025-12-11 8:02 ` Greg KH [this message]
2025-12-15 23:44 ` Aaron Tomlin
2025-12-11 3:30 ` [PATCH v2 2/2] hung_task: Enable runtime reset of hung_task_detect_count Aaron Tomlin
2025-12-11 5:14 ` Lance Yang
2025-12-15 23:38 ` Aaron Tomlin
2025-12-11 15:49 ` kernel test robot
2025-12-15 5:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025121152-gradient-unstylish-4de3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=atomlin@atomlin.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=pmladek@suse.com \
--cc=sean@ashe.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox