From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 129B913635E for ; Thu, 11 Dec 2025 08:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765440133; cv=none; b=cWPshJJkkw/vxs5Lod+kqgg1+ok0K8eQDMw4VwTlGKpCAWS8ZI/9wqhvtgkZm1mAthHXpCKhF60i7N4/CVXKjkeqX8druLgE0Q0wMtwEDnXD6n1NCeApBFO64769yvbQVJxt51kd+priZWYp5LIM+qDEBIRXgwA97i8XZ37FH5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765440133; c=relaxed/simple; bh=6YmwPtc+wbjp1lNWDFIXT+QnPvQwZlsBDbxoUrmjT70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GdVNaMBD+WpQMSpXyuegAVLhl4aOcpHKHiSYtwevX8okHF/tekOuCiWCdFgfhYBxXdeEQZ9IpmBeKzkah96yx/dBVDrksXbRnCwZ1wONTZgBvbJNw/ZOz5LlWWIPka+Va+VdqwVrHxqxDBYaiQMib20elBG6C8SVQaydD4dsT1s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Khuu4Nrv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Khuu4Nrv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19C9EC4CEFB; Thu, 11 Dec 2025 08:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765440132; bh=6YmwPtc+wbjp1lNWDFIXT+QnPvQwZlsBDbxoUrmjT70=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Khuu4Nrv9TVx+z8LYtI1k5FmGK4sA18CnAZ+CBL4V77fs5296JtRh1T9Zq9lXFGVP mBl4ZbmPGQwoEVNjJp4/72QlSurMw9PGwF7fql9y2d/XP5RPmj9OQklLuAUL+CrUOd 7Om3b82I/b9NR3GvJ5dWi9Uatxy09lURIY51A7no= Date: Thu, 11 Dec 2025 17:02:08 +0900 From: Greg KH To: Aaron Tomlin Cc: akpm@linux-foundation.org, lance.yang@linux.dev, mhiramat@kernel.org, pmladek@suse.com, sean@ashe.io, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] hung_task: Consolidate hung task warning into an atomic log block Message-ID: <2025121152-gradient-unstylish-4de3@gregkh> References: <20251211033004.1628875-1-atomlin@atomlin.com> <20251211033004.1628875-2-atomlin@atomlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251211033004.1628875-2-atomlin@atomlin.com> On Wed, Dec 10, 2025 at 10:30:03PM -0500, Aaron Tomlin wrote: > Consolidate the multi-line console output in check_hung_task() into a new > helper function, hung_task_diagnostics(). > > This patch ensures the entire diagnostic block (task info, kernel > version, and sysctl advice) is logged to the ring buffer via a single > pr_err() call. This is critical in a concurrent environment to prevent > message lines from interleaving with other CPU activity, thus > maintaining contextual integrity of the warning message. If this message is "critical", then it should not be going through the syslog as that is NOT a "critical" way to communicate things to userspace. What is currently breaking today with the multi-line message that you have? Why is this so much more special than the normal oops / warning / oom and other type messages that are multi-lines today? I'm all for moving this to a single function, but I'm not ok with multi-line messages in one pr_err() call like this, sorry. Especially one that contains a "here is how to disable this" message like this one does, that surely is NOT a "critical" thing. thanks, greg k-h