From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99B14305050 for ; Fri, 12 Dec 2025 03:34:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765510457; cv=none; b=gauxnCdxunyVjHu3iJt7TIQzd7k8oKRkDUoBWlNgCg/VckXvfAp4SqpQKdveozxC2JezEGUCdgpszpDlZB4YNShiJlbIkiPUlLmSrK6NjuMY8559ffiAKycrjA6NAT/PkdEgct5FS6SepwWzq4IY2NfFeyuLltFc84Z5zPSgaaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765510457; c=relaxed/simple; bh=HsbNc9NhdAR/LG1ML5qxg47G4bhkbg0BKoPAGiEnJGc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BEZrD0akEITVZNX/bTglklhoZAnRcz7/rJsljNsjvSvIRRN3RtueZgZkaWXxAt7KUOA+Zc364s1UpC1XEpJ/Cfh1CBA36ye8uTXHbwkvgJDDPF+OK+oPhjq11jtqDnQzdjCC8XdDwvVFKVm1YVp3Hs0QQSsWVac5+3LW6jzv4Sk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R6vq12U+; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R6vq12U+" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-34abca71f9cso64898a91.3 for ; Thu, 11 Dec 2025 19:34:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765510449; x=1766115249; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DI+KXchmH44mUxxpsbUV6PudffQTHA3dEjh5VjxDDHg=; b=R6vq12U+6TQVWy591Ul6kCAgKRnvWvZVeZvNMANwlOQSMTVFOI57VzVepAiFfEbSut szcqXcL2/HfPDZkURge+l9Y5z8dpaqxsSQxYiw9AGej9kYFZUqyUDX/A+DgEnki2tfPL T2BKUpfQb7h6CPPgfy4uPmxK5ax2Y7fnu3Ddpzol8KxHPQ3j/Reqk2kef1sO745dOheK cx8me85Mx7KRr+xSwpjYpJ/Gw18KlM9YL+k9hKolr0Blx454DgctzgEquvsMA+F3JAL2 WT+XPWWX60R+sXsZ0/CeYV0uMgDjLkgOgUbFIzxGNb36UQ5m1sH1AL77q+2fxc9Rl1gP COXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765510449; x=1766115249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DI+KXchmH44mUxxpsbUV6PudffQTHA3dEjh5VjxDDHg=; b=UoXfmEg0hx5NVI8x8cLjpXWWQoA8aRFgOx+lJPLK9f3pOYtDUnU5pr2MshXx7mV9JY Gvc/Boj1cu+cC63oTT4llIii/dvxP38e+pTx2qSOct0G6iaeDLR6ZcIiSfLLlzQs/NhE uxG51bWhMtEKrbFv/emCG6GWcAsnIeS5RHOF7UM8xUOj83OfjptsIaALcb3CNAkCLEYR p6enOkq+BgzZH5/C2RPXv63rBAB3pSBJc4Y1YRHQSXfksF2KPytIhWueNkOQ8YxCx97L Zl4mofxJwylw1sFYj0CLfh8IjaJseNy5NPsBufq+3OSpp9eyisUYE5sMyWVoDqfbBB4/ ayzg== X-Forwarded-Encrypted: i=1; AJvYcCX6DHYIzcOffIYh0ak/8CpanUv4KWm+tUpda4GBu2Qv4Xgpj5oJQ59o7A9oF51gErgoMCKJbDpSmArU1j0=@vger.kernel.org X-Gm-Message-State: AOJu0YyL7e51gGUrlU294NIeJfwMiVw82w5Z84ALMTEG+nm6AqCJ/bbt drvPqDyirPR7noGPStrdwBcMVcm0l/RMQAS67yAfFtsV1WuQyzs7k1g6 X-Gm-Gg: AY/fxX5hBpEv3IzRtZoZov52++9sM7fsDL/r5HP6r9q//b0UalOtLhZ+Zh/x50wqzWv s8gGJ2waADI7oRPewMg29tv38XCB3eVX3Vc7eqFtMQL/UFxW9CvBWLZiRB7avD28HsuqXGBwkqR ltBCkGOrkJUT2xL8/v/66LchZ+OVpJzCPJqEc4fO+kjBOwLMYceYZaw4hJdkXpsF87Jkm0dtE+0 Vcj7av9mDJlNDGrlMH5BbK9N8O9MnNt2uX2PKISmxOax//Epow0Eaon649OQhQuNsCMYDVLOrHA iIjQNV1/QbACGPhhFnDyoJmS+8JBOQWsEkAHalqw5o8l7Y7wZ7YyHtgWcoLDAfZC7Ea3UW2A6gJ ygokBkmzpz1GaLYqoxLqSigkypyuMAViTQ4TZbkHG8WyLQlHWj40so/FlcG3VpXpQZFgbEQ9ird Mhd9Ubv0PMKvoKMx4= X-Google-Smtp-Source: AGHT+IEq2LErwdAEYXkfS1MvdZpjTJctOQkyTkNrB4+pZbLaSSuDnUfhZAotu6OCfqjLgju1qwGSvQ== X-Received: by 2002:a05:6a21:3397:b0:342:d1c5:491 with SMTP id adf61e73a8af0-369aab23434mr604352637.0.1765510449357; Thu, 11 Dec 2025 19:34:09 -0800 (PST) Received: from rock-5b.. ([27.17.162.110]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c0c2ad5996fsm3575764a12.22.2025.12.11.19.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 19:34:08 -0800 (PST) From: Jianfeng Liu To: benjamin.gaignard@collabora.com Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, heiko@sntech.de, iommu@lists.linux.dev, jgg@ziepe.ca, joro@8bytes.org, kernel@collabora.com, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, mchehab@kernel.org, nicolas.dufresne@collabora.com, p.zabel@pengutronix.de, robh@kernel.org, robin.murphy@arm.com Subject: Re: [PATCH v9 3/7] iommu: Add verisilicon IOMMU driver Date: Fri, 12 Dec 2025 11:31:57 +0800 Message-ID: <20251212033157.3036182-1-liujianfeng1994@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250911155720.180465-4-benjamin.gaignard@collabora.com> References: <20250911155720.180465-4-benjamin.gaignard@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, On Thu, 11 Sep 2025 17:57:13 +0200, Benjamin Gaignard wrote: >+#ifdef CONFIG_VSI_IOMMU >+void vsi_iommu_restore_ctx(struct iommu_domain *domain); >+#else >+static inline void vsi_iommu_restore_ctx(struct iommu_domain *domain) {} >+#endif After applying this patch to v6.18, I get error when building this driver as module: drivers/iommu/vsi-iommu.c:541:6: error: redefinition of 'vsi_iommu_restore_ctx' 541 | void vsi_iommu_restore_ctx(struct iommu_domain *domain) | ^~~~~~~~~~~~~~~~~~~~~ In file included from drivers/iommu/vsi-iommu.c:31: ./include/linux/vsi-iommu.h:18:20: note: previous definition of 'vsi_iommu_restore_ctx' with type 'void(struct iommu_domain *)' 18 | static inline void vsi_iommu_restore_ctx(struct iommu_domain *domain) {} | ^~~~~~~~~~~~~~~~~~~~~ I have to use: #if IS_ENABLED(CONFIG_VSI_IOMMU) instead. Best regards, Jianfeng