Re: [PATCH -next 4/5] mm/mglru: combine shrink_many into shrink_node_memcgs

Johannes Weiner
2025-12-15T21:17:58Z

On Tue, Dec 09, 2025 at 01:25:56AM +0000, Chen Ridong wrote:
> @@ -5822,6 +5779,12 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc)
>
> shrink_one(lruvec, sc);
>
> + if (should_abort_scan(lruvec, sc)) {

Can you please rename this and add the jump label check?

if (lru_gen_enabled() && lru_gen_should_abort_scan())

The majority of the checks in there already happen inside
shrink_node_memcgs() itself. Factoring those out is probably better in
another patch, but no need to burden classic LRU in the meantime.