Re: [PATCH -next 4/5] mm/mglru: combine shrink_many into shrink_node_memcgs

Chen Ridong
2025-12-16T01:23:18Z

On 2025/12/16 5:17, Johannes Weiner wrote:
> On Tue, Dec 09, 2025 at 01:25:56AM +0000, Chen Ridong wrote:
>> @@ -5822,6 +5779,12 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc)
>>
>> shrink_one(lruvec, sc);
>>
>> + if (should_abort_scan(lruvec, sc)) {
>
> Can you please rename this and add the jump label check?
>
> if (lru_gen_enabled() && lru_gen_should_abort_scan())
>
> The majority of the checks in there already happen inside
> shrink_node_memcgs() itself. Factoring those out is probably better in
> another patch, but no need to burden classic LRU in the meantime.

Thank you very much.

Thank you for the suggestion. lru_gen_should_abort_scan() is indeed a better name, and including the
lru_gen_enabled() check in the condition is necessary.

I'll update the patch accordingly.

--
Best regards,
Ridong