The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: evan.li@linux.alibaba.com
Cc: mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
	tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	kitta <kitta@linux.alibaba.com>
Subject: Re: [PATCH] perf/x86: Prevent NULL event deref in handle_pmi_common()
Date: Fri, 12 Dec 2025 11:44:04 +0100	[thread overview]
Message-ID: <20251212104404.GO3911114@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20251212084943.2124787-1-evan.li@linux.alibaba.com>

On Fri, Dec 12, 2025 at 04:49:43PM +0800, evan.li@linux.alibaba.com wrote:
> From: Evan Li <evan.li@linux.alibaba.com>
> 
> handle_pmi_common() may observe an active bit set in cpuc->active_mask
> while the corresponding cpuc->events[] entry has already been cleared,
> which leads to a NULL pointer dereference.
> 
> This can happen when interrupt throttling stops all events in a group
> while PEBS processing is still in progress. perf_event_overflow() can
> trigger perf_event_throttle_group(), which stops the group and clears
> the cpuc->events[] entry, but the active bit may still be set when
> handle_pmi_common() iterates over the events.
> 
> The following change:
> 
> 7e772a93 ("perf/x86: Fix NULL event access and potential PEBS record loss")
> 
> moved cpuc->events[] clearing from x86_pmu_stop() to x86_pmu_del() and
> relied on cpuc->active_mask/pebs_enabled checks. However,
> handle_pmi_common() can still encounter a NULL cpuc->events[] entry
> despite the active bit being set.

How? What is doing del() concurrently with the pmi?

  parent reply	other threads:[~2025-12-12 10:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-12  8:49 [PATCH] perf/x86: Prevent NULL event deref in handle_pmi_common() evan.li
2025-12-12  9:04 ` [tip: perf/urgent] perf/x86/intel: Fix NULL event dereference crash " tip-bot2 for Evan Li
2025-12-13 12:06   ` Peter Zijlstra
2025-12-12 10:44 ` Peter Zijlstra [this message]
2025-12-15  7:43   ` [PATCH] perf/x86: Prevent NULL event deref " Mi, Dapeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251212104404.GO3911114@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=evan.li@linux.alibaba.com \
    --cc=kitta@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox