linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>,
	Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	xiaoyao.li@intel.com, farrah.chen@intel.com
Subject: Re: [PATCH v2] KVM: x86: Don't read guest CR3 when doing async pf while the MMU is direct
Date: Sat, 13 Dec 2025 09:38:59 +0800	[thread overview]
Message-ID: <202512130905.LJZI3LOt-lkp@intel.com> (raw)
In-Reply-To: <20251212135051.2155280-1-xiaoyao.li@intel.com>

Hi Xiaoyao,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 7d0a66e4bb9081d75c82ec4957c50034cb0ea449]

url:    https://github.com/intel-lab-lkp/linux/commits/Xiaoyao-Li/KVM-x86-Don-t-read-guest-CR3-when-doing-async-pf-while-the-MMU-is-direct/20251212-220612
base:   7d0a66e4bb9081d75c82ec4957c50034cb0ea449
patch link:    https://lore.kernel.org/r/20251212135051.2155280-1-xiaoyao.li%40intel.com
patch subject: [PATCH v2] KVM: x86: Don't read guest CR3 when doing async pf while the MMU is direct
config: i386-buildonly-randconfig-004-20251213 (https://download.01.org/0day-ci/archive/20251213/202512130905.LJZI3LOt-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251213/202512130905.LJZI3LOt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512130905.LJZI3LOt-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> arch/x86/kvm/mmu/mmu.c:4525:14: warning: implicit conversion from 'gpa_t' (aka 'unsigned long long') to 'unsigned long' changes value from 18446744073709551615 to 4294967295 [-Wconstant-conversion]
    4525 |                 arch.cr3 = INVALID_GPA;
         |                          ~ ^~~~~~~~~~~
   include/linux/kvm_types.h:54:22: note: expanded from macro 'INVALID_GPA'
      54 | #define INVALID_GPA     (~(gpa_t)0)
         |                          ^~~~~~~~~
   1 warning generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for I2C_K1
   Depends on [n]: I2C [=m] && HAS_IOMEM [=y] && (ARCH_SPACEMIT || COMPILE_TEST [=y]) && OF [=n]
   Selected by [m]:
   - MFD_SPACEMIT_P1 [=m] && HAS_IOMEM [=y] && (ARCH_SPACEMIT || COMPILE_TEST [=y]) && I2C [=m]


vim +4525 arch/x86/kvm/mmu/mmu.c

  4514	
  4515	static bool kvm_arch_setup_async_pf(struct kvm_vcpu *vcpu,
  4516					    struct kvm_page_fault *fault)
  4517	{
  4518		struct kvm_arch_async_pf arch;
  4519	
  4520		arch.token = alloc_apf_token(vcpu);
  4521		arch.gfn = fault->gfn;
  4522		arch.error_code = fault->error_code;
  4523		arch.direct_map = vcpu->arch.mmu->root_role.direct;
  4524		if (arch.direct_map)
> 4525			arch.cr3 = INVALID_GPA;
  4526		else
  4527			arch.cr3 = kvm_mmu_get_guest_pgd(vcpu, vcpu->arch.mmu);
  4528	
  4529		return kvm_setup_async_pf(vcpu, fault->addr,
  4530					  kvm_vcpu_gfn_to_hva(vcpu, fault->gfn), &arch);
  4531	}
  4532	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      parent reply	other threads:[~2025-12-13  1:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-12 13:50 [PATCH v2] KVM: x86: Don't read guest CR3 when doing async pf while the MMU is direct Xiaoyao Li
2025-12-12 23:38 ` kernel test robot
2025-12-13  1:01   ` Sean Christopherson
2025-12-15  2:30     ` Xiaoyao Li
2025-12-15 20:51       ` Sean Christopherson
2025-12-13  1:38 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202512130905.LJZI3LOt-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=farrah.chen@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=seanjc@google.com \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).