From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A9651FA178 for ; Mon, 15 Dec 2025 00:32:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765758736; cv=none; b=iaP8xt1x3/8eiFsBRusOaXGhMTRyljoudAc17lYNLa5b1eniCYw/EH64ySrpWDeSKIVDpS4T8BZhKv6Dy1Xxo5YK0787nmS1cdMZ2Xt2h2ngzHRZMCl2Bos9VkPP5WArTToySph5jKeRE6T66kdtwcx8YyFx2tJzNRqT8VSKVXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765758736; c=relaxed/simple; bh=iDanXjHGL1VenyIF9T2sn7s24shSIuXjweiHQ9QZyBw=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=cyOTLIVD6gta3Bu8ftjiIorEDAzQRXIwYZJMVDRW4K8/dzaR5EwhQIDsGIr8E11SxaCNTh62qampWeTtZ54miBTBzy42GVV+/J7RXgsjySf+bdoVWiO4kOmmR8MS72MDwmmecBaOzErgkn5sFqxkYshnrDBzKCEBABDfDM1lgVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=zrydWG6I; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="zrydWG6I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7522FC4CEF1; Mon, 15 Dec 2025 00:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1765758735; bh=iDanXjHGL1VenyIF9T2sn7s24shSIuXjweiHQ9QZyBw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zrydWG6IPT1jznYJUN56vuve8VampF+tpoLfHM1x4PPjJy9kksx0q+ObWCeB9Ggy0 q/Oc19g4pnVS++7p2yACjKZ0NH9R9vs/6zUH0s32PFHGvGlpAvSUooTJ8M3OKF/DIC zq0KPJUWPpEXHxfmCT1iCEIBxCCrVGHnwIWpLwxU= Date: Sun, 14 Dec 2025 16:32:14 -0800 From: Andrew Morton To: Qiang Ma Cc: bhe@redhat.com, catalin.marinas@arm.com, will@kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH v1 2/3] kexec: print out debugging message if required for kexec_load Message-Id: <20251214163214.5018b9c083f11c7ecc081a5d@linux-foundation.org> In-Reply-To: <20251212095649.857796-3-maqianga@uniontech.com> References: <20251212095649.857796-1-maqianga@uniontech.com> <20251212095649.857796-3-maqianga@uniontech.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 12 Dec 2025 17:56:48 +0800 Qiang Ma wrote: > The commit a85ee18c7900 ("kexec_file: print out debugging message > if required") has added general code printing in kexec_file_load(), > but not in kexec_load(). > > As a result, when using '-d' for the kexec_load interface, > print nothing in the kernel space. That doesn't sound like a thing which "kernel test robot" would detect and report. > Since the segments debugging message has already been printed by the > user-space tool kexec-tools, it will not be printed here in the > kernel space. > > And print out type/start/head of kimage and flags to help debug. > > Signed-off-by: Qiang Ma > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202510310332.6XrLe70K-lkp@intel.com/ Oh I see, that's a warning against an earlier version of this patch. But this is labelled "v1"! I suggest we remove this Reported-by record. > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -166,6 +166,9 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments, > if (ret) > goto out; > > + kexec_dprintk("kexec_load: type:%u, start:0x%lx head:0x%lx flags:0x%lx\n", > + image->type, image->start, image->head, flags); > + > /* Install the new kernel and uninstall the old */ > image = xchg(dest_image, image); Thanks, I'll await reviewer input before proceeding with this series.