public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Prithvi Tambewagh <activprithvi@gmail.com>
To: syzbot+c818e5c4559444f88aa0@syzkaller.appspotmail.com,
	jlbec@evilplan.org, joseph.qi@linux.alibaba.com, mark@fasheh.com,
	heming.zhao@suse.com
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@lists.linux.dev,
	syzkaller-bugs@googlegroups.com,
	Prithvi Tambewagh <activprithvi@gmail.com>
Subject: Syzbot test for v3: ocfs2: fix kernel BUG in ocfs2_write_block
Date: Mon, 15 Dec 2025 00:04:40 +0530	[thread overview]
Message-ID: <20251214183443.21515-1-activprithvi@gmail.com> (raw)
In-Reply-To: <66eb6a0e.050a0220.115905.001b.GAE@google.com>

#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 24172e0d79900908cf5ebf366600616d29c9b417

Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
---
 fs/ocfs2/slot_map.c | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/fs/ocfs2/slot_map.c b/fs/ocfs2/slot_map.c
index e544c704b583..9406ac37af6b 100644
--- a/fs/ocfs2/slot_map.c
+++ b/fs/ocfs2/slot_map.c
@@ -132,7 +132,8 @@ int ocfs2_refresh_slot_info(struct ocfs2_super *osb)
 	 * this is not true, the read of -1 (UINT64_MAX) will fail.
 	 */
 	ret = ocfs2_read_blocks(INODE_CACHE(si->si_inode), -1, si->si_blocks,
-				si->si_bh, OCFS2_BH_IGNORE_CACHE, NULL);
+				si->si_bh, OCFS2_BH_IGNORE_CACHE,
+				ocfs2_validate_slot_map_block);
 	if (ret == 0) {
 		spin_lock(&osb->osb_lock);
 		ocfs2_update_slot_info(si);
@@ -332,6 +333,26 @@ int ocfs2_clear_slot(struct ocfs2_super *osb, int slot_num)
 	return ocfs2_update_disk_slot(osb, osb->slot_info, slot_num);
 }
 
+static int ocfs2_validate_slot_map_block(struct super_block *sb,
+					 struct buffer_head *bh)
+{
+	int rc;
+
+	BUG_ON(!buffer_uptodate(bh));
+
+	if (bh->b_blocknr < OCFS2_SUPER_BLOCK_BLKNO) {
+		rc = ocfs2_error(sb,
+				 "Invalid Slot Map Buffer Head "
+				 "Block Number : %llu, Should be >= %d",
+				 (unsigned long long)bh->b_blocknr,
+				 OCFS2_SUPER_BLOCK_BLKNO);
+		if (!rc)
+			return -EIO;
+		return rc;
+	}
+	return 0;
+}
+
 static int ocfs2_map_slot_buffers(struct ocfs2_super *osb,
 				  struct ocfs2_slot_info *si)
 {
@@ -383,7 +404,8 @@ static int ocfs2_map_slot_buffers(struct ocfs2_super *osb,
 
 		bh = NULL;  /* Acquire a fresh bh */
 		status = ocfs2_read_blocks(INODE_CACHE(si->si_inode), blkno,
-					   1, &bh, OCFS2_BH_IGNORE_CACHE, NULL);
+					   1, &bh, OCFS2_BH_IGNORE_CACHE,
+					   ocfs2_validate_slot_map_block);
 		if (status < 0) {
 			mlog_errno(status);
 			goto bail;

base-commit: 24172e0d79900908cf5ebf366600616d29c9b417
-- 
2.43.0


  parent reply	other threads:[~2025-12-14 18:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-19  0:02 [syzbot] [ocfs2?] kernel BUG in ocfs2_write_block syzbot
2025-12-06 12:31 ` Syzbot testing for ocfs2: Fix " Prithvi Tambewagh
2025-12-06 12:52   ` [syzbot] [ocfs2?] " syzbot
2025-12-06 13:04 ` Syzbot testing for ocfs2: Fix " Prithvi Tambewagh
2025-12-06 13:36   ` [syzbot] [ocfs2?] " syzbot
2025-12-06 15:19 ` Syzbot testing for ocfs2: Fix " Prithvi Tambewagh
2025-12-06 15:43   ` [syzbot] [ocfs2?] " syzbot
2025-12-10 18:40 ` Syzbot test for ocfs2: fix " Prithvi Tambewagh
2025-12-10 19:10   ` [syzbot] [ocfs2?] " syzbot
2025-12-14 18:34 ` Prithvi Tambewagh [this message]
2025-12-14 18:59   ` syzbot
2025-12-14 19:20 ` Syzbot test for v3: ocfs2: fix " Prithvi Tambewagh
2025-12-14 19:28   ` [syzbot] [ocfs2?] " syzbot
2025-12-15  4:44   ` Syzbot test for v3: ocfs2: fix " kernel test robot
2025-12-15  4:44   ` kernel test robot
2025-12-15 11:22   ` kernel test robot
2025-12-15 11:39   ` kernel test robot
2025-12-15  4:38 ` Syzbot test for ocfs2: Add validate function for slot map blocks Prithvi Tambewagh
2025-12-15  5:01   ` [syzbot] [ocfs2?] kernel BUG in ocfs2_write_block syzbot
2025-12-15 17:16 ` Syzbot test for v4: ocfs2: Add validate function for slot map blocks Prithvi Tambewagh
2025-12-15 18:22   ` [syzbot] [ocfs2?] kernel BUG in ocfs2_write_block syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251214183443.21515-1-activprithvi@gmail.com \
    --to=activprithvi@gmail.com \
    --cc=heming.zhao@suse.com \
    --cc=jlbec@evilplan.org \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@lists.linux.dev \
    --cc=syzbot+c818e5c4559444f88aa0@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox