From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01ED92E093F for ; Sun, 14 Dec 2025 19:09:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765739401; cv=none; b=aHcwQn06TuneHCv/f1BXfiqF6Q+3O9RHZzsZ4a+rqLuV2OQfeOHwcAoiIm+dOJhc+Rqm+TFZbyNgXveRL/iIrOz8OkvPalD07zOaqQ77yzFxmt2lDA3BPaxqRsproWJ6y7WjUBz/2/2m7vyRU+dZoBRnjgj4TIeolkAadHOrCug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765739401; c=relaxed/simple; bh=pWT1cPEvuIsmQo6GtAuGEsb57xm3hz5gYaHUhJkIbyM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UEUBtcghU+km49+3oEg8kzBt658m2itnyxeNEmK14tNL25yRWYCE8eq9xtxlT/2UX3jKOLRTRubBtMdqYZOINfaELywbXGCslgfhaVnpJnrgKOxI1BefMK8waIhZ8yXQX07/PcdhqSZ75e6bSlZdjZlQY2yO/RmS0H7p68/miso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kOn9kQGZ; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kOn9kQGZ" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7f0db5700b2so2431217b3a.0 for ; Sun, 14 Dec 2025 11:09:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765739399; x=1766344199; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6g+gpMOnc0vQHF+ukJzfO2USCcKfWV/qKZdEDby2+sQ=; b=kOn9kQGZSX3npLPN5nHCKN1zSf+ok3Rj0BH+BoQeS9GPeUDjkExnThqHyyJIXddEuM Tmjrb9JwjwFISHaE6TiqSPjB34buyZFtOz3dPjhuqEG6W+sjWhYPlcBnDW06fGWRZ5UO 0dBzDOEwaZylnd9u5cD4q3Io6KEbIDWJUcJlQuwmLimTEMBgFQOYMDnot+tHTmOa/Goj B9uaqy/9RjZhnu/EujCpD6Jeuc0a9MZSUKmdUxmcy7JA2ZreEByujs48jkTgm+yPbJWp yPP6jzgL7jGaSG0LmNmOhAabtUttnCyLHuLXizy2WsF4WfUgIWpTXjifAxxBwJJA9YAp IvzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765739399; x=1766344199; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6g+gpMOnc0vQHF+ukJzfO2USCcKfWV/qKZdEDby2+sQ=; b=wtt9jPes3wED3HuIn9GGkqbmN7PDTApuSkJ+TEh+KUXeEabZ3ax/fmsVlwjNxf91hJ ADP/uBGZRzZ/BBWrnF7LVrrrcHh09j0tlKbI3XKPpxkNYvFcJH9tZj6GDzXXIRwzERDE Ud/CXJ27Qr9X2wE6DjCpC+YDjLvGfNIm61CApKxDw3hBiK8UDSWbJy97+AH/tx0G/stI blbp7JeLaXjC1AMQne52mt3XTPuYtS7GMo+VxW06oSgQabg6sqkVon64l+j62pQi5fOs bZA2ihykOXBMM61oXU8aSsJxfoigeKLjPxnss32UnY4nsbcCSn+G8ZIyHpDpW2XqD4W8 LBZg== X-Gm-Message-State: AOJu0YxzVxS77wF3/nKe6u6ynrYfR+VRntKMaaZEnX4bWywW2gfNKwFW 0kEMs959W6bvrRJlfSihAe8unV0j1OfdF0Sgt7lahGV22PEierD7jWaU X-Gm-Gg: AY/fxX66jsxEKQlU4mdaB3odn1wIErAR96Y8Qq8Nhp3XktYHDCOx8Zr7wShlm2rkhKl J+XgumznWYH7LC199kGijnruqRY0lYvSIrNcjE5dDP7K+yZgtNuP+5ZgSjS5hwTkiniCNxDTHD6 g+D3yjMAHdkddVQqe0ZqR+ECGt6NF1RCCMlcXkDEzio/TbPBXNth9eoUo6tRWfMHPo1F7A+efQA UrdK70VV4RsI99ktrgnEwJWyz3eW8iRdIPC49WGEbdmny+oo1+S0g085NAdCMilwFkwSlQ3TB+5 1XVjUL9WzKXwSpXY1jRDABDrqlFnM3dM9KCH7kdPtzBWSvb8BdDTf2TJR1vjXPhrHb+0wWIXdTA Z9oGSJanW26wTKKQgjVe7uy2eGzwPoaq6oUqt8MfrLAwqmFXJn1oiSK+Q9NhMD9JocG4Fr624cp N0bGLU8PlRUPXP6Y3cho3VskybhTSJbgg= X-Google-Smtp-Source: AGHT+IFEjQ5W/F/1GV+Udmo7P6q8cvk4k0ZspkiPRW94iOHQJNGagX56DVsdqgrn7t+EEED1vTORKQ== X-Received: by 2002:a05:6a20:72a8:b0:366:14af:9bbd with SMTP id adf61e73a8af0-369b07ae5b5mr8721021637.71.1765739399013; Sun, 14 Dec 2025 11:09:59 -0800 (PST) Received: from DESKTOP-8TIG9K0.localdomain ([119.28.20.50]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34abe3a1c5esm6909062a91.3.2025.12.14.11.09.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Dec 2025 11:09:57 -0800 (PST) From: Xie Yuanbin To: tglx@linutronix.de, peterz@infradead.org, riel@surriel.com, segher@kernel.crashing.org, david@kernel.org, hpa@zytor.com, arnd@arndb.de, acme@kernel.org, adrian.hunter@intel.com, agordeev@linux.ibm.com, akpm@linux-foundation.org, alex@ghiti.fr, alexander.shishkin@linux.intel.com, andreas@gaisler.com, anshuman.khandual@arm.com, aou@eecs.berkeley.edu, borntraeger@linux.ibm.com, bp@alien8.de, bsegall@google.com, dave.hansen@linux.intel.com, davem@davemloft.net, dietmar.eggemann@arm.com, frederic@kernel.org, gor@linux.ibm.com, hca@linux.ibm.com, irogers@google.com, james.clark@linaro.org, jolsa@kernel.org, juri.lelli@redhat.com, justinstitt@google.com, lorenzo.stoakes@oracle.com, luto@kernel.org, mark.rutland@arm.com, mathieu.desnoyers@efficios.com, max.kellermann@ionos.com, mgorman@suse.de, mingo@redhat.com, morbo@google.com, namhyung@kernel.org, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, nysal@linux.ibm.com, palmer@dabbelt.com, paulmck@kernel.org, pjw@kernel.org, rostedt@goodmis.org, ryan.roberts@arm.com, svens@linux.ibm.com, thuth@redhat.com, urezki@gmail.com, vincent.guittot@linaro.org, vschneid@redhat.com, linux@armlinux.org.uk Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-perf-users@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH v5 2/3] sched: Make raw_spin_rq_unlock() inline Date: Mon, 15 Dec 2025 03:09:06 +0800 Message-ID: <20251214190907.184793-3-qq570070308@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251214190907.184793-1-qq570070308@gmail.com> References: <20251214190907.184793-1-qq570070308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit raw_spin_rq_unlock() is short, and is called in some hot code paths such as finish_lock_switch. Make raw_spin_rq_unlock() inline to optimize performance. Signed-off-by: Xie Yuanbin Cc: Thomas Gleixner Cc: Rik van Riel Cc: Segher Boessenkool Cc: David Hildenbrand (Red Hat) Cc: Peter Zijlstra Cc: H. Peter Anvin (Intel) --- kernel/sched/core.c | 5 ----- kernel/sched/sched.h | 6 +++++- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 41ba0be16911..20146da3f181 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -678,11 +678,6 @@ bool raw_spin_rq_trylock(struct rq *rq) } } -void raw_spin_rq_unlock(struct rq *rq) -{ - raw_spin_unlock(rq_lockp(rq)); -} - /* * double_rq_lock - safely lock two runqueues */ diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index d30cca6870f5..bef6cb13266d 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1551,13 +1551,17 @@ static inline void lockdep_assert_rq_held(struct rq *rq) extern void raw_spin_rq_lock_nested(struct rq *rq, int subclass); extern bool raw_spin_rq_trylock(struct rq *rq); -extern void raw_spin_rq_unlock(struct rq *rq); static inline void raw_spin_rq_lock(struct rq *rq) { raw_spin_rq_lock_nested(rq, 0); } +static inline void raw_spin_rq_unlock(struct rq *rq) +{ + raw_spin_unlock(rq_lockp(rq)); +} + static inline void raw_spin_rq_lock_irq(struct rq *rq) { local_irq_disable(); -- 2.51.0