From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5A533126B4 for ; Mon, 15 Dec 2025 01:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765763809; cv=none; b=FXZseKM5ovNWd1WQnGCswHLf1RYGZZzug4XwfOWks3jzBj3oF/g3laX1YjIReVVrJias8yh4zm7vNk1GNCa5T3FXr8CGccP+C1Ns4XBjGD+vLatRq6+eXjm/3b+fXM7a58jpw2egS00nM25HxHVqzCKw5WYF+6hB6+8jCyA8a64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765763809; c=relaxed/simple; bh=rlbA3d1XPV1KH1+xzw9DF0M07EEjFUgmB006yft8gpc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J0qavJexivfRwNNfJ9dfhRoI5/4iI5LpyROn3DWGg649xJColkad3dJBIFWLZtc9nWNWIspJlj6nheWfXK/L0NIhpw9aWyOokaT//dbc531zFH6ZNfyq6SPI+EJ2Ps/JmOqgYcXuAs4lLcZlHAfnLeSoG2Sp6kATTkeX76cm81I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U7D4kn8R; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U7D4kn8R" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a0bae9aca3so12411345ad.3 for ; Sun, 14 Dec 2025 17:56:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765763807; x=1766368607; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z0lC7zjEAe7BuKplLBzarQG8mPzpHJVdoPmL8N89360=; b=U7D4kn8Rm1Vj0Ed2jjgVoYvbRFufQYInc7+FmrEPrCrVX5Hu5MVnIjkRoi/IowUy7X Xfd+hF7YTOWwBEatHo535V1DL4YAISQI1q5e4peEDp06EwstV05sMZEbBOik0fqPVx60 T82EJ078A74dhpZUJTW+CkAicZCnn+6ZhXNvkk9+95qR+2FsW2i3MWu1XIugNH12u7OV /mwy5wm9wV2KwhkeC4RYdAPGk6nffRUuSIGDFtMCWMyCTFSZviNzyN6iXod/MFpFKkJn hUdDKKA9RnawOlgu6ZfyuFDjQXNXBZ5H0JutEDE/Zce5z+qyfhFJK7oSg827M6GzRcYI bFCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765763807; x=1766368607; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z0lC7zjEAe7BuKplLBzarQG8mPzpHJVdoPmL8N89360=; b=HnclZEC4w+45wtUlto6DfFFXzcWO+EP6bvUDUVbxf/qW2cin3fYjD0dbr/nOPEiHL7 qjyCz79dLnVDGnIvNmtxhjSE6hK6oWtZgXyHiWUcGT1M/N0q4Vhmyqdv1JTNJE16uSWT RSyU34OBo/oDRG9UtdeTQDPMg5c60ZBkyYmcO1caq1zHnaxdrnO8FqNCNXA8b5fXxhuI 5IoPlnw0RMstoTNoxS3U/6Khs5YVP63+E6QAoZh2QF4wH1QkIGoimgW1+Bcbpl2gcHxj aguZmMMD4sngA8+UFPf10J/i/Xxz0YyuNeaCKIxDXNuSkD6Nn2u4W5L/vYjtnobRH+q1 RHlg== X-Forwarded-Encrypted: i=1; AJvYcCVJ3IEyYbTJVzv4xUhErzuo3J1m5KY+nI9EAmV1yK7UHfMDRj96ViGMU13M0Ry8I2tCoahzexss3dRQbPM=@vger.kernel.org X-Gm-Message-State: AOJu0YyvuVBo+ZRJ7GQt95A1kWrhpbgyYyAYh7gy5Lo1tBJxWidBFDow fPtPgJPxEq5ntNfPCHmjlW093V5zyikkUKrhHdU8zu5fY/9Tu0kMTDxL X-Gm-Gg: AY/fxX4Ec+gNr0alYzs0se7n4iFsv43qSX+lMCrKunRdQ2xbRoiSA4iJ0EfnvoNE0z6 9Dw3vc6fMG8Zn6UDFAF85TrO7R5OlSY4uKHJOPAGBUshI6vfSTuyZv6MZ+FBpCcROuVpFyTMYCc ahGCyRINrwxhLxu2i6kiZflNNVMZcT7ZXKRm5wDyG2v/FfFW91SrBHLRkSqPc+wFvNh7gKW0Mt3 AfHYedx0r7TW11tf9Ir4QEM9V51QqH6UJSxhipKGJ00H3LrxIfQA+LjR/ACetwPm7ip0bFHaNZo pRWgmMCbBc28EXbFaSD/BTSDmE5ju0lMb2h1OhmKUeCXZjeJNrRfkN6cas3z33GaSCyMVsibt/M RjpSGDjHzzMXwgAc8h1PjwVxP3mCy0LNpfshRkM/icR3WO5PlAs+k7YS00MEgBDaYp7lsRpEAgP qP6OkBovfkBT4Nk6+Xpt2kZAaOh7ST8pJx X-Google-Smtp-Source: AGHT+IGseO3oEw1ZtuNq8UpLrMOmILMw0iwAJbnPBLWPnHaSKfUQa5DbfqBEvmxUAjKwWJiRYlRUiA== X-Received: by 2002:a17:902:ce09:b0:2a0:d5df:111b with SMTP id d9443c01a7336-2a0d5df1341mr26418985ad.50.1765763806863; Sun, 14 Dec 2025 17:56:46 -0800 (PST) Received: from nitin-ThinkPad-T1g-Gen-8.. ([2405:201:3006:188a:90c8:dd19:c7f5:929c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a0be984c7csm30097495ad.66.2025.12.14.17.56.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Dec 2025 17:56:46 -0800 (PST) From: Nitin Joshi To: hansg@kernel.org, ilpo.jarvinen@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, njoshi1@lenovo.com, Nitin Joshi , Mark Pearson Subject: [PATCH v3 2/2] platform/x86: thinkpad_acpi: Add sysfs to display details of damaged device. Date: Mon, 15 Dec 2025 10:56:10 +0900 Message-ID: <20251215015611.16002-2-nitjoshi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251215015611.16002-1-nitjoshi@gmail.com> References: <20251215015611.16002-1-nitjoshi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add new sysfs interface to identify the impacted component with location of device. Reviewed-by: Mark Pearson Signed-off-by: Nitin Joshi --- Changes since v2: -Control visibility of the sysfs attribute based upon ucdd_supported --- .../admin-guide/laptops/thinkpad-acpi.rst | 13 +- drivers/platform/x86/lenovo/thinkpad_acpi.c | 114 +++++++++++++++++- 2 files changed, 122 insertions(+), 5 deletions(-) diff --git a/Documentation/admin-guide/laptops/thinkpad-acpi.rst b/Documentation/admin-guide/laptops/thinkpad-acpi.rst index 94349e5f1298..3a9190ac47d0 100644 --- a/Documentation/admin-guide/laptops/thinkpad-acpi.rst +++ b/Documentation/admin-guide/laptops/thinkpad-acpi.rst @@ -1580,7 +1580,7 @@ Documentation/ABI/testing/sysfs-class-power. Hardware damage detection capability ----------------- -sysfs attributes: hwdd_status +sysfs attributes: hwdd_status, hwdd_detail Thinkpads are adding the ability to detect and report hardware damage. Add new sysfs interface to identify the damaged device status. @@ -1594,6 +1594,17 @@ This value displays status of device damaged - 0 = Not Damaged - 1 = Damaged +The command to check location of damaged device is:: + + cat /sys/devices/platform/thinkpad_acpi/hwdd_detail + +This value displays location of damaged device having 1 line per damaged "item". +For example: +if no damage is detected: + No damage detected +if damage detected: + TYPE-C: Base, Right side, Center port + The property is read-only. If feature is not supported then sysfs attribute is not created. diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform/x86/lenovo/thinkpad_acpi.c index b0f7dc0bd531..0dc6d7e07213 100644 --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c @@ -11089,8 +11089,24 @@ static const struct attribute_group auxmac_attr_group = { #define HWDD_NOT_SUPPORTED BIT(31) #define HWDD_SUPPORT_USBC BIT(0) -#define PORT_STATUS GENMASK(7, 4) -#define NUM_PORTS 4 +#define PORT_STATUS GENMASK(7, 4) +#define LID_STATUS GENMASK(11, 8) +#define BASE_STATUS GENMASK(15, 12) +#define POS_STATUS GENMASK(3, 2) +#define PANEL_STATUS GENMASK(1, 0) + +#define PORT_DETAIL_OFFSET 16 + +#define PANEL_TOP 0 +#define PANEL_BASE 1 +#define PANEL_LEFT 2 +#define PANEL_RIGHT 3 + +#define POS_LEFT 0 +#define POS_CENTER 1 +#define POS_RIGHT 2 + +#define NUM_PORTS 4 static bool hwdd_support_available; static bool ucdd_supported; @@ -11108,7 +11124,96 @@ static int hwdd_command(int command, int *output) return 0; } -/* sysfs type-c damage detection capability */ +static bool display_damage(char *buf, int *count, char *type, unsigned int dmg_status) +{ + unsigned char lid_status, base_status, port_status; + unsigned char loc_status, pos_status, panel_status; + bool damage_detected = false; + int i; + + port_status = FIELD_GET(PORT_STATUS, dmg_status); + lid_status = FIELD_GET(LID_STATUS, dmg_status); + base_status = FIELD_GET(BASE_STATUS, dmg_status); + for (i = 0; i < NUM_PORTS; i++) { + if (!(dmg_status & BIT(i))) + continue; + + if (port_status & BIT(i)) { + *count += sysfs_emit_at(buf, *count, "%s: ", type); + loc_status = (dmg_status >> (PORT_DETAIL_OFFSET + (4 * i))) & 0xF; + pos_status = FIELD_GET(POS_STATUS, loc_status); + panel_status = FIELD_GET(PANEL_STATUS, loc_status); + + if (lid_status & BIT(i)) + *count += sysfs_emit_at(buf, *count, "Lid, "); + if (base_status & BIT(i)) + *count += sysfs_emit_at(buf, *count, "Base, "); + + switch (pos_status) { + case PANEL_TOP: + *count += sysfs_emit_at(buf, *count, "Top, "); + break; + case PANEL_BASE: + *count += sysfs_emit_at(buf, *count, "Bottom, "); + break; + case PANEL_LEFT: + *count += sysfs_emit_at(buf, *count, "Left, "); + break; + case PANEL_RIGHT: + *count += sysfs_emit_at(buf, *count, "Right, "); + break; + default: + pr_err("Unexpected value %d in switch statement\n", pos_status); + }; + + switch (panel_status) { + case POS_LEFT: + *count += sysfs_emit_at(buf, *count, "Left port\n"); + break; + case POS_CENTER: + *count += sysfs_emit_at(buf, *count, "Center port\n"); + break; + case POS_RIGHT: + *count += sysfs_emit_at(buf, *count, "Right port\n"); + break; + default: + *count += sysfs_emit_at(buf, *count, "Undefined\n"); + break; + }; + damage_detected = true; + } + } + return damage_detected; +} + +/* sysfs type-c damage detection detail */ +static ssize_t hwdd_detail_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + bool damage_detected = false; + unsigned int damage_status; + int err, count = 0; + + + if (ucdd_supported) { + /* Get USB TYPE-C damage status */ + err = hwdd_command(HWDD_GET_DMG_USBC, &damage_status); + if (err) + return err; + + if (display_damage(buf, &count, "Type-C", damage_status)) + damage_detected = true; + } else + return -ENODEV; + + if (!damage_detected) + count += sysfs_emit_at(buf, count, "No damage detected\n"); + + return count; +} + +/* sysfs typc damage detection capability */ static ssize_t hwdd_status_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -11132,13 +11237,14 @@ static ssize_t hwdd_status_show(struct device *dev, } else return -ENODEV; - return sysfs_emit(buf, "0\n"); } static DEVICE_ATTR_RO(hwdd_status); +static DEVICE_ATTR_RO(hwdd_detail); static struct attribute *hwdd_attributes[] = { &dev_attr_hwdd_status.attr, + &dev_attr_hwdd_detail.attr, NULL }; -- 2.43.0