Re: [PATCH 3/5] firmware: dmi: Read additional information when decoding DMI table

kernel test robot
2025-12-15T04:32:13Z

Hi Mario,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tip/master]
[also build test WARNING on linus/master tip/auto-latest v6.19-rc1 next-20251215]
[cannot apply to tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello-AMD/firmware-dmi-Correct-an-indexing-error-in-dmi-h/20251215-025606
base: tip/master
patch link: https://lore.kernel.org/r/20251214185309.152614-4-superm1%40kernel.org
patch subject: [PATCH 3/5] firmware: dmi: Read additional information when decoding DMI table
config: i386-allnoconfig (https://download.01.org/0day-ci/archive/20251215/202512151248.aV3iuNkX-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251215/202512151248.aV3iuNkX-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512151248.aV3iuNkX-lkp@intel.com/

All warnings (new ones prefixed by >>):

drivers/firmware/dmi_scan.c: In function 'dmi_save_additional':
>> drivers/firmware/dmi_scan.c:398:21: warning: variable 'strings' set but not used [-Wunused-but-set-variable]
398 | const char *strings;
| ^~~~~~~

vim +/strings +398 drivers/firmware/dmi_scan.c

395
396 static void __init dmi_save_additional(const struct dmi_additional_info *info)
397 {
> 398 const char *strings;
399 const u8 *data;
400 int count = 0;
401 int i;
402
403 if (!info || info->header.length < 5 + info->count * 5)
404 return;
405
406 data = info->entries;
407 strings = (const char *)(data + info->count * 5);
408
409 for (i = 0; i < info->count; i++) {
410 u8 entry_length = data[i * 5];
411 u8 string_num = data[i * 5 + 4];
412 const char *string_ptr;
413 char *value;
414 int len;
415
416 if (entry_length < 5 || string_num == 0)
417 continue;
418
419 string_ptr = dmi_string_nosave(&info->header, string_num);
420 if (!string_ptr || !*string_ptr)
421 continue;
422
423 len = strlen(string_ptr);
424 if (len == 0)
425 continue;
426
427 value = dmi_alloc(len + 1);
428 if (!value)
429 continue;
430
431 strscpy(value, string_ptr, len + 1);
432
433 dmi_save_one_device(DMI_DEV_TYPE_ADDITIONAL, value);
434 count++;
435 }
436 }
437

--
0-DAY CI Kernel Test Service