Re: [PATCH 1/5] firmware: dmi: Correct an indexing error in dmi.h

Mario Limonciello
2025-12-15T21:24:24Z

On 12/15/25 3:11 PM, Yazen Ghannam wrote:
> On Sun, Dec 14, 2025 at 12:53:05PM -0600, Mario Limonciello (AMD) wrote:
>> The entries later in `enum dmi_entry_type` don't match the SMBIOS
>> specification. The entry for type 33: `64-Bit Memory Error Information`
>> is not present and thus the index for all later entries is incorrect.
>>
>> Add the missing type 33 entry.
>
> Types 43, 44, 45, and 46 are missing also. Should those be added as
> well?
>
> Probably not needed right now, but would be good to add them in a
> future patch. I think there's precedent for keeping definitions up to
> date with the spec even if they're not immediately used. ACPI does
> this, I think.

OK, thanks. I'll tail another patch to the next spin of the series to
add those too.

>
>>
>> Fixes: 93c890dbe5287 ("firmware: Add DMI entry types to the headers")
>> Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0a.pdf
>> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
>
> Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
>
> Thanks,
> Yazen