From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40584327BE4
	for <linux-kernel@vger.kernel.org>; Tue, 16 Dec 2025 04:24:32 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1765859073; cv=none; b=MX0BWNwgRV2+yXndeGTyIO3DCt3akbgKS2DJ3ES/Va37PDtYLdrba0i/Tj9Jy/BCpq6nQolkmu32GnzXj1o4/sx9Ljtnchn905rdwKDVnNAoQpfCxalsccx6se5GdPNun39xAufKkWzRfH7u9dJTAcFtwK7oOUi4VrCJ/gFgYyo=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1765859073; c=relaxed/simple;
	bh=ANKOpCMnioMsTz/HFb4OCkizsWZi5V5ZXpX+BvDht1Q=;
	h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:
	 Mime-Version:Content-Type; b=Z5wO0xv0tyXFx246F8rVm3Lz6ZoDd0+pjQ8mQ1FNpjBpAybDLUPbE9uEhchU6BGCVgcwaONBK9++I9s7Z5k6i6ydzrsz5w0bqIEVKJs58XHFlho0JrzMGEYQ8CdANcdQsClmWnKRTMS4YjGzYr+JfwFVUxwXZc5gw065l3LeXiM=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=aJO8Hgmf; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="aJO8Hgmf"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44636C4CEF1;
	Tue, 16 Dec 2025 04:24:31 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
	s=korg; t=1765859071;
	bh=ANKOpCMnioMsTz/HFb4OCkizsWZi5V5ZXpX+BvDht1Q=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=aJO8HgmfBI2EOGwGhqB7xV4m9UU/XhAMRyiPugxo5K4rZ+3QDX64jxe+G9+Wxt48/
	 QBT7lDRwKnHKWdCgDPggoyxj2nMvNU3lp12UtwXsOM3VMgEAw3mr5SfOTxd2n7p40d
	 W5dfjjOfRvHu8pHe/miSIAdXpyzVTPy3OHfvrZHI=
Date: Mon, 15 Dec 2025 20:24:30 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Brendan Jackman <jackmanb@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org,
 kees@kernel.org, acarmina@redhat.com, jpoimboe@kernel.org,
 mark.rutland@arm.com, maciej.wieczor-retman@intel.com, Andy Shevchenko
 <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf()
Message-Id: <20251215202430.c35c2d29c4f9ff614d2ab534@linux-foundation.org>
In-Reply-To: <20251207-warn-printf-gcc-v1-1-b597d612b94b@google.com>
References: <20251207-warn-printf-gcc-v1-1-b597d612b94b@google.com>
X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On Sun, 07 Dec 2025 03:53:18 +0000 Brendan Jackman <jackmanb@google.com> wrote:

> Recent additions to this function cause GCC 14.3.0 to get excited and
> suggest a missing attribute:
> 
> lib/bug.c: In function ‘__warn_printf’:
> lib/bug.c:187:25: error: function ‘__warn_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>   187 |                         vprintk(fmt, *args);
>       |                         ^~~~~~~
> 
> Disable the diagnostic locally, following the pattern used for stuff
> like va_format().
> 

Question please.  Why are we suppressing the warning instead of
addressing it, as Andy attempts to do in
https://lkml.kernel.org/r/20251208141618.2805983-1-andriy.shevchenko@linux.intel.com?

I went off and looked at the commit which did this to va_format() but
it didn't tell me.