From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011062.outbound.protection.outlook.com [40.93.194.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7757C224AED for ; Mon, 15 Dec 2025 21:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.62 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765833116; cv=fail; b=Xp96qyj5cVLb56UdabprQB72QhkUdiZ2PpYDtC7pyrigMk6XnHgnojrMfbBXHA3HwmncCoIKdBef2rcYcYsyF+aA9WtvPQqmVHTbVnKFgL9CpR1wrSDenfyv/O+juiagxUeNYzQq5o8VznCq/ZfGOnQ/Y09I3TRTu2JyrZ37INY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765833116; c=relaxed/simple; bh=pXWM+pJEj0L3ZEE1scDJAFAVwa//yfRgqeqeRQul8Tg=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=HmjTiCtbONTz0AhEQhhkNxkfuzZwQCq7WmtGwCESyj0sc9KJV+h5pP/kw6DgFHEi4v3CoA22eXatGc/cDaNVkyUEMHRAbU9FcPnY7ioMLchnq8bmEiNz3SJtYW71uKcD5v8/MsyMMJbgq8WBlIHHmCwpYB8wmRsa3OxDwftoGL0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=KXWFpqdY; arc=fail smtp.client-ip=40.93.194.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="KXWFpqdY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JHC/asLtornCY+pJTUqkDWbr8wR0uMqnPPk/7daBx7pLvuFHWNEOtWVRY6aS4KPcIx5a1FBBSv3+HJTOjJHzRL9lCI6x+guIyuJThw9j/H94lcv4OF63ZQkHuuaNvyb9ifew7v/+tHTQJmTx9h9V/MkzWrD5doCxw5+TSsO+/lL/CN6B/YVs2zVPifoqHgwdtrCHgq0IuGqoALJgmSdykAZe+UfnMViJAXBCFjDonakoajYWffjPN0yCdF6eCAXIQMBJpEeTHgv2UJD3iqH5EpJL74ybRmzOHsPogC89Uzl+nwMic1x4SwP4V/BzQi5eYlcdshSiD2UuOCqO6MVPgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BnV4jUhEkX6/kycFhpF0wuEUH04TvLedZ9nOiaCqex4=; b=HXThn9E7TJV+YTZWd8AHfRir6tu4RVo2reHYLdrWUo8kIIhYq0BwTgZReaXrQ1gnR4mPmkXHnPp3/TGih3yRjyOjrof1g4WeRnbuoFHV/LeqGuoJ9qwwykJjhQ81Q3nKI/qIcLwYBu/UJUWtaTlE4r+OEimnbFlyxin4Uc8EhXiGW6+Vv6MtkE+CchLFvBqigZsb40CmblSezHeSOw2A7lq8o+qqAKU7V5TG0vUHIt8V1EVPT1HHUKgwUkTebUOlJDjHnP4jp/hol4Q8aeyeM3XncL2MYG49lQrhATmliZavvdIQJyl/iqaB/5V1vMbZNPYq6lw5sUBhvljsGxXDVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BnV4jUhEkX6/kycFhpF0wuEUH04TvLedZ9nOiaCqex4=; b=KXWFpqdYJG8uMQFWATEZO9n3dRshM9FLIJG6psqA3HOoWGrN1/x/RZAqlh+iT19uOYo2PraRjBhap2Mjdm8OcLgVy6R2WFeRXUZNwYtaPBi3/8I88NZudGjkqgzfiuWZNxttStOHNMAVFyECZaiZTX3fiUHqIGfRJh+MWfH2KQg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB6373.namprd12.prod.outlook.com (2603:10b6:8:a4::7) by IA4PR12MB9762.namprd12.prod.outlook.com (2603:10b6:208:5d3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Mon, 15 Dec 2025 21:11:52 +0000 Received: from DM4PR12MB6373.namprd12.prod.outlook.com ([fe80::12f7:eff:380b:589f]) by DM4PR12MB6373.namprd12.prod.outlook.com ([fe80::12f7:eff:380b:589f%6]) with mapi id 15.20.9412.011; Mon, 15 Dec 2025 21:11:52 +0000 Date: Mon, 15 Dec 2025 16:11:43 -0500 From: Yazen Ghannam To: "Mario Limonciello (AMD)" Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Jean Delvare , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] firmware: dmi: Correct an indexing error in dmi.h Message-ID: <20251215211143.GA355290@yaz-khff2.amd.com> References: <20251214185309.152614-1-superm1@kernel.org> <20251214185309.152614-2-superm1@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251214185309.152614-2-superm1@kernel.org> X-ClientProxiedBy: BL1P222CA0014.NAMP222.PROD.OUTLOOK.COM (2603:10b6:208:2c7::19) To DM4PR12MB6373.namprd12.prod.outlook.com (2603:10b6:8:a4::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6373:EE_|IA4PR12MB9762:EE_ X-MS-Office365-Filtering-Correlation-Id: 57929ed7-3620-449e-9d61-08de3c1e9144 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?RnYtjKyPjgCkvMRQ88IDL2lzeIpOui6Q5IX2expC5WzcxYl8cJhn63ZEIk41?= =?us-ascii?Q?nqr8y+re/JFXhgPaSywpXQHIwYVi+6M2C67xaUhp+w6kfz10JyQwyRtTqbs5?= =?us-ascii?Q?Y108aVdFPpyUOU6tQd8JZ18YwmzRdKHjdTGA4/kcZ02hEpyuZWT9djLLWiIt?= =?us-ascii?Q?Rk/yx/z4JDa5oXvZM2dndbQQcuOa3dADdRdi30KfxbgmgCSuCCiadRclW69F?= =?us-ascii?Q?GwXrYrWsQumOkeb238e3ZJ8s0eICAkGssnRwmaIBl9PMp5MsEUwW7einL1ZR?= =?us-ascii?Q?WFHBvuJZwXdQJ1oDHvNidOgD/K6PlrLnaX7QhSAYdM3uXLE9O4FKA4Q4/8cA?= =?us-ascii?Q?gzvlPem6JG8ixoFouefaZ3mTTJuIjlGcCqnAerDiw6bz7ngjlWH+DA8WDL9i?= =?us-ascii?Q?owZwjw/LxQVe6ndDdbqX/rXwhnkhRq/mVpVX9AI5BodG134XwXvlWaThNVfP?= =?us-ascii?Q?/ERl/nSI8DwN706K4r6vuBHRLPcgfbzeJQWw3c0P3z/OvhnnDtIJhtjq2Z9P?= =?us-ascii?Q?mHa//+1DfJMCaB9DSfqnMUBB2GlDQu8NwErFgM55Ox2OhfZmp47Ae3WcrV/Q?= =?us-ascii?Q?zDlA3HQafIMa1Q8dzhk06I5+I6+Rb+Kg8F2ntVzEbaH9ZvV4Q8AtA/nbGO38?= =?us-ascii?Q?C+uaLdTHk+DZBoMAVSNx9C9aKPDSzcWCjwJ8NtJF0gJTcM3Sx217fkiBElFK?= =?us-ascii?Q?BvcSKxqidSvQbsWNtWyeKFWgM82cV6+esbr+2uEgfZkFEqXTPPN+YoyAP8Ja?= =?us-ascii?Q?qkkDSBhYoPYto1C6e7WLEWmLhIfdXhnsrEWUZItSpWFa0jZPSxXBcMl831+C?= =?us-ascii?Q?Qz1bDqNR3zh68TArbNWVSsdWN4pUFaOawlMBZBV73IzO6QJGqFY/bu6SoYI4?= =?us-ascii?Q?OcGeRUhY7V3nxseQAP2hEG4esN+0Gw5xwZgv9+Y/vUDua3O32y/+yuE4kLew?= =?us-ascii?Q?2rH71Pl8+u7g8ftCqxz2xhGwNn7ZkjUMegTSjDHx0p/kCiOD9vH1oaE9gFM0?= =?us-ascii?Q?qUAWmqpqzBwKeG22yJjtohXh3eAHhiWtvoxoc79bgXKgpkLt51599lr3pqK0?= =?us-ascii?Q?oBxIyTunOjA0mk9Q0hKnsUD8hiJ30nR2G8X/07tTOOKwyqQQUMTjiJTPs1YT?= =?us-ascii?Q?5iggqmy4FrG7UdrUtf4OHXBm8imXbMMJthqZANj1UPAPDWxMcvyFjyGZ7uiE?= =?us-ascii?Q?X+w1xcyY87+W8IP7eGPNpeqQrPeZbOHdgRbuCuuB3dRBfa2PxAXAIdIkxu40?= =?us-ascii?Q?agoh05MyWN+2lH3gpBzw/DLkC74b7sBPCqc885Nr32FGvdKcnowwlfa675yo?= =?us-ascii?Q?WBk4fzXInsIbcsWEFm4sbw+aKEQWL+C10ZF1tSclFOvYEzpwdGZ+Ca67DRU/?= =?us-ascii?Q?J/wDxoLdfmsUliN+T/KLh+D0cncDDmJkMFjxvHoJGdA45XBDCkp96yzd0hSX?= =?us-ascii?Q?ZYORRjhyitN6sjyI+DW+Mm8hjyFfCOZyDx4qoOmdAw6XS6zESrIdOg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB6373.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XQxFY0+N0VT+u2xGCRV3AgyqoAzgw1Nhz4Z+JK+Dv4mmpTDLhywq5iYnXRL3?= =?us-ascii?Q?qwIT5V+AzLyC1T3/wKHP6CArj+H2pGV6iw74wcNNHPm4eGAmUvD0dO8CWLT9?= =?us-ascii?Q?dA6O1vfXpcSv07HYFkuG2nOQ7kHQ74vhkjqaZGRQJ5OtnkJuxP17MehtsSh5?= =?us-ascii?Q?Z1qYpmF8kV0rfd2u2vSX84T8mI9E83opzsy6SBHtJmpCisySy/e4rPLO726v?= =?us-ascii?Q?AcGb5JkCT0nvBSvaHloeKEJIResP+rMFFMHFFiNi9/cn5RnhX4pJXlDPrTmx?= =?us-ascii?Q?MO0ImpML5fpBkRAKRv/rnPqMf7W64ixlt1Ac7pSgTIp37YMK5BONMbCV04fq?= =?us-ascii?Q?PM8/wjZ3C/dSR0QmTIntCZkuFwjyPeglCH0FnTNmXyz0dleFn21DfzXFBpm0?= =?us-ascii?Q?P1jjEaQe11Mc8X5QCiz3IAKeSErC+InJAL9kJijg0QqkVv4fOFhv9N+hLqgX?= =?us-ascii?Q?WRcA7zz/1vVoug3SBQrAHXqQ+tJNnJF58K/L3RhxmQarVOHtV9D6DBXJROkU?= =?us-ascii?Q?wRfdanrpbH1pnS0GAKSZufNoQNkefBm4a5rZIXjNLhQdHqj+LhS/H1ynrufW?= =?us-ascii?Q?frWDqwyCiuFeND0QWOgdk/njR28CP4+lp8MJjGb5S1oa78QspbZohjJwS5cM?= =?us-ascii?Q?HqlWWiAj/MY6zOx+3e2dTT2mo64v9mCl7BeTramxZzy9xlOg4f0zDZVHwHz+?= =?us-ascii?Q?lrme5Hz9wkDzr/Wv0HcbNPL/X6L+I7K5674+PHFoxvj0kMEGN9FzAIB1XSP1?= =?us-ascii?Q?kmDCuEQtviCUdycCdKat/434v8hIKCK1RiQq+5fy8gV1gecHY2xYAdEpfWtt?= =?us-ascii?Q?Hi4KDqEN8a6B/VJGuPBsBOM3XjMtkArUZgCHccH2GAAlbambhYArH93EQpe5?= =?us-ascii?Q?er1G+8Vo72FhfLcW4VBi5jV+QKfsu3Qy+nLWQko9TlrzY5oEm6Zes1T1T9HK?= =?us-ascii?Q?NZXJuY7kUjlWPjRgddmB6BpjBq3FJXnNk6tR3aySVx4s5JugfWq3302TCY7s?= =?us-ascii?Q?58TzysoYU/rirHVd7ORyJO6Himhrub7r0Ts49WFbnGRpzQCO/MHWFiwVDeJh?= =?us-ascii?Q?FoBcAKg4W73FSqQml8/mcm11z0TO/vkxg/dZRrp/Ro2Da1YXfldFpMaAQpgm?= =?us-ascii?Q?3QJbvf+2ueHpfpRriz923qslCZvNGsEH0r9TGBDp/UDuEi2JPoqETeTpTE9I?= =?us-ascii?Q?iRqv0CQKSYT+wpdQZN/67DLvqJiXde1Adr4gySpO7SSjNv2AlCS3pWaYfwop?= =?us-ascii?Q?pmnQAhx6iC0g0R3yqquK5NZ790A69iZvPkSVEKxzirMCd2bmKlJyh0JUrDYK?= =?us-ascii?Q?Rrqx4WwLTI/U3ooDSaRYGxSvoAz9PK2HELUkfR8H6JtCzzhCxhBlDZokxmvy?= =?us-ascii?Q?OkFwqS+UkT6UD78CfthbhCjz6zvQUzoP4T4hSV0yk858Z7uA/9+T+6weJeE6?= =?us-ascii?Q?P9aS5GVOKZ6VvqEwqDYrLNkuk5LAnKUuHGjigFXjOZ3671IkQOsd6qtoK1qV?= =?us-ascii?Q?yIfir1Xg4SPJFCO1wG+0kaumbENFrbO4a46cSYCS7h6YRBuL074SHAD3Bd9I?= =?us-ascii?Q?8dAxYJzA68KLB7YWJrnulHV/3amLhFDDLQ8h9gnz?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57929ed7-3620-449e-9d61-08de3c1e9144 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2025 21:11:51.8911 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YjS7M4TpCgkQkF4WgyzNYP+y5vG3vSTaD1Cmeq5nT/qEuEJFouVgkUcqz+Npp+KNsiDa38GZ6zMCj7ZIfWpqzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4PR12MB9762 On Sun, Dec 14, 2025 at 12:53:05PM -0600, Mario Limonciello (AMD) wrote: > The entries later in `enum dmi_entry_type` don't match the SMBIOS > specification. The entry for type 33: `64-Bit Memory Error Information` > is not present and thus the index for all later entries is incorrect. > > Add the missing type 33 entry. Types 43, 44, 45, and 46 are missing also. Should those be added as well? Probably not needed right now, but would be good to add them in a future patch. I think there's precedent for keeping definitions up to date with the spec even if they're not immediately used. ACPI does this, I think. > > Fixes: 93c890dbe5287 ("firmware: Add DMI entry types to the headers") > Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0a.pdf > Signed-off-by: Mario Limonciello (AMD) Reviewed-by: Yazen Ghannam Thanks, Yazen