From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010045.outbound.protection.outlook.com [52.101.201.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79FAE324B30 for ; Mon, 15 Dec 2025 21:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.45 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765833831; cv=fail; b=tbTBsMCEesYrNlyUIayB1Yflb5I8xBuX08Jwq74QHYKgew4ybSWsaRqgMwDVeT5DZbJvizJYuWkfoQ3oDhD4jwn2HfTGHdhJU21/R+YIBmC5xS3NK0rVV14AIN1FWBHuuUcCct7/Rsj2l729Og5GAmRyBrJqIqJX5P03lCim0wY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765833831; c=relaxed/simple; bh=U1oQ5gMCHBO1oWHMPIonl+iEFo8HYG3H5Kl5Z843H9o=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=NVEtv7fchgYe7HDLwlOF5qXh3vJfCKW0T+E1BMUvJ2FBzw3PIDm2xPxwhFuyQWA4nEZRlMc7vbDP2TCjPtA5/lGbRGEGMS985T/xuFXnBDxFHS7bat4/pp1kdVjHbwp2htfZRNc4D6bvfCEFWZvy1zVFuwWJfPnIem2JzZ6+bgQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=hrVh7Ck+; arc=fail smtp.client-ip=52.101.201.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="hrVh7Ck+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jEDhU+1VTXFsi38g8Vk8tTx+ux1SG8kJ/WaeOMkCTSjuE+knAj3flsKRXSKJPDHXmGxsbsxTp/2Df1BnIGWbVnF10SEG1nzPihgk+fv/G+8KS8Tumt5NHTDG86VAGe6ooyDvXnKWSqmIKDEhXd/Db4+cjz+axS1sjFymAKxVwKDatmNiq+nEE0HYXsMXeuPb+q1cXWgPnm/POnf32wef9ocg+XlSL5J7sN99ubrb7SHHIuGcQX9K/tBK2GAzpHXWcbylM9btOwkgB5VlLpk+Z8Xekku4JRZ2465TeArWnex5XDKhH4v8mtdskrqauNIKWc4SrqVqqW4wp6tSvUnEnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F0O/YjXYEjrNDsZQ3IhPdzsDullM0weQ5ckpJruv104=; b=Ir485kF0k5cbjTdbMmxhJnVZ8Ea0v4SLMrT5jSqMThZY6KcajUwwKuY90+ogJ2pLU1u0gWmUCQkzrBVxOdKh5MTTa+nfsMqq9baRYNwP/y1qsefsju7nP+qVnxj5H246UuNlkamEy41xUBAX2I23TO/709djoGZ4VuvHDYSbJKuNyS0ajuRVxcCE2YXj+7lOGSFEUw63IxGhTUpXI6FCnda5z7dCbei9rAlCrnPSpXDgINojhrLJIXa45+LD7txRan3rzFbQ6PRVV4pjkwod0g9HTvWE1AN/CscEziCZ6Tq+N7vcN6GsybXOa825khncbYbrkavbXBkPF8d4e4yp0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F0O/YjXYEjrNDsZQ3IhPdzsDullM0weQ5ckpJruv104=; b=hrVh7Ck+LpHllYLVMvGS/P6krATSm+qJuF/qFNZfIIF5nncP7srEv/eiRghXF7O6w+o3koLh0kDT/Ez65RLsDeJUR4cD2kWunqUU+TyqwZl+qS89xLnaWSZ3HxaH551bZl1krTq6S6JO1eLDIQ5lxoT/IUYDJ9mEA5ISaDHyjEs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB6373.namprd12.prod.outlook.com (2603:10b6:8:a4::7) by IA1PR12MB6089.namprd12.prod.outlook.com (2603:10b6:208:3ef::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Mon, 15 Dec 2025 21:23:47 +0000 Received: from DM4PR12MB6373.namprd12.prod.outlook.com ([fe80::12f7:eff:380b:589f]) by DM4PR12MB6373.namprd12.prod.outlook.com ([fe80::12f7:eff:380b:589f%6]) with mapi id 15.20.9412.011; Mon, 15 Dec 2025 21:23:46 +0000 Date: Mon, 15 Dec 2025 16:23:38 -0500 From: Yazen Ghannam To: "Mario Limonciello (AMD)" Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Jean Delvare , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] x86/amd_node: Output the AGESA version to the logs Message-ID: <20251215212338.GC355290@yaz-khff2.amd.com> References: <20251214185309.152614-1-superm1@kernel.org> <20251214185309.152614-6-superm1@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251214185309.152614-6-superm1@kernel.org> X-ClientProxiedBy: BN9PR03CA0223.namprd03.prod.outlook.com (2603:10b6:408:f8::18) To DM4PR12MB6373.namprd12.prod.outlook.com (2603:10b6:8:a4::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6373:EE_|IA1PR12MB6089:EE_ X-MS-Office365-Filtering-Correlation-Id: ab1bdb5c-3f69-4e56-326a-08de3c203b40 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?tlIpFb5/PZYp9WX5LO2HdJhSaLNJAN2QM93NBQKLRQ8D02Uz4eKGlsV9TvtO?= =?us-ascii?Q?xdQSB0LMJjtPPwR0J6o7HjDVqNniF+XCcPQPz4gcwaX3jrw4a+VLtM4n+xOd?= =?us-ascii?Q?nvEBYcb33fXaye2hlIHeUfgBRjHtH5Zzom2W1hn3w/ohbq49r9KSFHroKXWI?= =?us-ascii?Q?oLUq6tUpn1yw6u8f847AXOvyFgTAgGjxSZL6MihsdBc4K87Cr+9q8jhgm542?= =?us-ascii?Q?ULsN03Fu5foANA1ZmCC01gNYwMR5BBzwpqht2o0f8YVOcGAwY93YlvwLaQT3?= =?us-ascii?Q?SPjvxiLa7aPXJoV6Q4KkCefE5OFh/yhW+2AqdLmg3N4M7looHXb2vujyc7ac?= =?us-ascii?Q?muF9aRIKVPFWFBJpDnXXld8dzByBZMn7Qur3IGPOvc07SBuiteYlETTRRwkX?= =?us-ascii?Q?rrNAFOm778kVV1MnVuuc+0rNx2dUEjNdfVGsshE2gxrl6It3YB2QcBreAT01?= =?us-ascii?Q?vkpFZlVZ64M4ovMmkkmrJQPghSb777P/JMYovP3FJqLw6pfIb43NiFKiza1B?= =?us-ascii?Q?LsBu84nhzZOCauSpJUQRQfvtWUdiXwxupyIcKjhyfnphlrLPC2R2lbW7wmCR?= =?us-ascii?Q?0lH7cFWGXx7SGg840W4PF/Kt6KGZVEMiK7Sm8dIye1OZ6QHraN7DtfS5ceRV?= =?us-ascii?Q?yJloANCgaHQgk1kirNZaTjstrNMJsGzQg0eWFCYXftzQl8ZSsB1xRoRHN81N?= =?us-ascii?Q?lBtlObJZCA2v5lh09PINdpM9xvOsmDlcFdWa8m1n23EvmKQSSxXn+jRTAMZL?= =?us-ascii?Q?O9P78rcqX+9YCTYhzYDY3cB9zZP8g4eflgO2wixXcnzm2McpMnd4fXXF02OO?= =?us-ascii?Q?f2iQZZjMkjcHBgAc3Zyy8OUlcCdlerS9cKZD6M2BFpGnv9agu33Q1Y//wi9x?= =?us-ascii?Q?bAGsk41JQk4aJVRBdrZcyz/4pB3wozOToGUhpyXhuv5JryHYep1PFO5osEiW?= =?us-ascii?Q?3mfTIM7n4uatYrrCyojuTbbQNsSMDN7P6nphrc5NPWGwYyRbUNrf+Y7brftK?= =?us-ascii?Q?jRd0EyZCwt0J03ZNCgyg+MxzFCJUWNVGYNGI7gqSxyZXXro3FvWri+udlg1/?= =?us-ascii?Q?bg05t6JLSlKHtNRgDEIQnaNj6d2QehlxeDCQAdhgVFQoSMNPA5G4mwjwnVIF?= =?us-ascii?Q?e7wtM9sOv/AeysxpZ8hD3uoRUOeXvXFHroj3mah52fDM83nXTJZLcMRRfj22?= =?us-ascii?Q?IL6lfhVLqj4la98GjxoaW0NzmPv6/Fz2S67JTZbSDW/fuY2GM0toeW4MgkXl?= =?us-ascii?Q?wECmwH1NzlOo9wJYIigx/zbIx1g85mFT3d+p58ol5g7CWbbn0WE1v8XBc79F?= =?us-ascii?Q?GlXChdJ2VdgJtjfMi+eMwlXn5sSoMLxMB6jlHZBE0qSzLmadwi0DiI3kfXSd?= =?us-ascii?Q?3gS9dm1jo1DPcWZjeWALS9HCxSCuhMzC65VlOD+nUDx5EERgpNcVB+7pl7zc?= =?us-ascii?Q?HakCoKxt3c59zolUQcG/1SI7rdVKb++o?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB6373.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4ViPyhLq99JV5xpv4nseFIuxmvcTC4iZ47g1ON+jp96RPaCFtKuMXbNMsaoF?= =?us-ascii?Q?IK13KRPVYxoKEVnvSX8vE9cRUWsg7jJbSIviLnHmGKQNlfo2Vu9lP5DmhN8X?= =?us-ascii?Q?zrgGvaDg7Tx6EOkA2yY3k9Pll1lFb4ZeQbCmU+LFJmhOXyoqTDCPAPh/cpS5?= =?us-ascii?Q?GBX6bKBHdZQmXXYT7wMXOUQZfz3xbGQTETobxa2ltpnDe3dMy4ybBgRPQ8fs?= =?us-ascii?Q?KhYuPuOBz2aJi0V8pzgbZguX9M5n4bSDQQ+UEzWEaRHIZeIdgWN31VLgLF+j?= =?us-ascii?Q?/1/ptN+C8x8/Dc8jduW6AOm6T6/ivQsK5TEP1+rtpwTUmkxyIUH5YvkQ+qHa?= =?us-ascii?Q?w0hPeDk6torTekHvaHZca4hhCKL31hrdRjnPnRFIcjNz76nCypGB1+qq3p5P?= =?us-ascii?Q?1gdBq8IEpi5iemlqNS6VjiuGYOTspypYwdBW1kvNWiVkBteh5cmUVAQd+OVt?= =?us-ascii?Q?leA4qVm9/EEavoJth7POCoDpA9DZoG9+G/yYmSVIpEaGkD0winqVOLtFXXw4?= =?us-ascii?Q?B5rltza0guExKO2Um2QSZL4BjsmOuNlZyBh2D1i9hHIA5h6vfshijGNobGbS?= =?us-ascii?Q?+9M/7MLpW0Y52h2/PgX6SccUVpK7hF5BlFlKRVla529lFXqP8sHNOzmCiNuo?= =?us-ascii?Q?yfXih9pM8FcEzpYywHU5uUjrWf3jnkAnhHldPQTQFFkl6CgNsi9QfW3Rke4j?= =?us-ascii?Q?cZvkZLUeLDDC6LQEqQoFXZFAa2X47xWnqxC4NLp30uLdxATOzq0nVrg8GE6N?= =?us-ascii?Q?SaovqYf2CxSb9kNgxbUhjWUFXC2ew7Xs0YC6MZixxCqoOR9AaGFBmXFkzyAi?= =?us-ascii?Q?T1/bJ5CJouT5timfri1qFAw8Pq3MIaR2DjYhzj32qhipzTUccZolqThycMTo?= =?us-ascii?Q?L4drvGrbMSazm5mu8EjVhGbjhHuZHZh03Ubh+qoEEiq74Mx5P8H7W7z0t4nB?= =?us-ascii?Q?VoURsscPmjadWEdhAnZpexLde4okY7PabYUWzP2UqfM9a2C+4p/mtavsTSSA?= =?us-ascii?Q?FftL8kO/vGzPaBzbggKLoco4nMdyoSwJ8mhEsVH3AMb6QpspMj16t8K8iqI7?= =?us-ascii?Q?XB7x50GCz1UDOTVpiI40ZLLlBhtE5woONmGlz3BjwhsMx16DXD3n7IZz87/j?= =?us-ascii?Q?fQJvU/hutvf17YjE8xfNMrEpwrsA+h60lyMlTDSq1pBnJMJGkMdZYqmJxIzk?= =?us-ascii?Q?+Ju5MdYKTq2p4m9aOSWRew0PYXxKyGnijmq6p/Q/S+gPQncnumOpkJZIryOi?= =?us-ascii?Q?Im7vr0rt6+a4ut354l8Fg0c8z21PwBM//9azk6dt2+FayUxcZXZTCGmCjJYf?= =?us-ascii?Q?wnaCE5mzbLp2UxIW68r5q5tnZY2ejcyd9sFIxcX9QRqbp6zOqpPKbX7dhbQD?= =?us-ascii?Q?WTLQs1doypTXk0Zbh1wRnACDci0hBEVCZXMCZezTcsTJOCqJL7MOVRdwADe7?= =?us-ascii?Q?dFN1YbGsuVUcvucw4KF/++oBKV2wRp4K0o1yr/f6k/sO82WnyUtN1dvUC0t5?= =?us-ascii?Q?GEX6fJSDu0b70KKNqrxlNWNYzpSr0hCKoXKf9juHMKAhYQIIrLhcOTTIfGij?= =?us-ascii?Q?t215UCq1b5Zjx3mWBGsa/25Q4VqKCoV6wIEayb32?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab1bdb5c-3f69-4e56-326a-08de3c203b40 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2025 21:23:46.7374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +CoKvJkAqV7bcI8XNh+nBIjDXKmdykubzpX9BEdx58/PerGrjNAR64EjEh772qZ7uhIZyH0XxTSYVi06lD8oYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6089 On Sun, Dec 14, 2025 at 12:53:09PM -0600, Mario Limonciello (AMD) wrote: > On AMD Zen platforms that are running AGESA, there is sometimes > DMI additional string for the AGESA version that can be helpful when > debugging an issue. If this string is found output to kernel logs. > > Signed-off-by: Mario Limonciello (AMD) > --- > This is not strictly AMD node related; it was a proxy for a good location > for the message late enough on boot and only run on AMD Zen machines. > I'm open to other suggestions. Maybe do like print_s5_reset_status_mmio() with a late_initcall()? We could have an amd_zen_late_initcall() function in arch/x86/kernel/cpu/amd.c that collects appropriate functions. We have two now: - print_s5_reset_status_mmio() - print_agesa_dmi_info() Thanks, Yazen > arch/x86/Kconfig | 1 + > arch/x86/kernel/amd_node.c | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 80527299f859a..eae139a91fb84 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -3116,6 +3116,7 @@ config AMD_NB > config AMD_NODE > def_bool y > depends on CPU_SUP_AMD && PCI > + select DMI > > endmenu > > diff --git a/arch/x86/kernel/amd_node.c b/arch/x86/kernel/amd_node.c > index 3d0a4768d603c..575d727c5827e 100644 > --- a/arch/x86/kernel/amd_node.c > +++ b/arch/x86/kernel/amd_node.c > @@ -9,6 +9,7 @@ > */ > > #include > +#include > #include > > /* > @@ -247,6 +248,7 @@ __setup("amd_smn_debugfs_enable", amd_smn_enable_dfs); > static int __init amd_smn_init(void) > { > u16 count, num_roots, roots_per_node, node, num_nodes; > + const struct dmi_device *dev = NULL; > struct pci_dev *root; > > if (!cpu_feature_enabled(X86_FEATURE_ZEN)) > @@ -310,6 +312,12 @@ static int __init amd_smn_init(void) > > smn_exclusive = true; > > + while ((dev = dmi_find_device(DMI_DEV_TYPE_ADDITIONAL, NULL, dev))) > + if (!strncmp(dev->name, "AGESA", 5)) { > + pr_info("%s\n", dev->name); > + break; > + } > + > return 0; > } > > -- > 2.43.0 >