Re: [PATCH v2 1/3] fs/resctrl: Add helpers to check io_alloc support and enabled state

Aaron Tomlin
2025-12-18T23:22:57Z

[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]

On Tue, Dec 16, 2025 at 09:01:32PM -0800, Reinette Chatre wrote:
> How does this patch benefit the goal of this submission, which is to set
> identical CBM on all domains?
>
> If this change benefited this submission I should find these new helpers
> used in later patches but they are not. This seems to be an unrelated and
> unnecessary change mixed with this submission. It does not fix a bug nor
> does it support this submission and thus just adds noise when considering
> the new feature for inclusion. This patch can be dropped.

Hi Reinette,

Thank you for your feedback regarding the relevance of this patch to the
overall objective.

To be clear, this change was included as part of the broader series. Whilst
I grant that this patch is not a strong requirement, I deem it a useful
prerequisite clean-up. In my view, streamlining the existing infrastructure
before layering on new features is a sound practice that prevents the
accumulation of technical debt.

Given that this refactoring provides a cleaner foundation, I would propose
that it remain in the series rather than being excluded. I believe the
long-term benefit to the maintainability of the resctrl code outweighs the
concern of it being "noise" in the context of this specific feature.

Kind regards,
--
Aaron Tomlin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]