From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67DDA2147FB for ; Tue, 16 Dec 2025 00:57:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765846630; cv=none; b=Txmh/KInSLnqJ25xl6ZaS9zrQuHcncvRj8ZgUXjIvP4xfUrSGk/voV2wxeutKIepfISXauY9q2SwvWLznZTWc6IpoRvVcpfFpjqYfQ00RUDCN4KFEXR1tSDrI8PPSCFQbZLx7iPgnwU8gTdMaTWjbuAkhIteoEtgqI9trL09l4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765846630; c=relaxed/simple; bh=QezPYSYTY8jyA8T5MiPTniswqhsfgFbCDuDyZ1kn3s4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hW172SKeqrYxWWT/6MVg7h52E5jS1cMpxG/qL7oKbphyuwN1R2gQQUinXFZT4DlKpDZnpSklF0P9wsQPag2rDmdKQX5IUsWWztthYFyyzN6DuZJK2NlNKRxE9HiNa9X75/bn+gFz5+uekAzeLq9yh817zpqJU6MZavWcnorX4MY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=CG+ZPN/2; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="CG+ZPN/2" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-8b2ea5a44a9so430181385a.0 for ; Mon, 15 Dec 2025 16:57:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1765846626; x=1766451426; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IPpXEBgVWwdvOViYbZAfQ/0F+69tA1X6CeobJwJ6WR0=; b=CG+ZPN/2t2pJNeNDIIurpWpFOgs1v//P3tVTr156tjbQLlPupLFEVg3JPN/i3ilOu4 5zYgUImy9YnAOSp+t1MFFMWIBR3MlZqzSw0BbRx0biQoaLHmsKJNtcXgV78oYqD+o3+G sWiLi8MdETK796lIStu2YcoYHqE9r6nTTXBj5+b1V7lPb2i3UyWsdhv//UeMYknbwKKK QfZUNr8J0IkDAVJMWyXqdFQJBmfQNdoaRdzMBBHzmDd65o2XX4reNlLjoSg6xwpEFJtQ l7fso7aL3MnR6VwLRu95i4ui5OdSgjMxh/dBbbFGrls5BMVQ2wzG4GJwEzH1wLExcgwR zZkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765846626; x=1766451426; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IPpXEBgVWwdvOViYbZAfQ/0F+69tA1X6CeobJwJ6WR0=; b=UNfDbLFrsdAlL69zy0gco5PaUwloFRteCzxIBF/A3BRUIKddk3TY8Kt8asPzqi9HqO uxgqkzv5hVxOGA8L8c9wkVPh7cPGdw3nr2xovvpEZoBeqVQV53Nogi5TpGiL+V+HjiDw 3Irxes9bfbbT5+0QhuDTG4I+webvwxHG/SHD6lgoZBjNgxKM4Q1229W/TShw+nnnXDYI a6j9UbSAtOUNps8ElmhFSRHFx1QUgWLcsbZlfzpyKxvcPCLX1wTi4WBLXdITJEx9NTF4 vmlHuqrFcAjfc1AgPd/6aZojIQTk08joKkjXxqT7eBz6/EL4RZFXR4rsjc61dQ8HYaIc 2B5g== X-Forwarded-Encrypted: i=1; AJvYcCXLwiDbV/ThTaK4Vyysp9tpUGfziq5ZMc0hkPvikm6uSX5cOG46JAEDpPB5MSq01QDveuUqqg4mbIEuaFI=@vger.kernel.org X-Gm-Message-State: AOJu0YwVnhCmsFl6G/CHfQXMgjDBcTnzjUs6jiZLPj5pdWdMW8zdNqeq qFRhccI/pgf1VpWq/NgJFB/j/zBZWSJaw4kWvfkdKwVztjOdZq0fQmIAQxsPNYws8bYR1tqQJsG oTWN6 X-Gm-Gg: AY/fxX4isEduRJXWfdY1AR1qX/2BzYD5gz326eDAOlTvn5RcL4jncPQHEAFlIZk6Hqi L9RjOZQBuU/elk8H+bfxUfyQgfj0uiO1wdWmdfSgq8M2Zaqa8noB6aLPp3tJWx+hnISCSHR+YiY rCbcEl2G34Gp+BauNkCSYhzuwyqSz+lILcwdBEWfgifJrWXgYTXiNs7JOPc3Am4uZeG9gaFvGk2 rIrzc9t1RbtGtHJlQXDyQf4zZkI8ZphLAZyL/ibRtYDFyuWqVyEdZRNSe+vp1lxyIiJ8s/EFNYe 5k703LMf8KgNVlFqB85y9/11t8190Gm0B/BrGdMRUqwjj7jf6qbd7FdPMl/rNxosDBKYSX+7euS xT6LxEHWSiN3kQ4jV9YSCSdF2zz+8bdMJGN4FLRpnGeF0UZwbzb1Rn6/lgjbbbDxMf4AX/gm1o8 Ttu6nH+fpH1QuKSebxlj1MD2FK/J3p+Kqd0hu7+wr+E6FVNgVgU4HL8J2bv6QKVT228K4= X-Google-Smtp-Source: AGHT+IFNRf5SYkdPtX8YbOp8FcLkqV1bOWRJhWcEbpFL7AiAOiWiOC2cyMdz9cLiPNPjgwCt2PsvcQ== X-Received: by 2002:a05:620a:44d5:b0:8aa:f08:bed0 with SMTP id af79cd13be357-8bb3a39df6fmr1819982185a.79.1765846626202; Mon, 15 Dec 2025 16:57:06 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88993b59838sm63654226d6.13.2025.12.15.16.57.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 16:57:05 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vVJNB-000000008Lt-0Rrp; Mon, 15 Dec 2025 20:57:05 -0400 Date: Mon, 15 Dec 2025 20:57:05 -0400 From: Jason Gunthorpe To: wujing Cc: Leon Romanovsky , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Qiliang Yuan Subject: Re: [PATCH] IB/core: Fix ABBA deadlock in rdma_dev_exit_net Message-ID: <20251216005705.GB31492@ziepe.ca> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 11, 2025 at 04:08:13PM +0800, wujing wrote: > Classic ABBA deadlock due to inconsistent lock ordering between > rdma_dev_exit_net() and rdma_dev_init_net(): > > Thread A (cleanup_net workqueue -> kworker/u256:1): > rdma_dev_exit_net(): > down_write(&rdma_nets_rwsem) <- held at line rdma_dev_exit_net+0x60 > down_read(&devices_rwsem) <- waiting (shown in rwsem_down_write_slowpath) This isn't right, it unlocked the &rdma_nets_rwsem: down_write(&rdma_nets_rwsem); /* * Prevent the ID from being re-used and hide the id from xa_for_each. */ ret = xa_err(xa_store(&rdma_nets, rnet->id, NULL, GFP_KERNEL)); WARN_ON(ret); up_write(&rdma_nets_rwsem); <------ down_read(&devices_rwsem); It is not nested and there is not a dependency. > Thread B (stress-ng-clone processes): > rdma_dev_init_net(): > down_read(&devices_rwsem) <- held at line rdma_dev_init_net+0x120 > down_read(&rdma_nets_rwsem) <- waiting (blocked by pending writer from Thread A) This one is nested though. I don't know what your bug is, but it is not some trivial ABBA deadlock, lockdep would have found something like that ages ago. Jason