From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4676735FF5E for ; Tue, 16 Dec 2025 13:27:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765891676; cv=none; b=g4NRUDeDElcFifjRtyyWBb2evLKo/XRxJivVnLsSQivqxy9QCk0KjsAY/GiYcg8fV8iX8I8ESN6BWF9y37mgG7HEn5fQnXkXPWRsGwoUWSsjUGbpgdeYc4iVSWQutRE8xAD+1rwCjt8gHJSLvq0BO2etuS3GKSEaRPmt/Jz6o34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765891676; c=relaxed/simple; bh=M0bxbfD0As+YmNac9CIegaV8dvu/bSOewPFUnSggMLE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=DIEsh/YhPI9tY24bJ7X0lnyu67C2pHafMGCagKm4q+PBQY3bQDvRdX9nooSFY8FjixXLgp+R0kmcacTvCzYFQ0MEXtgXW48fXOHs6KC/QtnoTufc16XZPOOk5bpvo1EPFCWwg0Q122CjLXSFf3HtkV2lN6ybUQRqoWC8LeXdryE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PZwOhw1Z; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PZwOhw1Z" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-42fb5810d39so2141968f8f.2 for ; Tue, 16 Dec 2025 05:27:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765891671; x=1766496471; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=6y36B4YguvPAVAnYYeQeC5X+WoPU9GzZLwjJ+mAyZZY=; b=PZwOhw1Zzw81c1JMcfbP//OBaAqVYwFxB1wodxxLMkyDWq0GgdaZKtMJRPotNAYFeU QjHCJDl56mRYrQak/6DAdmJ+19Zl6cZgTwZI2zAEdCoBwsf0Vs8smx2HbuZYB5AZ2kAJ 2rI+/TxZeeNc9qhujDXMVX5sriFsc/pTpzr8Flryt2rhBfCxDaSjLe8dS2MTIOAD9bqo gZWV4ETuY7yfxSoxgEIjECUgvyQsVtuIPqtpfcrDsOEVoM0bc/xYAUSQHqheSXekaBAg rfGygK5ubbFiZ/DFrTdSc7YuZo7D494mC8UmemjH/WtBfmX7afjtcV7DxYTdPBYUmDze M/kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765891671; x=1766496471; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6y36B4YguvPAVAnYYeQeC5X+WoPU9GzZLwjJ+mAyZZY=; b=ojIAq6QGu3IuNsWwRUc/sqgBbE1QgsjR632/Ah2JT3q8hQCtBL6IEqKWVnDOskL67G coNxkws3TcPMq+/iF1g7KjiJkrZjHUnLp/FSNOU+rrLuCqmw85HmiKYgQ0Dey6mda8xV mU5sTuAd7VRZOrpSq+RjkWM05azoL5eCaToKTZna5qCdSbSvpc6G8lK3Y887ZozZ/GkQ ze0Mw38wOnTz3xen/9+OjGAMqR7vdR99pymQZOpeEq6BDjJrUWI/Az0mC0+tZ1bQTR36 3A79ZQ/J2p2nlBaGlGH/cT0URceZ0KgRxX/1D2YdTXnjBM7kC0s5sv3BYwCYea54aK2j P/8g== X-Forwarded-Encrypted: i=1; AJvYcCWwfNK9JYUrd1rLk9cD9Y3pNj1ZvbdxMB0AuuBGu+fNpArcISAn25VWqW1uwFarxO07uln3+CEYC9krN5o=@vger.kernel.org X-Gm-Message-State: AOJu0YySXDB1MesAxRyBEECQwOGJStUpMH69eIvYzOlIeWrXB1T0H6dK 9s1TKhaWgfGMLYI6qzCedXXAnamRR8SA2TqQWVaBPzmzVERpvgvNQMzGKZsikTm8VUg= X-Gm-Gg: AY/fxX5Z4nvA1Ooqjo7LEm2fPiKUEtUPNaT/Ti8RN3zY8fFuH11WiHHPsHfd4Bw/9vh LgOam9eCKFdNdzF9v1uZVqoZMd6RVXvj8zj9rKyQm8MDmPi/UJ0+QoUflAoqmgYYqMaT7COsZvx IZ97Yg5J1hzkGdiYYQsowWJ8fM2ENBbKsW3PjAWShhD5Deuopd31aWCxJ1PkLYiQtwfMEiTzQ7z l+2GDCl/d72FwFhl33odliDylm9/WgZ8cBlS2NSMQY+r4LxHMtd3JSTCPOJ0yq8Sof/zjou7WbG 4vkLr6OZbaK+OxSTV/iQFLAHnuFHQ5k7Qsy03h1oIr29X4enhGqbkUB+R6hjHyQoAU4wXfxGsYL vE6NBJBmsyfmfGwYp9cggUG7L97o0Xa4CJoKvUTTCugQDHcAB/vu0jZrY0/2XPUP9WhTfX+/tzW n8Q/zfaGI9/7kGXSYT X-Google-Smtp-Source: AGHT+IHl8ZNaJnmMRRn5pzpbDfTgSbSMIsp6fByudl0y25hQmBiOomGR1Gi5zOJEkB6jfAdInAaBeg== X-Received: by 2002:a05:6000:40df:b0:430:f6c0:6c47 with SMTP id ffacd0b85a97d-430f6c06d99mr8396227f8f.21.1765891670633; Tue, 16 Dec 2025 05:27:50 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-430f36b6a19sm21012482f8f.38.2025.12.16.05.27.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 05:27:50 -0800 (PST) Date: Tue, 16 Dec 2025 16:27:46 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Divya Koppera Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Jakub Kicinski Subject: drivers/net/phy/microchip_t1.c:1299 lan887x_phy_init() warn: 'priv->clock' can also be NULL Message-ID: <202512160211.FZ4wuVcH-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 commit: 8541fc12edcdef36a02885672f22ca8391bd2443 net: phy: microchip_t1: Enable pin out specific to lan887x phy for PEROUT signal config: sparc-randconfig-r072-20251213 (https://download.01.org/0day-ci/archive/20251216/202512160211.FZ4wuVcH-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 15.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202512160211.FZ4wuVcH-lkp@intel.com/ smatch warnings: drivers/net/phy/microchip_t1.c:1299 lan887x_phy_init() warn: 'priv->clock' can also be NULL vim +1299 drivers/net/phy/microchip_t1.c 0941c832823498 Divya Koppera 2024-08-21 1280 static int lan887x_phy_init(struct phy_device *phydev) 0941c832823498 Divya Koppera 2024-08-21 1281 { 9fc3d6fe802923 Divya Koppera 2024-12-19 1282 struct lan887x_priv *priv = phydev->priv; 0941c832823498 Divya Koppera 2024-08-21 1283 int ret; 0941c832823498 Divya Koppera 2024-08-21 1284 9fc3d6fe802923 Divya Koppera 2024-12-19 1285 if (!priv->init_done && phy_interrupt_is_valid(phydev)) { 9fc3d6fe802923 Divya Koppera 2024-12-19 1286 priv->clock = mchp_rds_ptp_probe(phydev, MDIO_MMD_VEND1, 9fc3d6fe802923 Divya Koppera 2024-12-19 1287 MCHP_RDS_PTP_LTC_BASE_ADDR, 9fc3d6fe802923 Divya Koppera 2024-12-19 1288 MCHP_RDS_PTP_PORT_BASE_ADDR); 9fc3d6fe802923 Divya Koppera 2024-12-19 1289 if (IS_ERR(priv->clock)) 9fc3d6fe802923 Divya Koppera 2024-12-19 1290 return PTR_ERR(priv->clock); The KConfig does this: select MICROCHIP_PHY_RDS_PTP if NETWORK_PHY_TIMESTAMPING Since this config doesn't have NETWORK_PHY_TIMESTAMPING then priv->clock is NULL 9fc3d6fe802923 Divya Koppera 2024-12-19 1291 8541fc12edcdef Divya Koppera 2025-01-15 1292 /* Enable pin mux for EVT */ 8541fc12edcdef Divya Koppera 2025-01-15 1293 phy_modify_mmd(phydev, MDIO_MMD_VEND1, 8541fc12edcdef Divya Koppera 2025-01-15 1294 LAN887X_MX_CHIP_TOP_REG_CONTROL1, 8541fc12edcdef Divya Koppera 2025-01-15 1295 LAN887X_MX_CHIP_TOP_REG_CONTROL1_EVT_EN, 8541fc12edcdef Divya Koppera 2025-01-15 1296 LAN887X_MX_CHIP_TOP_REG_CONTROL1_EVT_EN); 8541fc12edcdef Divya Koppera 2025-01-15 1297 8541fc12edcdef Divya Koppera 2025-01-15 1298 /* Initialize pin numbers specific to PEROUT */ 8541fc12edcdef Divya Koppera 2025-01-15 @1299 priv->clock->event_pin = 3; ^^^^^^^^^^^ Potentially resulting in a NULL dereference. 8541fc12edcdef Divya Koppera 2025-01-15 1300 9fc3d6fe802923 Divya Koppera 2024-12-19 1301 priv->init_done = true; 9fc3d6fe802923 Divya Koppera 2024-12-19 1302 } 9fc3d6fe802923 Divya Koppera 2024-12-19 1303 0941c832823498 Divya Koppera 2024-08-21 1304 /* Clear loopback */ 0941c832823498 Divya Koppera 2024-08-21 1305 ret = phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, 0941c832823498 Divya Koppera 2024-08-21 1306 LAN887X_MIS_CFG_REG2, 0941c832823498 Divya Koppera 2024-08-21 1307 LAN887X_MIS_CFG_REG2_FE_LPBK_EN); 0941c832823498 Divya Koppera 2024-08-21 1308 if (ret < 0) 0941c832823498 Divya Koppera 2024-08-21 1309 return ret; 0941c832823498 Divya Koppera 2024-08-21 1310 0941c832823498 Divya Koppera 2024-08-21 1311 /* Configure default behavior of led to link and activity for any 0941c832823498 Divya Koppera 2024-08-21 1312 * speed 0941c832823498 Divya Koppera 2024-08-21 1313 */ 0941c832823498 Divya Koppera 2024-08-21 1314 ret = phy_modify_mmd(phydev, MDIO_MMD_VEND1, 0941c832823498 Divya Koppera 2024-08-21 1315 LAN887X_COMMON_LED3_LED2, 0941c832823498 Divya Koppera 2024-08-21 1316 LAN887X_COMMON_LED2_MODE_SEL_MASK, 0941c832823498 Divya Koppera 2024-08-21 1317 LAN887X_LED_LINK_ACT_ANY_SPEED); 0941c832823498 Divya Koppera 2024-08-21 1318 if (ret < 0) 0941c832823498 Divya Koppera 2024-08-21 1319 return ret; 0941c832823498 Divya Koppera 2024-08-21 1320 0941c832823498 Divya Koppera 2024-08-21 1321 /* PHY interface setup */ 0941c832823498 Divya Koppera 2024-08-21 1322 return lan887x_config_phy_interface(phydev); 0941c832823498 Divya Koppera 2024-08-21 1323 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki