From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 190BF339704 for ; Tue, 16 Dec 2025 08:50:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765875007; cv=none; b=uClNFroTzHJyZjUU1gHeH+G2DiXL2oA5G2k17/vU1nHW8HhfHChxqQMyl0+dCVJ7rg98Dh7QZAcDrNm9EX9Z7PIe2c4HoV0sJ9vKYGm+pG3aPBP4HuZ1In00my1pb5PYNvb6Sb401pmW0FZaVU2sbYZTb171bHnIo8iBCI1v24o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765875007; c=relaxed/simple; bh=u1IeXjj461jmF5CTE483Xcffz8uO3nI3ri3MmYGMMyQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HioXCBdVvy1BIfsitc7gaTBdQxYLq4qd5MHLEQzmb2t+3gRWwGPv7wcvLkkQRI5RH7fdFD0cHlNvtO3i501ApPLpiE2av3EF6aF9w0OZIJ/iRupM4IB5uSCvp9dIcj3PtD94iT8B5Q3rcs0tHchYYrzEdKkoxMC38NRkluCbyqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=sETR00yq; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sETR00yq" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=KZkdk+K03JAxeJ6BQlmTvQKQx6812QBzeCF9F/TgVow=; b=sETR00yqxq87Fy6gRdKYHAuXiY WMzlEXXqSVhLwGTaYPD+Vu5wgo0C2OVLwKiAkh0dY2kDb1pPuFZZdwanUn/+EkKXtL2mvhkCvw3US io20mhfEZklsxiszVt17m7VW6HWW3y59fE/MvAtq40RbZBq5U7fVrbrb91Hv6KWHGhoVTf8uVnkhQ jH6Lc5f2K5yKrgZPUvGarUZs46HMCqxtJ6RxQd9r8wkGxVo8KPvTB0EP+REl57xXJcYcoLGQIbeRo IOgtHjzsV0mhdr1EZUW7IrhR98ESIV/3/6syiVkkuGRFyjZ902ZO6PGleyTDuRsQ+4J09s17/QQ69 2v43eq1w==; Received: from 2001-1c00-8d85-5700-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:5700:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vVQkh-000000033xi-1ziZ; Tue, 16 Dec 2025 08:49:51 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id F410130057C; Tue, 16 Dec 2025 09:49:49 +0100 (CET) Date: Tue, 16 Dec 2025 09:49:49 +0100 From: Peter Zijlstra To: Andrew Morton Cc: Brendan Jackman , linux-kernel@vger.kernel.org, kees@kernel.org, acarmina@redhat.com, jpoimboe@kernel.org, mark.rutland@arm.com, maciej.wieczor-retman@intel.com, Andy Shevchenko , Linus Torvalds Subject: Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf() Message-ID: <20251216084949.GQ3707837@noisy.programming.kicks-ass.net> References: <20251207-warn-printf-gcc-v1-1-b597d612b94b@google.com> <20251215202430.c35c2d29c4f9ff614d2ab534@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251215202430.c35c2d29c4f9ff614d2ab534@linux-foundation.org> On Mon, Dec 15, 2025 at 08:24:30PM -0800, Andrew Morton wrote: > On Sun, 07 Dec 2025 03:53:18 +0000 Brendan Jackman wrote: > > > Recent additions to this function cause GCC 14.3.0 to get excited and > > suggest a missing attribute: > > > > lib/bug.c: In function ‘__warn_printf’: > > lib/bug.c:187:25: error: function ‘__warn_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format] > > 187 | vprintk(fmt, *args); > > | ^~~~~~~ > > > > Disable the diagnostic locally, following the pattern used for stuff > > like va_format(). > > > > Question please. Why are we suppressing the warning instead of > addressing it, as Andy attempts to do in > https://lkml.kernel.org/r/20251208141618.2805983-1-andriy.shevchenko@linux.intel.com? > > I went off and looked at the commit which did this to va_format() but > it didn't tell me. Blergh, I hadn't even noticed Andy's thing was different :/ Fundamentally I'm starting to hate W=1. Either we think these warnings are good and we should get it into the default build, or we don't think and we should just collectively ignore them. This stream of W=1 'fixes' every time is getting really rather tedious.