From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sinmsgout03.his.huawei.com (sinmsgout03.his.huawei.com [119.8.177.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D63F33451BA for ; Tue, 16 Dec 2025 18:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=119.8.177.38 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765909048; cv=none; b=UkodPVyfYSuov7dPVAJgvnzpiqo25VrQWxLO1eT0xZYX16FvXlvnWKttu01v43faI8/epCPEGOOHE8nEwsRffK4Q4plpRTEHFD7CJWx1bBAUd8JKXyTBSyIXg/5OwyfshFhn+pGbN+WcsxW4ziCCXJWQAFLtG+ovnKl2d7zYnrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765909048; c=relaxed/simple; bh=JioDo0A+4j5DV9Ua/OD2RF+00K0pRfpJcDTPbaopEB0=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hNz4AQrj/S/m2c/+Ay0s92WfjpnraixunTxDs1mrso7RlUl5mQ8MGM9NWhBJuu8zOVWmfiIODe6/E11zpeXpRr1nRBaDgLFh8KiG77qnR6r9+hU7J74nx0P4JtZ1rSbgNecr17m+abTvCVzZ0XCXEmxSb/MW+r2bXeoHE+TNcZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=NtUWa42Y; arc=none smtp.client-ip=119.8.177.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="NtUWa42Y" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=zQRZUmfcmj8++GDqdfVsYF2/gcknHbeN49uCm+Yftqw=; b=NtUWa42Y7L5xQ4fkNRYLeLUyn2w/O7cHHrnJ3f8SG/RCIyePDUEOtosoC7N7XpVZDHUW3FV1a XeLJ8c7pfeJqgFo/CGvb7rk4nrW08ygjS0IOY+06uN9YzHhKCRvG6INMawkw4FcFHch0AMzPVa/ is3kt4g4DQYqPRB2bXs0L/A= Received: from frasgout.his.huawei.com (unknown [172.18.146.33]) by sinmsgout03.his.huawei.com (SkyGuard) with ESMTPS id 4dW4Sr1pCszN0yd; Wed, 17 Dec 2025 01:59:40 +0800 (CST) Received: from mail.maildlp.com (unknown [172.18.224.150]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4dW4VD4VSZzJ46DQ; Wed, 17 Dec 2025 02:00:52 +0800 (CST) Received: from dubpeml100005.china.huawei.com (unknown [7.214.146.113]) by mail.maildlp.com (Postfix) with ESMTPS id AE73040539; Wed, 17 Dec 2025 02:01:20 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml100005.china.huawei.com (7.214.146.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Tue, 16 Dec 2025 18:01:19 +0000 Date: Tue, 16 Dec 2025 18:01:18 +0000 From: Jonathan Cameron To: Ryan Roberts CC: Will Deacon , Ard Biesheuvel , "Catalin Marinas" , Mark Rutland , Linus Torvalds , Oliver Upton , Marc Zyngier , Dev Jain , Linu Cherian , , Subject: Re: [PATCH v1 03/13] arm64: mm: Implicitly invalidate user ASID based on TLBI operation Message-ID: <20251216180118.00005085@huawei.com> In-Reply-To: <20251216144601.2106412-4-ryan.roberts@arm.com> References: <20251216144601.2106412-1-ryan.roberts@arm.com> <20251216144601.2106412-4-ryan.roberts@arm.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100011.china.huawei.com (7.191.174.247) To dubpeml100005.china.huawei.com (7.214.146.113) On Tue, 16 Dec 2025 14:45:48 +0000 Ryan Roberts wrote: > When kpti is enabled, separate ASIDs are used for userspace and > kernelspace, requiring ASID-qualified TLB invalidation by virtual > address to invalidate both of them. > > Push the logic for invalidating the two ASIDs down into the low-level > tlbi-op-specific functions and remove the burden from the caller to > handle the kpti-specific behaviour. > > Co-developed-by: Will Deacon > Signed-off-by: Will Deacon > Signed-off-by: Ryan Roberts > --- > arch/arm64/include/asm/tlbflush.h | 27 ++++++++++----------------- > 1 file changed, 10 insertions(+), 17 deletions(-) > > diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h > index c5111d2afc66..31f43d953ce2 100644 > --- a/arch/arm64/include/asm/tlbflush.h > +++ b/arch/arm64/include/asm/tlbflush.h > +#undef __tlbi_user > #endif > - Hi Ryan, It's trivial Tuesday so... Unrelated white space change. > #endif