From: Rostislav Krasny <rostiprodev@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nsc@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Rostislav Krasny <rostiprodev@gmail.com>
Subject: [PATCH v3 0/1] kconfig: move XPM icons to separate files
Date: Wed, 17 Dec 2025 03:54:08 +0200 [thread overview]
Message-ID: <20251217015409.30102-1-rostiprodev@gmail.com> (raw)
In-Reply-To: <46a5f2d9-b118-4675-8372-40f9b2fc7bbe@infradead.org>
On Wed, 17 Dec 2025 at 00:39, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Yes, "make xconfig" worked properly before applying this patch.
>
> .qconf.cmd (generated by build) tells me I am using Qt6.
> I don't see any build errors/warnings.
>
> qt-core-devel & qt-base-common-devel are v6.10.1-1.2 from
> openSUSE Tumbleweed.
Finally I figured out why "make xconfig" was failing with Qt6 on my machine.
Because I didn't clean properly between trying it with Qt5 and Qt6. After I
ran "make distclean", "make xconfig" runs properly with qt6-qtbase-devel
too.
Then I've noticed that I inconsistently used two different versions of the
"srctree" environment variable - lowercased (right) from lkc.h in GTK code
and uppercased (wrong) literal in Qt code. There is a fallback to
QDir::currentPath() in the Qt code code and it seems like it works
differently in my Fedora 43 and in your openSUSE Tumbleweed.
In this version of my patch I've fixed that inconsistenly. Hope now it works
properly in all systems with Qt.
Rostislav Krasny (1):
kconfig: move XPM icons to separate files
scripts/kconfig/Makefile | 4 +-
scripts/kconfig/gconf.c | 35 ++-
scripts/kconfig/icons/back.xpm | 29 +++
scripts/kconfig/icons/choice_no.xpm | 18 ++
scripts/kconfig/icons/choice_yes.xpm | 18 ++
scripts/kconfig/icons/load.xpm | 31 +++
scripts/kconfig/icons/menu.xpm | 18 ++
scripts/kconfig/icons/menuback.xpm | 18 ++
scripts/kconfig/icons/save.xpm | 31 +++
scripts/kconfig/icons/single_view.xpm | 28 +++
scripts/kconfig/icons/split_view.xpm | 28 +++
scripts/kconfig/icons/symbol_mod.xpm | 18 ++
scripts/kconfig/icons/symbol_no.xpm | 18 ++
scripts/kconfig/icons/symbol_yes.xpm | 18 ++
scripts/kconfig/icons/tree_view.xpm | 28 +++
scripts/kconfig/images.c | 328 --------------------------
scripts/kconfig/images.h | 33 ---
scripts/kconfig/qconf.cc | 29 ++-
18 files changed, 345 insertions(+), 385 deletions(-)
create mode 100644 scripts/kconfig/icons/back.xpm
create mode 100644 scripts/kconfig/icons/choice_no.xpm
create mode 100644 scripts/kconfig/icons/choice_yes.xpm
create mode 100644 scripts/kconfig/icons/load.xpm
create mode 100644 scripts/kconfig/icons/menu.xpm
create mode 100644 scripts/kconfig/icons/menuback.xpm
create mode 100644 scripts/kconfig/icons/save.xpm
create mode 100644 scripts/kconfig/icons/single_view.xpm
create mode 100644 scripts/kconfig/icons/split_view.xpm
create mode 100644 scripts/kconfig/icons/symbol_mod.xpm
create mode 100644 scripts/kconfig/icons/symbol_no.xpm
create mode 100644 scripts/kconfig/icons/symbol_yes.xpm
create mode 100644 scripts/kconfig/icons/tree_view.xpm
delete mode 100644 scripts/kconfig/images.c
delete mode 100644 scripts/kconfig/images.h
--
2.52.0
next prev parent reply other threads:[~2025-12-17 1:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-13 14:09 [PATCH v2 0/1] kconfig: move XPM icons to separate files Rostislav Krasny
2025-12-13 14:09 ` [PATCH v2 1/1] " Rostislav Krasny
2025-12-16 7:10 ` Randy Dunlap
2025-12-16 20:38 ` Rostislav Krasny
2025-12-16 22:39 ` Randy Dunlap
2025-12-17 1:54 ` Rostislav Krasny [this message]
2025-12-17 1:54 ` [PATCH v3 " Rostislav Krasny
2025-12-17 2:02 ` Randy Dunlap
2025-12-17 2:06 ` [PATCH v3 0/1] " Randy Dunlap
2025-12-19 20:39 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217015409.30102-1-rostiprodev@gmail.com \
--to=rostiprodev@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox