From: Rosen Penev <rosenp@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 3/3] gpio: realtek-otto: use of instead of device handlers
Date: Tue, 16 Dec 2025 22:32:29 -0800 [thread overview]
Message-ID: <20251217063229.38175-4-rosenp@gmail.com> (raw)
In-Reply-To: <20251217063229.38175-1-rosenp@gmail.com>
This is an OF only driver. No point in using generic device handlers.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/gpio/gpio-realtek-otto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realtek-otto.c
index efcddbe01308..8bad43afc586 100644
--- a/drivers/gpio/gpio-realtek-otto.c
+++ b/drivers/gpio/gpio-realtek-otto.c
@@ -372,10 +372,10 @@ static int realtek_gpio_probe(struct platform_device *pdev)
if (!ctrl)
return -ENOMEM;
- dev_flags = (unsigned int)(kernel_ulong_t)device_get_match_data(dev);
+ dev_flags = (unsigned int)(kernel_ulong_t)of_device_get_match_data(dev);
ngpios = REALTEK_GPIO_MAX;
- device_property_read_u32(dev, "ngpios", &ngpios);
+ of_property_read_u32(dev->of_node, "ngpios", &ngpios);
if (ngpios > REALTEK_GPIO_MAX) {
dev_err(&pdev->dev, "invalid ngpios (max. %d)\n",
--
2.52.0
next prev parent reply other threads:[~2025-12-17 6:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 6:32 [PATCH 0/3] gpio: realtek-otto: compile fixes Rosen Penev
2025-12-17 6:32 ` [PATCH 1/3] gpio: realtek-otto: use kernel_ulong_t Rosen Penev
2025-12-17 9:34 ` Bartosz Golaszewski
2025-12-17 22:56 ` David Laight
2025-12-17 6:32 ` [PATCH 2/3] gpio: realtek-otto: add COMPILE_TEST Rosen Penev
2025-12-17 6:32 ` Rosen Penev [this message]
2025-12-17 9:30 ` [PATCH 3/3] gpio: realtek-otto: use of instead of device handlers Bartosz Golaszewski
2025-12-17 20:26 ` Rosen Penev
2025-12-18 8:31 ` Bartosz Golaszewski
2025-12-18 9:32 ` Rosen Penev
2025-12-18 9:58 ` Bartosz Golaszewski
2025-12-17 9:35 ` (subset) [PATCH 0/3] gpio: realtek-otto: compile fixes Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217063229.38175-4-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox