From: Al Viro <viro@zeniv.linux.org.uk>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: brauner@kernel.org, jack@suse.cz, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, clm@meta.com
Subject: Re: [RFC PATCH] fs: touch up symlink clean up in lookup
Date: Wed, 17 Dec 2025 11:16:29 +0000 [thread overview]
Message-ID: <20251217111629.GV1712166@ZenIV> (raw)
In-Reply-To: <20251217110105.2337734-1-mjguzik@gmail.com>
On Wed, Dec 17, 2025 at 12:01:05PM +0100, Mateusz Guzik wrote:
This is obviously broken.
> +static void links_cleanup_ref(struct nameidata *nd)
> +{
> + VFS_BUG_ON(nd->flags & LOOKUP_RCU);
> +
> + if (likely(!nd->depth))
> + return;
> +
> + links_issue_delayed_calls(nd);
> +
> + path_put(&nd->path);
^^^^^^^^^^^^^^^^^^^
> + for (int i = 0; i < nd->depth; i++)
> + path_put(&nd->stack[i].link);
> + if (nd->state & ND_ROOT_GRABBED) {
> + path_put(&nd->root);
^^^^^^^^^^^^^^^^^^^
> + nd->state &= ~ND_ROOT_GRABBED;
> + }
has nothing whatsoever to with links *AND* should not be
skipped even with no symlinks in the vicinity.
NAK.
prev parent reply other threads:[~2025-12-17 11:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 11:01 [RFC PATCH] fs: touch up symlink clean up in lookup Mateusz Guzik
2025-12-17 11:16 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217111629.GV1712166@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=clm@meta.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox