From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C15635502A for ; Wed, 17 Dec 2025 17:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765993619; cv=none; b=RdZ4/y2rbjcZEIv0Ksh38bsz7sh+vqAikg576Zh1ECV3dv9FDYJ6x0vZgb/qhCxpPLgzkLHBhMh0q4fdzBuG77eHOVPyD29OPCk+F5aVF8m54N2Vr2aYE0is08yEQ61jzGNAP34Gsfmd9DfQz0qW3NIOi7J9DN7LH+l0G5zjcEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765993619; c=relaxed/simple; bh=10PuJbD/hlVV3R05X/vtkSu59Oxt70T0gJP4xgHSrvY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ALpJvrViEJT5rvJfD6ZzY+379FSVn96HQ0CYLFnXu+7HnWVSMlicTP0zYYfggRb0YkQstVQCJmONEX1SNJQuaMeIfvHjPQv+xFUQcKqZp5XzmgttEXgHQzfJvZm/3DAJ3CxHCBrH5M1u1ZqokSNsJJyydVcAOBlbjOk9EtwxC1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pxhZ7UuK; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pxhZ7UuK" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a0d06cfa93so1275ad.1 for ; Wed, 17 Dec 2025 09:46:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765993618; x=1766598418; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=26JasJmptoj2sQia7hYhyQLiuzOJ/Yi+MG8nG8/oJQY=; b=pxhZ7UuKckpKCxzLIAonKE4yEnNZ2+CD0O6++P9UhZ9Lqy7kRA+uGxIiEqU5MKRHwo emGJndm7NSca691i3rjrpMJNNDzGH6gIhQCfhHDyxqDMpHO+iuvsZTb2T1ygkazl37/o M5FKBI/QNuSkReYd4hbJJAJ9wPXVl30+xOrvaBq1uKFLdJVt6UpF5I/R+ZBIHvctAJAp 8KLVj6P9GkII2FtltELGLPwiNdTDyAYaMfV+Io3Rdd89TxPHTz4BaN6Q4k5Sq+Qv51Ap Cq/ouO3EjrxPAc4Fvlap+M41t4sJjxv818bhfDJG5qW2FPzY40PTmnYG/9SVRllvhew5 TTAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765993618; x=1766598418; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=26JasJmptoj2sQia7hYhyQLiuzOJ/Yi+MG8nG8/oJQY=; b=iYSOrQGbAFQKBDI5h1hdmyTyqxhukwkkVp+Is4eX5pHmG0dpIa/U+IX/4fCa+J4I+1 YCAOPj6HSJEW8v9Uohs0a1iSpevrtgQVDNgtrR7KFzjr3DYg9MRiy3Azp5BXZMuY/EBR mavWmCMGcB5GluUS8ZPXPMt77H43GC4TAyGrlH804yg30aPnfxlIhpxOYxmbX5KzbEwL Tb3neHihwiGQWHzXGAkPIfSppe6+NPZTIBWsXgU8Hv5N/kdRZHQa+aLZPbDKB/c0slDI OwBo9+KlZ2RT7gSGvmm7TogDjE39ytgCPjrFo3cmGYxOe6lg96+ElvrzY5107sH5Wmw6 P8Hw== X-Forwarded-Encrypted: i=1; AJvYcCXpkbVDz0dVTFSn/GWkU+rFsDmB3BQ5loJI5wicnik4YEGJudxPOgw3/vMxo7FD8Fpn1/tLKGxzshAwXEQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyUaf+j0ZG9fmY4U5FwVSXOwZiFba2LsW9y4/rOefYnSj0VdHDN 0adG65jU+AnBtphK5KaJj7F3SAqBNWh3hUAdzwodlmaPJrpYQGx7JWCvG+vYE+N8Mw== X-Gm-Gg: AY/fxX4kETHqWsE4UvvxtMWA0KKvBbBtcfgnhI+uq8q0Dx3rYlFPTYPuItVV9q3cME9 E1qtm+DauJCknqQlh4teYiDx0N/eL2AWOCp9LlonRp6eFPG/De0jIxZdYK8mNxllwq5Myt76+uS uJuGtKM6N/qRMg7AHP8tALzrD1GCxI46N100ggVwXDLOs5nD1x19jdtFo3Rj4Kbu5hShXVlzrE+ t6LHFvY2id4wrFGh9YbHz/DQ7UMgqRpEpOqq3MDfZNhyAjwbGFV0mYsFhHtkzvHtFAzhII0a9MI 6z/zmC+rpKf4ue/6J69HaEaVpd4+hTigUY3DP22SYb1H4MdsKwh3hEExGiWjDc24tdX/kOFPm0v GPFRSb3i551uaOzQvZND/VsGUmt7r5HSz9vSBoxp/9bpbqq6fG00C4GXvv/ubBiLjsk7iaQuiFR yWJRxUFBY3f+MffmQ/3GnTwO1XLSCzOna+pdxo48/gK5dSwmbOSEQGAH8= X-Google-Smtp-Source: AGHT+IHcr1+PzgxX2lZMgAjv5am5n1vT4C3/GWc0GVjNxHzpwJACFGX6B/dWHcbHZndpxOfN+c8Www== X-Received: by 2002:a17:903:124d:b0:2a0:7fac:c031 with SMTP id d9443c01a7336-2a15f2d2f83mr2997765ad.14.1765993617109; Wed, 17 Dec 2025 09:46:57 -0800 (PST) Received: from google.com (99.181.125.34.bc.googleusercontent.com. [34.125.181.99]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7fe14568fbbsm67114b3a.54.2025.12.17.09.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 09:46:56 -0800 (PST) Date: Wed, 17 Dec 2025 17:46:51 +0000 From: Sami Tolvanen To: Eric Biggers Cc: dm-devel@lists.linux.dev, Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , Eran Messeri , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] dm-verity: remove unnecessary condition for verity_fec_finish_io() Message-ID: <20251217174651.GC2944334@google.com> References: <20251216230614.51779-1-ebiggers@kernel.org> <20251216230614.51779-4-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251216230614.51779-4-ebiggers@kernel.org> On Tue, Dec 16, 2025 at 03:06:10PM -0800, Eric Biggers wrote: > Make verity_finish_io() call verity_fec_finish_io() unconditionally, > instead of skipping it when 'in_bh' is true. > > Although FEC can't have been done when 'in_bh' is true, > verity_fec_finish_io() is a no-op when FEC wasn't done. An earlier > change also made verity_fec_finish_io() very lightweight when FEC wasn't > done. So it should just be called unconditionally. > > Signed-off-by: Eric Biggers Reviewed-by: Sami Tolvanen Sami