From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC25F35581E for ; Wed, 17 Dec 2025 17:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765993817; cv=none; b=b4AhL+t60TqhtzbxQlppSKKN1adSMtXTHUjZ9jCE9VJACW/q2wvJekt6+kGIuYsa6KaCPddS/1Es2FVKVFb9ElNi9XoWgEzmKL7dOQ2rPAJARnyMfJGX+G0FQ9scDWv16+ckpHosMWsukzByJAcsMXXeko0CC2aqZ0HBXCGFLJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765993817; c=relaxed/simple; bh=VSYTacfUxQ7ArQarNQCUJnxO9vH71J8cKFyn4hBh++U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FSZc8INQHgyD08vC3vORffDG0viYE6fb1QiXjbIbRLku16eumCZtLJn4UT/JgCAzPsDuygOzsVS22tRn2FZestdg+yRUvKwCOmw+78fZ5JjvS7EBRjGsGeOpN/JHAZrV7XLpHoLU/RBKGuL7sCcvKoU/r0Ar2Zi+k/C8sfsj/GQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=VSRekwon; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VSRekwon" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-29f02651fccso4095ad.0 for ; Wed, 17 Dec 2025 09:50:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765993814; x=1766598614; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3xhp+1qBtUxbsH2+oDGF7w9j3CH1HE7lPDRbg5WbMDw=; b=VSRekwonm8YHEwmvaRvOWUeFjVF2+h51i11g0+6TRqUj5Q+jl5Dg/A4Yw3M/7UFaGd uHF79ZOhgf7ZnYv1gf6IFBDGb19N1xNvhbeMXl26PxrQ48prjAbmt42G0ZCLpjeZjhi+ 1N1Fa+ArADsjpvES4RycZ/KLlj8d6u+DxXwAX9zawh1y0TQMa0ztW7B24Lt8OwaUW4Ft OTzjTM3vGsyWf5hwO/7kmxwDK59DBKCVDEcCS4Lr8J6wf/YB1Tm46Sj/2vGcA2nduZTi Kb1DKGJJV46cose+7I/EnhRdjjnIDwvny1bQoz3cyOjzYZhOMJVtnilbqixmuqpUvjXq oVPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765993814; x=1766598614; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3xhp+1qBtUxbsH2+oDGF7w9j3CH1HE7lPDRbg5WbMDw=; b=K1rQyELlQHFYuPI9FfQ8Sj7P8/EZHUvvLhwPRTYu5fOgryhJ57ZadHLFrWaHh2s6Yv UO1+02GHaY0tWwgyNYEdIjVzLyFe7i+o2TcYRb45DDP6FzyFkq8egO9qGejbW70R/9cL BaF1SF1/aeTA+NXu5R/VW0cEGgC+X8+jn2IgXea7H7WWjNdDJ74gZHSxA4wkZPPgShms TAULi1KaX6BeuRBPwOsu7hpr5MJ4QfjsGoOM9R9dUS0WB430Hg5yKfrmR+N0oiWE8dOT Z9RKMnCmuk5kCkcfooNxJWccBx1T0gVISsJvHCxveXZJD2o7fAzzFo3I6Jii1piKl+uO zFlg== X-Forwarded-Encrypted: i=1; AJvYcCXljx6UTgHse0WP8T/VOzKZQ/f0jLYl0Qhf6J+5NA4vHRRCSBeVCHjDIpTgzsD9ElFNN4VZaPjriFQ8wHU=@vger.kernel.org X-Gm-Message-State: AOJu0YzqDGvLMovXLhTXBhxUdiqNBAUX0v+KbQF79M4MN2bcGuovxNqs AIpo7RFR8rERFbEFnkFnx3GUmcE26Ok18sZcj4YRMGIbj8x1JoK85OxhrMz8QcZN3Q== X-Gm-Gg: AY/fxX7hUDeL/NW9xZxeX5bqeYEdnEGsLLTkDAX3EFlcrjvkgKi625K8UCAkaIFgN7o KWjbbi0hMM/+Nt3I3tfF1+rLCaBm28iLwWbakRuH0WjvIfPmVjirvq8lPaCPo02yKrSwpMD2vUV /l5FvONwLSLtibjfH/HiTJn8GWxwR/kp108r5FUImCpq+Gktk5KT/QNumaXnkf1cq8eV3pFInw4 bQ7vAO2fpjvmguOWvg2tovgckBy5vRf6IkqE8Ifr+7tXjIFxGtW5mxb4X56d0feJIB5tS6oFMbh uCZ4Gtt92daA3YNP5iGljGhrF04Mdq6rNuReZCrDEvQbHpNFRDdyEHrsTKo6mJn68Bon1vAUl+u C0h5ggnMqycc947YZVWs4f75HIbAsEF1vTA1gBZCSRgZxwZerY11FycNIE2oNferKMSC70zOAwp ETGQ5nJLya4Td9Nn4WwEh6imgYuRrt1FIf7rpRcuGkBwqyn+yDSoqiqgU= X-Google-Smtp-Source: AGHT+IFK2VlOos5FzsK9VT7JjL/uMcHVcPWBiFYtwTGCMoPAHa+uZYr+UNkyhMCzItk9Z+tUDS6biQ== X-Received: by 2002:a17:902:c94b:b0:290:8ecf:e9f9 with SMTP id d9443c01a7336-2a2060d6808mr2761895ad.7.1765993813325; Wed, 17 Dec 2025 09:50:13 -0800 (PST) Received: from google.com (99.181.125.34.bc.googleusercontent.com. [34.125.181.99]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7fe121222bcsm92877b3a.19.2025.12.17.09.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 09:50:12 -0800 (PST) Date: Wed, 17 Dec 2025 17:50:08 +0000 From: Sami Tolvanen To: Eric Biggers Cc: dm-devel@lists.linux.dev, Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , Eran Messeri , linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] dm-verity: correctly handle dm_bufio_client_create() failure Message-ID: <20251217175008.GF2944334@google.com> References: <20251216230614.51779-1-ebiggers@kernel.org> <20251216230614.51779-7-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251216230614.51779-7-ebiggers@kernel.org> On Tue, Dec 16, 2025 at 03:06:13PM -0800, Eric Biggers wrote: > If either of the calls to dm_bufio_client_create() in verity_fec_ctr() > fails, then dm_bufio_client_destroy() is later called with an ERR_PTR() > argument. That causes a crash. Fix this. > > Fixes: a739ff3f543a ("dm verity: add support for forward error correction") > Signed-off-by: Eric Biggers Reviewed-by: Sami Tolvanen Sami