From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D95253358DE for ; Wed, 17 Dec 2025 17:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765993892; cv=none; b=r9K6n2LAGtd0hbnZ18r8igslFZkikRV8/kPwRFL3eSvE1F2XKY6SEmYLLJEORM3BDUMODmgLBZ+NaATEtDuvowoubH0/PWXhS1bV/SvSbLR4O98v5jC3E9/vA0OHFnrfHFtjFmhUkXR5cKxrBsCNpmoxnLp4XXGYvM9dQzX8NUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765993892; c=relaxed/simple; bh=RCxp6y3XJ/hXVxOndc/GAG8xesvNhKJgedju7fzLXBY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fSwmrf0OLIIU1Q6Vrw2Qlo5FN6ru+LeDhp9yHxLRmMnR61lgTz1nFqCQ7WWLndYMCJplOGrT/5G45bxyRDrQ2y9U6iGxfXOO3Zu4ttcDO3dm0HI1ZyOE3DVZe+nR/ZtfSXP2Iu8QsjCgKfaM7EE1VwqMcT6Gaz59iQ7J0C+MZ7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zmGRCZbp; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zmGRCZbp" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2a1462573caso3545ad.0 for ; Wed, 17 Dec 2025 09:51:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765993889; x=1766598689; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZyTq6XmdfdDxSW4g2YrFks1A8iekcfCGj5INQxpHBvo=; b=zmGRCZbp9R22bRIHmYEtNd5jDjc8ACR+8HPjH2z8xGN1B8PA4tHhyK/cYAu+d7ngJC PWkJOMYpeh/wIksNrCW3289iKbb4pUrTkPLvS20ZxsHjKFhL8tZxiHBnu/lJBjJiEqID l1l1bBfqIm80kOGwZ7aKVcaC/S97twdPV3Bl4FbzbG/Tyxxmt4HKk3gZP88fnNSZBo+Y 6LhHPn4D3IO+zCQ+qCcB58hs8SkDfJx17FbR0Rp4DFO84oars6UrxC6lukUBIkh21JkA 2hr1lvB7G9XCS753kjC7PnXkGsRv4LKIRWxC5P/K8XTgyqkQ1GRejsB5E/CQ4B2/6PRB hRDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765993889; x=1766598689; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZyTq6XmdfdDxSW4g2YrFks1A8iekcfCGj5INQxpHBvo=; b=MgAf3idaff/w+t2RxZ8bPzGeP1gGElbh5KaXptDtOYtxmhoyUVaxwp32tud+P1vXkq ejtpGeedzVIontcFZjdSFbyGRKhQOdmZCW49OPgJ8Sg+JLFKbxe6ZmtDtUkNzeyQA+T+ O/TOWXo8xdxnvqaFO7+a9iYBOg3NvswbMJG8Z042dHpXnxGg98inR2npsQxarDCThtrS Cwwpwg+BQ5k9eOcbjvPp9Snt1U9ve9+s+DIxlz6E45gmylRrhgUzFTrKCsY1L6db1FS0 i86zWa9SDN13/wUki3B59B+PqHcn5nNqGZwyl8h6UjdfjSNDtC0CM4vO2OD5GuhPiyqC /XUg== X-Forwarded-Encrypted: i=1; AJvYcCUUVNruN/BRolL6P0tTBfnUqP0YConNEyIX1pd+7iYqyNbtRECUoNPlAVDRUwPzdncGvHEVjppGntBza9k=@vger.kernel.org X-Gm-Message-State: AOJu0Yyj/MKD2KPBGcD9ahcviymgryNKpLWtb3wgBm2v0qkSLRJc1EQ3 iiVCplBnxfSHHRtdBhx2C1L5gPSLaM8t9yMlAOiwXsX/kef6BWZ7pxmspIcwCFlCew== X-Gm-Gg: AY/fxX4THXkyNoRDlLwPeiYO99YXKklCPUMYSLXo/j+PAG17ClFIm/61uBKwTSji1Xl rVpDlTbq/YpDyRKDKZmVv/x1HTjeV1HzTdHtC+YMVqt9fOyqCcVHmmaOMClg7HulhOMmE+6LSi0 Dzm4tK8t7FhaOmuZgrUvUjv4RwFRo8cgqqG3CfvneGgN8DPlROQslJEpnH2+fd/fJ78K+W7f66W 0dsipgCNS5c2k3ae5ObsPYSuRsgn+noFaj/f4T1I+NBVKRP+Dm8WQ71ihtFIb7QEhnw34bOTMkU xQUoJa7V1LkUyeAAzQQdQCl4AqWYlxTZXoeqwJ7J7zoOIbdqOsu5yEFBDDa7gqAbGKketwbFNsW M8kaKe1dYk2+NukEUT9SONHp+9okr3AKmShCeLhi3ZOG1pFgqaXcSt5GHqhEG2yaMSKqvN3n7ea pNwFyqiRsE5h/arm9XEYyzice0i6tVkpUORa5jKChvXKZZqxMrgGBpAp4= X-Google-Smtp-Source: AGHT+IFld/cVLkutGPIwFU6gTtgiNwrdStwKm/AuagaycEuqI9ldZygKeX4fyLGVXc23iyrCCgoS1A== X-Received: by 2002:a17:903:b4c:b0:291:6858:ee60 with SMTP id d9443c01a7336-2a15f261df0mr3617535ad.4.1765993888769; Wed, 17 Dec 2025 09:51:28 -0800 (PST) Received: from google.com (99.181.125.34.bc.googleusercontent.com. [34.125.181.99]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7fe12128ebdsm93892b3a.26.2025.12.17.09.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 09:51:28 -0800 (PST) Date: Wed, 17 Dec 2025 17:51:23 +0000 From: Sami Tolvanen To: Eric Biggers Cc: dm-devel@lists.linux.dev, Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , Eran Messeri , linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] dm-verity: allow REED_SOLOMON to be 'm' if DM_VERITY is 'm' Message-ID: <20251217175123.GG2944334@google.com> References: <20251216230614.51779-1-ebiggers@kernel.org> <20251216230614.51779-8-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251216230614.51779-8-ebiggers@kernel.org> On Tue, Dec 16, 2025 at 03:06:14PM -0800, Eric Biggers wrote: > The dm-verity kconfig options make the common mistake of selecting a > dependency from a bool "sub-option" rather than the main tristate > option. This unnecessarily forces the dependency to built-in ('y'). > > Fix this by moving the selections of REED_SOLOMON and REED_SOLOMON_DEC8 > into DM_VERITY, conditional on DM_VERITY_FEC. > > This allows REED_SOLOMON to be 'm' if DM_VERITY is 'm'. > > Signed-off-by: Eric Biggers Reviewed-by: Sami Tolvanen Sami