From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012036.outbound.protection.outlook.com [40.93.195.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44A8E186E40 for ; Wed, 17 Dec 2025 21:33:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.36 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766007182; cv=fail; b=bPv3/pIHvs4TZzwa1hDUE9TSnkKrcgNveItUXO/Od9nw+7fyRGFo9ECQIprqjaaf5oyeiJ7ZnaPOKcfOhbEAHRuVhJKmoNT2WDk4DtdedlGJ3sdck+X6geTDhD8u3rm/y3leXRzNkt9AhjfLgLO/WUQMZSGb4Ssw3mCB3lJa5Pc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766007182; c=relaxed/simple; bh=j0aAPpbCrNL7nbhLbWNcF+PpoCC40yRgHjJBRqtYU18=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=pL+Hxhf7vL583xK8eqTjed4t+kfh2rg1Y/KltqB2Kczorhu3n+1GSGvYWHVAIVsfBlaGHD0ldaDSLnzhW0WEcpgo7QcThN3fZ2NAYJ84IDN9ZXXoaboPnWbSJMbJDXfhRLr3oALcMUhO/HVOoDR+AsyUEhzIXdwUGVRKkHqMhrk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=gTd6dn8f; arc=fail smtp.client-ip=40.93.195.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="gTd6dn8f" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JzN9e8nZJYNTPWL3p+h+gzNpnvXftWULG/Wj31YeZ37wGRYfRDj/1a8as+zWaWIsu3xYjihaPbW3uTwBumLY33gN99AoC/JPwhkUy4Q8bNAccX+cCA9cplcSr45AGBvMZDZIfOT0WX8a57b+6LWKSjtAJ/Zvj0SxcO/0EEDi/CZb7nFl61EXbx6yciXFOsH9XxApyWw7WVERzve7+rAnTilhOWodnggR7YfAyMJvYrnWog7VcaUM2LwzzbF75uLERVYm83VBrAEOS3MrK2mPig2eSBLum3iD7nczNyqkSvCI5rsLbFfyKtzQqMnFHVR6NBdXIi16YmH3ThlZOk9yMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IpjEWx5HOh1/aToNT7DGnglz+Vj40PaCDCISdgdHMUs=; b=dYxNwnslBKmekU1RJ+nPuyo9DZCESOH+03JMetKQD/CW+X18HTzwdDrEGtCzjhjoeyvp4AmH6l9qTl725N6tqHD0dME8zdW9JvGQn8Czz/JaU2PoxhoulMSXzs+I821pB7nhE6YLIwKm/VbGhrfui3XPECoEInRQHjvdDrg38DnN90NrPyW3oIsh4PxPP+cdZOP6+TuJWE2P8D5CqJxGLWWZVL+bO9HTlDeh4V9A1RPJXF47XrX0S8tfSEX1qJdkFbXYDLs08/EDCptXBiUwmriZOdVFDPlpcExYJQznSqdyE+qHqe9k0PYAMj/GemNifcpcnuiuwoQXEMZQLlZpNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IpjEWx5HOh1/aToNT7DGnglz+Vj40PaCDCISdgdHMUs=; b=gTd6dn8f3P1j9wB4eaTxGGxqUR5KElhzLdXeWFrUySWnm1YUH3tPYsgOoR0MlJQtg/7jdTye5pu/yyFOL/kU9iEbz3IWSyQl7Ncwd6BVoMc7wFzQkXJzcdD70RVhrHvfoilQyt/Btb4ymlYB3j2+IAa7PfruVUFJgxwy4ljqnxk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB6373.namprd12.prod.outlook.com (2603:10b6:8:a4::7) by MW5PR12MB5684.namprd12.prod.outlook.com (2603:10b6:303:1a1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.6; Wed, 17 Dec 2025 21:18:49 +0000 Received: from DM4PR12MB6373.namprd12.prod.outlook.com ([fe80::12f7:eff:380b:589f]) by DM4PR12MB6373.namprd12.prod.outlook.com ([fe80::12f7:eff:380b:589f%6]) with mapi id 15.20.9434.001; Wed, 17 Dec 2025 21:18:49 +0000 Date: Wed, 17 Dec 2025 16:18:44 -0500 From: Yazen Ghannam To: "Mario Limonciello (AMD)" Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Jean Delvare , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 7/7] x86/CPU/AMD: Output the AGESA version to the logs Message-ID: <20251217211844.GC1263950@yaz-khff2.amd.com> References: <20251216123354.9219-1-superm1@kernel.org> <20251216123354.9219-8-superm1@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251216123354.9219-8-superm1@kernel.org> X-ClientProxiedBy: BN1PR14CA0021.namprd14.prod.outlook.com (2603:10b6:408:e3::26) To DM4PR12MB6373.namprd12.prod.outlook.com (2603:10b6:8:a4::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6373:EE_|MW5PR12MB5684:EE_ X-MS-Office365-Filtering-Correlation-Id: 452d9716-f4d6-4227-f2cb-08de3db1dee3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Q3NrjX0uYG09qFCS3PcabRUSOFj39k8a70sqtCBk6H4jnXl1HoMpY7XszwsW?= =?us-ascii?Q?RTGa6xf7dadIt4MDCjHn1pUDKSjrFWxCyhW8KbJ0HoU5MYLqiGd2hX6MDxQD?= =?us-ascii?Q?OODejcRrFltPqPZxWTq+SehMJ0Q2wiS0iZUWwQG/YFfuiN1af7CsHJN1nVKY?= =?us-ascii?Q?9Qb7W57icNMgTp/kEbCrSXh9shMFAqmwz8rwxuLYskbQDRWyvrWnW31Vbrms?= =?us-ascii?Q?vUTEAPa5MSYctF3AX6Hz2Z97C/sl0gHt88xeQ3X68VoBR7qLzZlUwtEdGJza?= =?us-ascii?Q?qVDy2rZLBM74B1JjR+1p75IDZZeyUud1gNO7D4M1LY4Zgk56gIkv2+maOrXC?= =?us-ascii?Q?zWRbEuB+WRnP1+EPC1dXLNgwG6p/Dg9lvypmNhBADLWsCVCBK96O/XVBKXrk?= =?us-ascii?Q?tGGlaPHlsj+4J34W2r1es/nFi5OVmCkJK2R/XB0XdqUuC0IuMSaWzRQI5icz?= =?us-ascii?Q?q7Yhab5zoDGarX+XC6YjCHrXdU+qdu9u3IKpZ7GJ80IC2f52rIqPQMKMNF8K?= =?us-ascii?Q?3pth9v6d20Rjqn5NZBH6l/cKsKxmuycfgo0my4MvkzYd+Yc1aTu4RNvaLQr+?= =?us-ascii?Q?BXlOvJ47nI/4Z3lm199sKbP5r/yVmnNVRx+zgPWMUdnQLoyAiJQmGAj+llCe?= =?us-ascii?Q?xPIOjIAXNeUw3TbXb4qK6XjwtmwuWDVYQMvolq/jTu4ah5hGBuk/RWJcKwOR?= =?us-ascii?Q?8COuFK1YwAJZukRWZ1dqCjE5FSf2Ke2l7NFGa9BjDU6RPi3U0Y4kqOK8aDy4?= =?us-ascii?Q?o6b3hwJ+FILiuKuM9kRIfyabrczbhokiR2Ro0HQKEUMjEVsIc6E3J8dytkuX?= =?us-ascii?Q?qFA6FmbGVGFvfC5zJTugDRAB6Pu9O6eBfKByrjAUqMEQFLLbH2oQzXN9bH40?= =?us-ascii?Q?Qs+TU+H29jXm1WWA65vOLcEmyaA5LThV3xt4+TURcjtkD+2MgS+oMtel5yLt?= =?us-ascii?Q?6M8eDlY6A+kUU/nbiWJAfr3QalNUlUmqA+j7qXWxTNXXBiHheEijlgbNUI+0?= =?us-ascii?Q?u/9UtPc1oxvxTi11RLHlOS5kggQiF0czUJYKOxQqhvZN3a7TwVlSNXqhWxKO?= =?us-ascii?Q?JEpnKr8z8IJWJvrl9Kw8YCmLJTIz6TQ9q0ds3Ujm6JijhAHoEJNFgViC1X8a?= =?us-ascii?Q?SabTmYWqtKuDlXTytwNDQLHjIGWj8+dk0nm0Wr7KQz1R09WsTa30VJ0xfdtl?= =?us-ascii?Q?47E/94kWhPCGYrtypjEF2zt1SEP1ZXimZGFaT520AByl6jf9ELLLCwEze96u?= =?us-ascii?Q?F2a+uFZTP5HGe2rJrJnxd0T5TmMX95lOOag83+tJ9ruM5BYHB2CId9x0JZwE?= =?us-ascii?Q?EmCvcvCKU8LrtRHupCoVeQj3lzdt6VbyFMMIngVBsGWaYdTUvwd44gLuhx3X?= =?us-ascii?Q?wXdirtPHj1oQLG/z+tUXHJwUkmw+iWvjrzl5IFeK37QSqkbqPg56WtW5fEkx?= =?us-ascii?Q?D94L4rAL3BSoCI2+cLfctO9lI616bGqW?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB6373.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YJnut3ZWSPSoXapFGzeGUpHSGXJ5m+9UNiyJS6H5w1duDuwX2JXKiwIlOIAT?= =?us-ascii?Q?8oOtcWvOG0aXEv03021o1mpnNhy3E3zSc7c0VZzOE+sdSmbjt957hziOSZS0?= =?us-ascii?Q?1XMw1ru5OEoAit9l1hx4IPhaBpBMF9V+SS1uvPEawHc74g6h/ERtE76+m8u0?= =?us-ascii?Q?UAUAd5L6XsBXNJWYYHH8yg3hf6sV8lq6SSo8xLqcfDGPxpEtuiWq/w+1Kpf4?= =?us-ascii?Q?bbLWueLD4zVHncDCgUM9/4mVjRB/xEsXdVGhT1xXS5Mj2F/2pA1C+4C4ZWz3?= =?us-ascii?Q?PEQh95ASy9VrR5bHZCa7Bn1jdWDJ/uTgaZDEDbS0ekMHtdjulMVGIvsGBOYD?= =?us-ascii?Q?upSYvWvu9JiiEalYI6o8xnpv2aiYdfa8MCpwa38rPrEToy749TH07HFGXfRA?= =?us-ascii?Q?W8vRwLtEZ/BvVpv6x9F0mGWVv5hkIur6v86zwSPX5V3crrOwPaUKl4XTr+eo?= =?us-ascii?Q?2zm7pqoXL99a/knTbR3/IBe0SXHgob+ARr0E+fTJT5Z29WiuLxumw1hTMT+4?= =?us-ascii?Q?CM7EtDDIiOrj8ccrTzIWZCdzNQI8jPh9hX8dYLjO1rRzBh/FU0+Ze4raj588?= =?us-ascii?Q?uuKliwiiuo+GQA2wDhC1sPUwhQKy+tZZ4vZLPopX1fFU+LW3WSo6amzaNAMn?= =?us-ascii?Q?HO9jwtkDsNbZf1JFUb+G7wvJXG0xzcsjLdQVd3ABGl/Kzgdk88AzEvKOcCZl?= =?us-ascii?Q?qnERju3LHiQGV4z2TSD+xtvc4s48G5QuCW9JFP6aQtFgnb9yjNbOZq2vg2W1?= =?us-ascii?Q?DIY/NQDKUUh77gBAHqmS5MbkrwnDgUBsx6H0eln0s/eNBglbCFlLR3PFMqqm?= =?us-ascii?Q?bXaNBlcCPdTxxqnTWqy4uP8GMCG2qd3+a+TCEWVoqjMlDn+131XA36qOoPYB?= =?us-ascii?Q?/8aM8e6el9voRIPWjx0FWtsFOXYGktagCa0bGnA3FkmzH2vOmiTn2UIeuaDX?= =?us-ascii?Q?mzD4gkVGZlqHNIVUpJZQvu7oYtZUm+8TqfgyCgLlbCKG0yj/zEmrZE1FjaPN?= =?us-ascii?Q?bdu9trivkhQIqgoxXAhcco7XEyjNApEtGUM+dA9gpCY8nIg/AnBMYthWzNH+?= =?us-ascii?Q?fswiv+hCvcpR92FJNJu8iRWa0F1PS6Lu3wzie5Aco23JnLs1jycj/s9mFQKA?= =?us-ascii?Q?w7qJMOca0KBSfeMpbHrcemYzc+KrnDoEbowJBML/DIuxVSspsqLmeAmE+RbH?= =?us-ascii?Q?OsLUzOU2j6kWIpIpWkPQmX+6tVirtYiUh0gQ/BbnxEew/riSole/XITvrjIs?= =?us-ascii?Q?suIOz4eL4cRqzzHBoNcNvYlksFrV4qjdShepYJNayv+C21QuiVTnjnOD/iqN?= =?us-ascii?Q?ncLG7/uSS0p4GH5A5+GeZzi6qZ1aEqKwgCd2WJ/Zqzxw6SpejnAp4Z7kaARB?= =?us-ascii?Q?JBrUlULbgVMXxr3mPuf3M6dWzxL7ajk29mPE7S23uVnlSn+04FHvZKaZ6cq5?= =?us-ascii?Q?ovQnMAjaJhVeMt2YbbBPk7Hf+iDw0A+qBujWlciyMmC/nI95UXxCP6cYLl8J?= =?us-ascii?Q?gTjIy4Zut88OadzNt2KBcQ36LqLiKRTI9EdReGnFg4Nrm8WjqCoX9wxS0jQs?= =?us-ascii?Q?GDgYM3OYsrCxghIc1XR0rjgghLSBjmsDuaUH+L4x?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 452d9716-f4d6-4227-f2cb-08de3db1dee3 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2025 21:18:49.3278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G6y1wPk2eN4nWusKt8A63a5TWNc0Y5E8FvBydIMXqLw6p4v0BebdTJBWDCPdJxjegOhLZuFbOHYpcU9B/okFow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5684 On Tue, Dec 16, 2025 at 06:33:54AM -0600, Mario Limonciello (AMD) wrote: > On AMD Zen platforms that are running AGESA, there is sometimes > DMI additional string for the AGESA version that can be helpful when > debugging an issue. If this string is found output to kernel logs. > > Signed-off-by: Mario Limonciello (AMD) > --- > arch/x86/kernel/cpu/amd.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c > index c19c4ee74dd1f..8f44439d3f993 100644 > --- a/arch/x86/kernel/cpu/amd.c > +++ b/arch/x86/kernel/cpu/amd.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0-only > #define pr_fmt(fmt) "x86/amd: " fmt > > +#include > #include > #include > #include > @@ -1406,3 +1407,20 @@ static __init int print_s5_reset_status_mmio(void) > return 0; > } > late_initcall(print_s5_reset_status_mmio); > + > +#ifdef CONFIG_DMI > +static __init int print_agesa_dmi_info(void) > +{ > + const struct dmi_device *dev = NULL; > + > + while ((dev = dmi_find_device(DMI_DEV_TYPE_ADDITIONAL, NULL, dev))) { > + if (!strncmp(dev->name, "AGESA", 5)) { > + pr_info("%s\n", dev->name); > + break; > + } > + } > + > + return 0; > +} > +late_initcall(print_agesa_dmi_info); > +#endif > The Zen check is gone. Is that intentional? If so, then I think the commit message should be tweaked to not mention Zen systems specifically. I don't think this is a problem. I think it's better to keep things generic, if possible. Thanks, Yazen