From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7060132F748 for ; Wed, 17 Dec 2025 22:56:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766012172; cv=none; b=n2EB2etzTXd44Y0XXa5Bd75M3jt53e9CXrXT76D8OKoKWQUGLwOfQGeF5/YfCv3y/eA4jHN0+sdSNbVLSrto0l4oYmVrbaly+bz8bCmjIbuklcNK10Klwkow0bVyYA4TsOL0/1+P82/Wkz9UDnKFmDbofySKL3FfKYxwtgCZESs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766012172; c=relaxed/simple; bh=tDcplPya4wN+AN0x25eUKl1n9tuesEBxzO/VDLpjhQs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZGn1hXtdXCJv21BYiQMW4uRIH1tCfMafDGJ/HjQJYrvPQtoGpS8eEZCUoU7QE2/fhgNFMAqIAKUBVNhjo3rb8/dl8HkIwSAAjxd4aqbcLyAGwWTSmqFpyZEGLPU62j4S3dYW9OA0WoWt9H/ZKvx+s170+2hEh9d0+ND7YUZmXSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XJEoG62p; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XJEoG62p" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so200205e9.2 for ; Wed, 17 Dec 2025 14:56:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766012170; x=1766616970; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=yGDBzKhNFF0/DbhEJFH86AaKvU2hDmw4u3CRgvRYNNg=; b=XJEoG62pQeBPfUw7vCqFQpblnozXxfes9wCFUgrs56qYQpCXASO+KNvM+pnUMP+RjK 1yvh4MUoOzTbdXfMR+ocs8tJtqF/bV3cKrt6nEpjjAdyh33IATLtKcxQAkeRWDZpYhK0 wDchhOCdGSH97tnUVjcRF1E2ZLdjVcgqUu7y0UIXbFaiggFMMX3g1C7+fSmCAtZZZAhx 0yW/NW/WlqQR36JZ5DLaPn/SjOE/eiF2lceDBoXJ8Lwv53eAhZIrvEyuGfOoWdLvndjk MoLNqigsLamD1jZvELXzg6u9phH96ne4IXM6fqAjkWI11mceQtVkz9m0rY4fCnjwGNwz Ifwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766012170; x=1766616970; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yGDBzKhNFF0/DbhEJFH86AaKvU2hDmw4u3CRgvRYNNg=; b=ExlwlwKHRHaZPPJvSO6ydtp6B/7zVvhSN8YjQQ2wExbrXg4cAMJgB2JkFx4eQ0Pnd1 dQ00Vxl660dwrjqTJ/kz2+1aXy29D6xipmVXSNbMoWabCBIerebymDmU0HyHu4e3cCII JonLc0s50fQz14tGcIP7I8hKc1ZInzFt4B/cliFJ20tWSLPtl2ssnS7zWM9bHHblmgRi 2cVg3KsuDkVudKwgaFotnYXazBjSF9TW2CdHN3NH2FqaUZPLuhGPx5E79nln6mgbaYB+ ZpJjEo7DF2qZzAfruhPLRj5Ihzq6Q8tpmiIHmS7j2e4GrPhNQOuC1i7jFWjwl2NOmcK5 lEIQ== X-Forwarded-Encrypted: i=1; AJvYcCXv9gtNp/ico9IW8YTTsIr4OKABe8MJbuAPwlq/HC0hj+QT3wIs+idRRUQXVCf5xwlmw7QKfEuMoAtFOws=@vger.kernel.org X-Gm-Message-State: AOJu0YyrULgQ3rUbwKWZPFQSkBD+6CaM5K84V21e2K67VzKHW48lVLB4 qV826NofW42a5cBharS15vne73THtQz++YSl6og+YRdTL8LwhMTYWfZN X-Gm-Gg: AY/fxX7OicYinrFENhwXQeuQALzQ2zr0ko+0wLXg7zBa/QiV5FQLD3PURSlh2SCbj0C 0sMGdUZMCVm9vZ41zX+VDy9DtIzII5Wy7m83KSJ/RP9BOR+L05UzfwX6YRlM+7jmWnNezLUsQBa OkhCRZXTt/B9aY2QvtPaARk8l/X7IE1otUiUuY9Vg1EttUx9Ap47wBhGnxB0nLKTsjN/FxnPeI9 Cumc/dzypvxXStvX0HqV+BRijSNKA02xfeEuoczzt79tblL7jYmtMAn8jQfkS6QjoEXjjSceJ3s N7blN1NSfFX2HynlCEk2pJO/ZCLXEPNM6v4EmOnZxqZokrOw2Isky9kKhEKbCFDPB30mYventII GHOFlYuR4p2Q+rHKynfIkE2cTsxkr1FL+KgeiN36uZdIhW8oZMd/T+HJ7x5Hw5FjReGjzysL1S1 wA5wLySJLmEgU5jM4LHAwq0S/IXi3F+nNkToxJByyFFP3zJWyfNTut X-Google-Smtp-Source: AGHT+IEzCpPRP29Nw7XmHkBgKhPimfySiZt+e5Z79juOGxsjflLsAni8KH+OMXRbry8YbaFsi+oCzA== X-Received: by 2002:a05:600c:35c1:b0:477:7925:f7fb with SMTP id 5b1f17b1804b1-47a8f8c423fmr240925455e9.10.1766012169699; Wed, 17 Dec 2025 14:56:09 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43244940148sm1452728f8f.15.2025.12.17.14.56.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 14:56:09 -0800 (PST) Date: Wed, 17 Dec 2025 22:56:08 +0000 From: David Laight To: Bartosz Golaszewski Cc: Rosen Penev , linux-gpio@vger.kernel.org, Linus Walleij , open list Subject: Re: [PATCH 1/3] gpio: realtek-otto: use kernel_ulong_t Message-ID: <20251217225608.1db1a51c@pumpkin> In-Reply-To: References: <20251217063229.38175-1-rosenp@gmail.com> <20251217063229.38175-2-rosenp@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 17 Dec 2025 10:34:26 +0100 Bartosz Golaszewski wrote: > On Wed, Dec 17, 2025 at 7:32=E2=80=AFAM Rosen Penev wr= ote: > > > > Fixes compilation on 64-bit platforms as pointers needed a larger type. > > > > Signed-off-by: Rosen Penev > > --- > > drivers/gpio/gpio-realtek-otto.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realt= ek-otto.c > > index de527f4fc6c2..efcddbe01308 100644 > > --- a/drivers/gpio/gpio-realtek-otto.c > > +++ b/drivers/gpio/gpio-realtek-otto.c > > @@ -372,7 +372,7 @@ static int realtek_gpio_probe(struct platform_devic= e *pdev) > > if (!ctrl) > > return -ENOMEM; > > > > - dev_flags =3D (unsigned int) device_get_match_data(dev); > > + dev_flags =3D (unsigned int)(kernel_ulong_t)device_get_match_da= ta(dev); > > > > ngpios =3D REALTEK_GPIO_MAX; > > device_property_read_u32(dev, "ngpios", &ngpios); > > -- > > 2.52.0 > > =20 >=20 > Just make dev_flags an unsigned long and cast > device_get_match_data(dev) to uintptr_t. Or just cast the pointer to (unsigned long) and leave dev_flags alone. 'uintptr_t' is a 'user' type, not a kernel one. The kernel tends to just use 'long' when pointers need to be in an integer type. David >=20 > Bart >=20