Re: [PATCH bpf-next v4 8/8] resolve_btfids: Change in-place update with raw binary output

Andrii Nakryiko
2025-12-18T21:15:16Z

On Thu, Dec 18, 2025 at 9:54 AM Ihor Solodrai <ihor.solodrai@linux.dev> wrote:
>
> On 12/17/25 4:33 PM, Ihor Solodrai wrote:
> > [...]
> > diff --git a/scripts/Makefile.btf b/scripts/Makefile.btf
> > index 840a55de42da..b8569d450ed9 100644
> > --- a/scripts/Makefile.btf
> > +++ b/scripts/Makefile.btf
> > @@ -1,5 +1,10 @@
> > # SPDX-License-Identifier: GPL-2.0
> >
> > +gen-btf-y =
> > +gen-btf-$(CONFIG_DEBUG_INFO_BTF) = $(srctree)/scripts/gen-btf.sh
> > +
> > +export GEN_BTF := $(gen-btf-y)
> > +
>
> Ugh... GEN_BTF is not used anywhere in v4.
> Looks like I forgot a `git add` at some point.
>
> I'll wait a bit before sending a v5, in case there is more feedback.

It all looks good to me, so don't wait for any more feedback from my
side. If Eduard doesn't find anything in patch #8, please send new
revision, thanks!

>
> > pahole-ver := $(CONFIG_PAHOLE_VERSION)
> > pahole-flags-y :=
> >
> > @@ -18,13 +23,15 @@ pahole-flags-$(call test-ge, $(pahole-ver), 126) = -j$(JOBS) --btf_features=enc
> >
> > pahole-flags-$(call test-ge, $(pahole-ver), 130) += --btf_features=attributes
> >
> > -ifneq ($(KBUILD_EXTMOD),)
> > -module-pahole-flags-$(call test-ge, $(pahole-ver), 128) += --btf_features=distilled_base
> > -endif
> > -
> > endif
> >
> > [...]
>