From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F0902EAD1C; Thu, 18 Dec 2025 08:55:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766048145; cv=none; b=hhlrciTqUxAA9tl0wJZSpTOsR9hQu+LKgTQVlSCIXeES5Msv1gS+aj0/3WZvbK1HhiPl52C9reUY7FkvDZ55majjfcvvLi/qeBMOL4w642UZuG6gtHCTt6+gWM4rbY0JXKcQ6Oun6fJS4bz5KlTimEyil7SH/xor6WViQNC1Qug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766048145; c=relaxed/simple; bh=x2XJtBGwsRJl5nu4YWRn4RoWFF95goqIyI2zNi68T+o=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WVnnkD4ZOE0lYULIXIFaPu8q8a3F9ONTuXnWOA0Jh9O3YPQIpvVEgQgCtygORFsDCTW930/MGVc4vC7CP/kCKeYLp/h0yDNuyxhODMScyaAYrvMS7KmExXoR4uKv4iLrly6HZ6Q8CCJtBB2Ye/diwRdZfprtdeocGoosGBIC3CI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=ig0mTM9I; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="ig0mTM9I" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1766048139; bh=x2XJtBGwsRJl5nu4YWRn4RoWFF95goqIyI2zNi68T+o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ig0mTM9I9/tZubSTxKPi06oM6NdyiFrpJLjiaC4uMzW5ztgTgFIJXGVpIP5NpNU6g yJ0HPULdZcIJnBwHwVD6KEfo8NHrPV06riMJgWvZB/La6T9LZPgi9U3Egq77ms3r4+ Ljji4Q01j/eZ9YrlrtUCMtN/gIVaVZFHBO00bNTNT79HC1M6BOZ7G/zJrchvHJUZqE x8mSshaBKqJC2dkO9sYnPF2xpzE0lkV68Rn3mlouAuhfQnTZOC8lvnTtcqYRuEZLDJ gENfXZyb1Mwyz5I6Jc71UyARln/bdQKh4tM/DPFzHv5Wi4+K3UQUqb7n+dbNcO/Pr5 OWIkNFgWKO54Q== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id DBD9F17E0C21; Thu, 18 Dec 2025 09:55:38 +0100 (CET) Date: Thu, 18 Dec 2025 09:55:34 +0100 From: Boris Brezillon To: Dan Carpenter Cc: =?UTF-8?B?TG/Dr2M=?= Molinari , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] drm/panthor: unlock on error in panthor_ioctl_bo_create() Message-ID: <20251218095534.3ad4ad87@fedora> In-Reply-To: References: Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 18 Dec 2025 10:48:22 +0300 Dan Carpenter wrote: > Call drm_dev_exit() before returning -EINVAL. Oops. Reviewed-by: Boris Brezillon > > Fixes: cd2c9c3015e6 ("drm/panthor: Add flag to map GEM object Write-Back Cacheable") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/panthor/panthor_drv.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c > index 98d4e8d867ed..165dddfde6ca 100644 > --- a/drivers/gpu/drm/panthor/panthor_drv.c > +++ b/drivers/gpu/drm/panthor/panthor_drv.c > @@ -923,8 +923,10 @@ static int panthor_ioctl_bo_create(struct drm_device *ddev, void *data, > } > > if ((args->flags & DRM_PANTHOR_BO_NO_MMAP) && > - (args->flags & DRM_PANTHOR_BO_WB_MMAP)) > - return -EINVAL; > + (args->flags & DRM_PANTHOR_BO_WB_MMAP)) { > + ret = -EINVAL; > + goto out_dev_exit; > + } > > if (args->exclusive_vm_id) { > vm = panthor_vm_pool_get_vm(pfile->vms, args->exclusive_vm_id);