The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: Jean Delvare <jdelvare@suse.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	ardb@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>,
	x86@kernel.org
Subject: Re: Build breakage caused by the use of UDB
Date: Thu, 18 Dec 2025 11:46:59 +0100	[thread overview]
Message-ID: <20251218104659.GT3911114@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20251218103853.GS3911114@noisy.programming.kicks-ass.net>

On Thu, Dec 18, 2025 at 11:38:53AM +0100, Peter Zijlstra wrote:
> On Thu, Dec 18, 2025 at 11:26:13AM +0100, Uros Bizjak wrote:
> 
> > I see... OTOH, a trivial solution would be to just use "ud2" mnemonic,
> > as proposed in [1].
> > 
> > [1] https://lore.kernel.org/lkml/20250909100038.1709394-1-ubizjak@gmail.com/
> 
> Yes, there is that. I suppose I worry about all the other _ASM_BYTES
> users, but since they don't actually show miscompilation, perhaps I
> should not worry.
> 
> Let me do a build with just using ud2 instead.

Yep, this builds. Let me stick a changelog on with Fixes and Cc stable
and stick it in x86/urgent.

---

diff --git a/arch/x86/include/asm/bug.h b/arch/x86/include/asm/bug.h
index d561a8443c13..9b4e04690e1a 100644
--- a/arch/x86/include/asm/bug.h
+++ b/arch/x86/include/asm/bug.h
@@ -15,7 +15,7 @@ extern void __WARN_trap(struct bug_entry *bug, ...);
 /*
  * Despite that some emulators terminate on UD2, we use it for WARN().
  */
-#define ASM_UD2		_ASM_BYTES(0x0f, 0x0b)
+#define ASM_UD2		__ASM_FORM(ud2)
 #define INSN_UD2	0x0b0f
 #define LEN_UD2		2
 

  reply	other threads:[~2025-12-18 10:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17 11:44 Build breakage caused by the use of UDB Jean Delvare
2025-12-17 12:35 ` Peter Zijlstra
2025-12-17 12:47   ` Peter Zijlstra
2025-12-17 13:02     ` Peter Zijlstra
2025-12-17 13:34       ` Peter Zijlstra
2025-12-17 14:39         ` Uros Bizjak
2025-12-18  8:54           ` Peter Zijlstra
2025-12-18 10:26             ` Uros Bizjak
2025-12-18 10:38               ` Peter Zijlstra
2025-12-18 10:46                 ` Peter Zijlstra [this message]
2025-12-18 11:03                   ` [tip: x86/urgent] x86/bug: Fix old GCC compile fails tip-bot2 for Peter Zijlstra
2025-12-18 12:38                   ` Build breakage caused by the use of UDB Brian Gerst
2025-12-17 13:10     ` Jean Delvare
2025-12-17 13:22       ` Peter Zijlstra
2025-12-17 22:07     ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251218104659.GT3911114@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=ardb@kernel.org \
    --cc=jdelvare@suse.de \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=ubizjak@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox