public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Donglin Peng <dolinux.peng@gmail.com>
To: ast@kernel.org, andrii.nakryiko@gmail.com, eddyz87@gmail.com
Cc: zhangxiaoqin@xiaomi.com, ihor.solodrai@linux.dev,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	pengdonglin <pengdonglin@xiaomi.com>,
	Alan Maguire <alan.maguire@oracle.com>
Subject: [PATCH bpf-next v10 12/13] btf: Add btf_is_sorted to refactor the code
Date: Thu, 18 Dec 2025 19:30:50 +0800	[thread overview]
Message-ID: <20251218113051.455293-13-dolinux.peng@gmail.com> (raw)
In-Reply-To: <20251218113051.455293-1-dolinux.peng@gmail.com>

From: pengdonglin <pengdonglin@xiaomi.com>

Introduce a new helper function to clarify the code and no
functional changes are introduced.

Cc: Eduard Zingerman <eddyz87@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alan Maguire <alan.maguire@oracle.com>
Cc: Ihor Solodrai <ihor.solodrai@linux.dev>
Cc: Xiaoqin Zhang <zhangxiaoqin@xiaomi.com>
Signed-off-by: pengdonglin <pengdonglin@xiaomi.com>
---
 include/linux/btf.h | 1 +
 kernel/bpf/btf.c    | 9 +++++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/include/linux/btf.h b/include/linux/btf.h
index 2d28f2b22ae5..947ed2abf632 100644
--- a/include/linux/btf.h
+++ b/include/linux/btf.h
@@ -221,6 +221,7 @@ bool btf_is_vmlinux(const struct btf *btf);
 struct module *btf_try_get_module(const struct btf *btf);
 u32 btf_nr_types(const struct btf *btf);
 u32 btf_sorted_start_id(const struct btf *btf);
+bool btf_is_sorted(const struct btf *btf);
 struct btf *btf_base_btf(const struct btf *btf);
 bool btf_type_is_i32(const struct btf_type *t);
 bool btf_type_is_i64(const struct btf_type *t);
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index 3aeb4f00cbfe..0f20887a6f02 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -555,6 +555,11 @@ u32 btf_sorted_start_id(const struct btf *btf)
 	return btf->sorted_start_id ?: (btf->start_id ?: 1);
 }
 
+bool btf_is_sorted(const struct btf *btf)
+{
+	return btf->sorted_start_id > 0;
+}
+
 /*
  * Assuming that types are sorted by name in ascending order.
  */
@@ -649,9 +654,9 @@ s32 btf_find_by_name_kind(const struct btf *btf, const char *name, u8 kind)
 			return idx;
 	}
 
-	if (btf->sorted_start_id > 0 && name[0]) {
+	if (btf_is_sorted(btf) && name[0]) {
 		/* skip anonymous types */
-		s32 start_id = btf->sorted_start_id;
+		s32 start_id = btf_sorted_start_id(btf);
 		s32 end_id = btf_nr_types(btf) - 1;
 
 		idx = btf_find_by_name_bsearch(btf, name, start_id, end_id);
-- 
2.34.1


  parent reply	other threads:[~2025-12-18 11:31 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-18 11:30 [PATCH bpf-next v10 00/13] Improve the performance of BTF type lookups with binary search Donglin Peng
2025-12-18 11:30 ` [PATCH bpf-next v10 01/13] libbpf: Add BTF permutation support for type reordering Donglin Peng
2025-12-18 23:02   ` Andrii Nakryiko
2025-12-19  3:14     ` Donglin Peng
2025-12-19  3:16       ` Donglin Peng
2025-12-19 17:07       ` Andrii Nakryiko
2025-12-20  8:39         ` Donglin Peng
2025-12-18 11:30 ` [PATCH bpf-next v10 02/13] selftests/bpf: Add test cases for btf__permute functionality Donglin Peng
2025-12-18 23:03   ` Andrii Nakryiko
2025-12-19  3:30     ` Donglin Peng
2025-12-18 11:30 ` [PATCH bpf-next v10 03/13] tools/resolve_btfids: Support BTF sorting feature Donglin Peng
2025-12-18 23:09   ` Andrii Nakryiko
2025-12-19  3:42     ` Donglin Peng
2025-12-19 17:12       ` Andrii Nakryiko
2025-12-20  8:44         ` Donglin Peng
2025-12-18 11:30 ` [PATCH bpf-next v10 04/13] libbpf: Optimize type lookup with binary search for sorted BTF Donglin Peng
2025-12-18 19:32   ` Eduard Zingerman
2025-12-18 23:29   ` Andrii Nakryiko
2025-12-19  0:13     ` Eduard Zingerman
2025-12-19  0:19       ` Andrii Nakryiko
2025-12-19  0:24         ` Eduard Zingerman
2025-12-19  1:01           ` Andrii Nakryiko
2025-12-19  2:53     ` Donglin Peng
2025-12-19 17:28       ` Andrii Nakryiko
2025-12-20  9:38         ` Donglin Peng
2025-12-22  1:58           ` Donglin Peng
2026-01-06  0:38             ` Andrii Nakryiko
2026-01-06  2:42               ` Donglin Peng
2026-01-06  0:36           ` Andrii Nakryiko
2026-01-06  2:50             ` Donglin Peng
2025-12-18 11:30 ` [PATCH bpf-next v10 05/13] libbpf: Verify BTF Sorting Donglin Peng
2025-12-18 19:38   ` Eduard Zingerman
2025-12-18 23:44   ` Andrii Nakryiko
2025-12-19  5:06     ` Donglin Peng
2025-12-19 17:33       ` Andrii Nakryiko
     [not found]         ` <CAErzpmsvirekLBRrJYVgmRC0YKWCbo7OyRQXgNYrk83aF-Wz2Q@mail.gmail.com>
2026-01-07  3:45           ` Donglin Peng
2026-01-07 21:50             ` Andrii Nakryiko
2026-01-08  1:50               ` Donglin Peng
2025-12-18 11:30 ` [PATCH bpf-next v10 06/13] btf: Optimize type lookup with binary search Donglin Peng
2025-12-18 21:38   ` Eduard Zingerman
2025-12-19  5:07     ` Donglin Peng
2025-12-18 11:30 ` [PATCH bpf-next v10 07/13] btf: Verify BTF Sorting Donglin Peng
2025-12-18 21:43   ` Eduard Zingerman
2025-12-19  5:10     ` Donglin Peng
2025-12-18 23:46   ` Andrii Nakryiko
2025-12-19  5:10     ` Donglin Peng
2025-12-18 11:30 ` [PATCH bpf-next v10 08/13] bpf: Skip anonymous types in type lookup for performance Donglin Peng
2025-12-18 22:21   ` Eduard Zingerman
2025-12-18 23:59     ` Andrii Nakryiko
2025-12-19  5:40       ` Donglin Peng
2025-12-18 22:24   ` Eduard Zingerman
2025-12-18 11:30 ` [PATCH bpf-next v10 09/13] bpf: Optimize the performance of find_bpffs_btf_enums Donglin Peng
2025-12-19  0:01   ` Andrii Nakryiko
2025-12-19  5:41     ` Donglin Peng
2025-12-20 14:27       ` Donglin Peng
2025-12-18 11:30 ` [PATCH bpf-next v10 10/13] libbpf: Optimize the performance of determine_ptr_size Donglin Peng
2025-12-18 22:27   ` Eduard Zingerman
2025-12-19  0:03   ` Andrii Nakryiko
2025-12-19  5:42     ` Donglin Peng
2025-12-18 11:30 ` [PATCH bpf-next v10 11/13] libbpf: Add btf_is_sorted and btf_sorted_start_id helpers to refactor the code Donglin Peng
2025-12-18 22:33   ` Eduard Zingerman
2025-12-19  5:49     ` Donglin Peng
2025-12-19  0:05   ` Andrii Nakryiko
2025-12-19  5:51     ` Donglin Peng
2025-12-19 17:35       ` Andrii Nakryiko
2025-12-20 14:27         ` Donglin Peng
2025-12-18 11:30 ` Donglin Peng [this message]
2025-12-18 22:30   ` [PATCH bpf-next v10 12/13] btf: Add btf_is_sorted " Eduard Zingerman
2025-12-19  0:05   ` Andrii Nakryiko
2025-12-20 14:25     ` Donglin Peng
2025-12-18 11:30 ` [PATCH bpf-next v10 13/13] btf: Refactor the code by calling str_is_empty Donglin Peng
2025-12-18 22:34   ` Eduard Zingerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251218113051.455293-13-dolinux.peng@gmail.com \
    --to=dolinux.peng@gmail.com \
    --cc=alan.maguire@oracle.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=eddyz87@gmail.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pengdonglin@xiaomi.com \
    --cc=zhangxiaoqin@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox