From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34D5A325737 for ; Thu, 18 Dec 2025 11:47:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766058454; cv=none; b=TLv1Ae9jAg0H2zZQsh5KhroxjWOsSuuR0Pyjf7ZAGfoTIH8/zP2A8O/OgdbOEuwecuApMKSuIJcZLzSF8axbZCxLPUWX/OWxsdHoIqceyoXs+WibMInLuO6LUZjSyRzahoMgZf4/m2EyE2vO70Gjxgz5uNbCMorIvod5uMs9y1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766058454; c=relaxed/simple; bh=0sDbHFSYlSW1hrPezPbpZKGbmc09oYyuE+mcM0SbbF4=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qz9vyusqs+mBlNc3gXOPlBTUJlUiTONWdZtKjGQbT0VonoO/XuMliGJBgbbmpRA/oQtNadqDdfcto6xz5b6ITtRb1FzcJkGJFyyrAYOeUNBmpYKeNbM59kwfH0t3b+AL0EcRFn1Ty42wUYVrIrarN3u9iY5HVnP6ezNL4xsqKto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.224.150]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4dX85t4WvSzJ46bF; Thu, 18 Dec 2025 19:46:58 +0800 (CST) Received: from dubpeml100005.china.huawei.com (unknown [7.214.146.113]) by mail.maildlp.com (Postfix) with ESMTPS id 883834056A; Thu, 18 Dec 2025 19:47:29 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml100005.china.huawei.com (7.214.146.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Thu, 18 Dec 2025 11:47:28 +0000 Date: Thu, 18 Dec 2025 11:47:26 +0000 From: Jonathan Cameron To: James Morse CC: , , D Scott Phillips OS , , , , , , Jamie Iles , "Xin Hao" , , , , David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , , , Gavin Shan , Ben Horgan , , , Punit Agrawal Subject: Re: [RFC PATCH 11/38] arm_mpam: resctrl: Implement helpers to update configuration Message-ID: <20251218114726.0000651e@huawei.com> In-Reply-To: <20251205215901.17772-12-james.morse@arm.com> References: <20251205215901.17772-1-james.morse@arm.com> <20251205215901.17772-12-james.morse@arm.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500009.china.huawei.com (7.191.174.84) To dubpeml100005.china.huawei.com (7.214.146.113) On Fri, 5 Dec 2025 21:58:34 +0000 James Morse wrote: > resctrl has two helpers for updating the configuration. > resctrl_arch_update_one() updates a single value, and is used by the > software-controller to apply feedback to the bandwidth controls, > it has to be called on one of the CPUs in the resctrl:domain. > > resctrl_arch_update_domains() copies multiple staged configurations, > it can be called from anywhere. > > Both helpers should update any changes to the underlying hardware. > > Imlpement resctrl_arch_update_domains() to use Implement > resctrl_arch_update_one(). Neither need to be called on a specific > CPU as the mpam driver will send IPIs as needed. > > Signed-off-by: James Morse > --- > drivers/resctrl/mpam_resctrl.c | 71 ++++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/drivers/resctrl/mpam_resctrl.c b/drivers/resctrl/mpam_resctrl.c > index a26eb1f3efd0..ae0d17857b78 100644 > --- a/drivers/resctrl/mpam_resctrl.c > +++ b/drivers/resctrl/mpam_resctrl.c > +int resctrl_arch_update_domains(struct rdt_resource *r, u32 closid) > +{ > + int err = 0; > + enum resctrl_conf_type t; > + struct rdt_ctrl_domain *d; > + struct resctrl_staged_config *cfg; > + > + lockdep_assert_cpus_held(); > + lockdep_assert_irqs_enabled(); > + > + list_for_each_entry(d, &r->ctrl_domains, hdr.list) { > + for (t = 0; t < CDP_NUM_TYPES; t++) { > + cfg = &d->staged_config[t]; > + if (!cfg->have_new_ctrl) > + continue; > + > + err = resctrl_arch_update_one(r, d, closid, t, > + cfg->new_ctrl); > + if (err) > + return err; > + } > + } > + > + return err; If it stays this simple in later patches return 0; to make it clear this is the good path. Also can then avoid initializing err at the top. > +} > + > void resctrl_arch_reset_all_ctrls(struct rdt_resource *r) > { > struct mpam_resctrl_res *res;