Re: [PATCH v7 0/5] Introduce SpacemiT K1 PCIe phy support

Yixun Lan
2025-12-19T12:19:10Z

Hi Vinod,
Could you take a look of this series? I suppose patch 1-3 should go via
the generic phy tree, for patch 3, it's already got Neil's R-y [1] which
Alex should collect the tag..
the Changelog for previous versions are also dropped.. which is bad

Link: https://lore.kernel.org/all/ba532f8d-a452-40e5-af46-b58b89f70a92@linaro.org/ [1]

On 09:12 Thu 18 Dec , Alex Elder wrote:
> This series introduces a PHY driver to support PCIe on the SpacemiT K1
> SoC. The PCIe controller implementation is derived from a Synopsys
> DesignWare PCIe IP. The PHY driver supports one combination PCIe/USB
> PHY as well as two PCIe-only PHYs. The combo PHY port uses one PCIe
> lane, and the other two ports each have two lanes. All PCIe ports
> operate at 5 GT/second.
>
> The PCIe PHYs must be configured using a value that can only be
> determined using the combo PHY, operating in PCIe mode. To allow
> that PHY to be used for USB, the needed calibration step is performed
> by the PHY driver automatically at probe time. Once this step is done,
> the PHY can be used for either PCIe or USB.
>
> The PCIe controller driver that was included in earlier versions of
> this series has already been accepted upstream:
> a812b09a6b599 ("dt-bindings: pci: spacemit: Introduce PCIe host
> controller")
> ff64e078e45fa ("PCI: spacemit: Add SpacemiT PCIe host driver")
> However this series still includes devicetree patches to enable the
> PCIe controller (along with the PHYs).
>
> The patches that remain in version 7 of this series are unchanged;
> they are simply rebased on top of Linux v6.19-rc1. The first two
> patches are the DT bindings for the PCIe and combo PCIe/USB PHY.
> The third is the PHY driver, and the last two are devicetree updates
> to enable the PCIe controller and PHYs.
>
> -Alex
>
> Alex Elder (5):
> dt-bindings: phy: spacemit: Add SpacemiT PCIe/combo PHY
> dt-bindings: phy: spacemit: Introduce PCIe PHY
> phy: spacemit: Introduce PCIe/combo PHY
> riscv: dts: spacemit: Add a PCIe regulator
> riscv: dts: spacemit: PCIe and PHY-related updates
>
anyway, for this series, I've also tested on bananapi with nvme card, so

Tested-by: Yixun Lan <dlan@gentoo.org>

--
Yixun Lan (dlan)