From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010051.outbound.protection.outlook.com [52.101.85.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87BD233E363 for ; Thu, 18 Dec 2025 15:47:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.51 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766072838; cv=fail; b=DETg+RxgAo1k1o4cyZv+0iTR8s9QDLSub9/POHiBfCq6om4sYf6KA6vg0WXZDhmyxG6+kQiJ6f1OF63UTwiWv/I4MrgqBySts4a90T1cAzvutu/9w3hXos1WCwAHEHajPbCPfLkHkKL2MbOaE6Bo7sCPeu6qZSuh/xLiPra53n4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766072838; c=relaxed/simple; bh=g4D9ImkLCKw3jfbHawtVlqjmsrvV1V2A3ien4PikEqs=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=mHYi2eoimyBg5A8jaO2nXHL9/8W7RDbZ8lo+Ruh3Kl6VpqV49BkkJ6+3LskXiEMHSipu8DYG5YSEL6jDxRfeHVcgjIAyAqovFeGLUrBRnXshfm3LygQ5G/uelsJZ0/zNPTJ5Glv+EI7cFFu754kHhbZ4cnkUreBps5UNGajWHps= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=0hT0nuoF; arc=fail smtp.client-ip=52.101.85.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="0hT0nuoF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NNPAwT7ILmS/++6lJRTTJ0Kpyjl/yyBgm/qyRX1HP7xWOzJ3AQj6QTMKJjjTkzNnGTSZ3b3DWRsxnlWnbPAUMtKCNsz6DLjdMlFtJlfqT8EGulLS74CINq5YLLdnWYBYaQECx9riEFbCVcWA6EBLMSCLrjbvZ/tDsXwa8wmZHWOTXivve9s3Hm71IT6Rj3M91ZleG1zNtJMVzVMChQc6logJguM7UL/jNXng8PhZe9DydsZ01Wuhf1TALyKbWR9IBg+VVN8Hjq/vT0HZka7oKoXy2/4gEWe4XYBYgco6GxNh/KoyczmOT+QqSFifxVV94ZRYzYItoV5Q4Hi3jJLXjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rxCnLKt00eMoW7ou6JnQCt267lruXIW9jPI1SW/4mjU=; b=VP65EClNlmZi4j/4S19K+/laqN3AGCGMptZBN9awhpxeWTNQwuptnnyGhV2WszxPklpLSO8SKt6m4KyVPm9W/n00K/M713FAlh5EuA0TCPgyZz8Hh89jGR9yMDbhL40sqlJh2/cDx1qjz0W1FFjnVZQgQxCHcvKzUpKF4B0qpwc348aLSmI5TXyUOAa2UgSfvNZFUC9U4NY+xNj55L4BVz3frevYmApAvWUYnxqMsxbv39EIh9X/47CwpKrATAsDeZIoL0fW36IBICj/OVpG3nowlnZ8V7jA5u/GDdrVqongX0wFsvC4Z/yf/o19stTz5ORfSDJrDCbBU0wv/8RTBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rxCnLKt00eMoW7ou6JnQCt267lruXIW9jPI1SW/4mjU=; b=0hT0nuoFDrcdEUcV1sU+wcmHqOgNH3zai9dU+nuLaozEQBWkJcFAd8fJL0Am/ZzpmEls9XNxqTg6bi/Pp0wU+2lrJ11HC6mzD/zs/Yh4cLM26OkRz/YsMxjdfu9w4xE9kanYv0o9mbE0tElXliAPOWFMKdBY+n+E0Sre+6vTD1c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CY5PR12MB6369.namprd12.prod.outlook.com (2603:10b6:930:21::10) by PH7PR12MB6537.namprd12.prod.outlook.com (2603:10b6:510:1f2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.8; Thu, 18 Dec 2025 15:47:13 +0000 Received: from CY5PR12MB6369.namprd12.prod.outlook.com ([fe80::d4c1:1fcc:3bff:eea6]) by CY5PR12MB6369.namprd12.prod.outlook.com ([fe80::d4c1:1fcc:3bff:eea6%4]) with mapi id 15.20.9434.001; Thu, 18 Dec 2025 15:47:13 +0000 Date: Thu, 18 Dec 2025 10:47:08 -0500 From: Yazen Ghannam To: Mario Limonciello Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Jean Delvare , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 7/7] x86/CPU/AMD: Output the AGESA version to the logs Message-ID: <20251218154708.GC1346661@yaz-khff2.amd.com> References: <20251216123354.9219-1-superm1@kernel.org> <20251216123354.9219-8-superm1@kernel.org> <20251217211844.GC1263950@yaz-khff2.amd.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MN2PR16CA0048.namprd16.prod.outlook.com (2603:10b6:208:234::17) To CY5PR12MB6369.namprd12.prod.outlook.com (2603:10b6:930:21::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR12MB6369:EE_|PH7PR12MB6537:EE_ X-MS-Office365-Filtering-Correlation-Id: ae87d278-91a9-4f23-3b90-08de3e4cb657 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QGdF3NaISuPURHsi6IZUEqkNWGtaV/SeUjCN5cRqhNzHR23ZIUuqS7mmxYT5?= =?us-ascii?Q?T8K3VhQmX2bhNvUKxpPRxOnVeOX20xcekSMcx/rNgxEt+Kxa30jHhxqCnwdT?= =?us-ascii?Q?LGoKBhM/LsxlkHC5pVQjpN59cXrlgNrSM97aAG8cjEum//D2JOw2GCuz3DIx?= =?us-ascii?Q?4YMFtbHBXIgfdGRRuCztDh9NRojaPuROxj8RXdq+xUMyDSAeK58TVbTf8rHt?= =?us-ascii?Q?5xVDzkii+aTM9bsmOgMW5mSrB6y3r56bhIIlFcPGd0oAzprwW+jFG0zvj+NE?= =?us-ascii?Q?PQCyYhd4Ovfjb0rTCGEDhGyx/iu2dw4vQLC8Cvh81oX6yoKvy1fQiTaJGrgo?= =?us-ascii?Q?RcaZChuJCYKR+WEDqNWTp+i2Ai20SLedryjphR76h+SRoOHhNz6Ysk1TmR0n?= =?us-ascii?Q?hB0+IZVEDtvfOBn937DM5UN7WPu3qU0K/N7e7LoyzGc/82/ZzkUmJlhQ8tnO?= =?us-ascii?Q?TaLiGvEN0DOPn0no7gjgmS+9qAwoIaUOvS2F55IreKIiq1jBCxGT0oXVGY6s?= =?us-ascii?Q?z7qCIPN5edn8+HGnL9xxEmuESNOnz3olBTLYWOJavbh/bYQc53U7fDWpRXZp?= =?us-ascii?Q?pm4rcwUGDeVZz7Vz+tDCjNOQSiNJzeWYscvyQKh/tX36+fhC3Oitg5CvGGo9?= =?us-ascii?Q?gejq6fbdAuZh8LotV6c2N1iLc6sM0xTiivKL+eHXmBlnGNc10WkDWJkoHP1o?= =?us-ascii?Q?rAmDnSxXYxmUZ/ZjV7qpjsy0+X4mCjUXILh6YptzYJbfa2g8gK/NCad2uV4/?= =?us-ascii?Q?S0evfgcWWTBVnBqo6fvWPCFu1VvQEBvD1wmMlpewMv3Jm4tiZqSwgD61jAH2?= =?us-ascii?Q?tMX7EqRd4n8SL+BWW4TCcqu7DLMXPYmzhbt1fd+uIuttqSDi3jnPb85GIrXn?= =?us-ascii?Q?cX5yYPLma4FzaO4qnvzJNyw5c0xRRCRb88fcKuMGQLUM0KCuhD5UAcJ5LAdG?= =?us-ascii?Q?YPt9OESUAaBQuGl3LCkyAxsmvK7CWY5emafrQAKTEtgNHcjpCFvakIRI8aVC?= =?us-ascii?Q?+SXNrRJjnGdGUEbR9axCBgSzWiKe/tO0j8QhY4ocFzt4szOCzIpMA2BCIHy5?= =?us-ascii?Q?QzwJ6Kc6u9A28Eg2z6hwEMyq7Rpfc8apmvqqh6O2IJS0KJI+oSGisfocqenp?= =?us-ascii?Q?rbatzfWcY3aj9g+EzP+5R09bKdAVENQkrNf1CR2LYcu1YnLO4hxHiDY1MkGW?= =?us-ascii?Q?Gi4w081Ic/L74kgI0jwbnAV+SlYqJW0W96mVWkf4O5tl4ZBlmDxLSW4g6lls?= =?us-ascii?Q?IOcgiwmYdVPd2VLSweTGW5Edmp4QXgAYfapK+yO8wLBX4k0AXSJDug4JUazr?= =?us-ascii?Q?3QKBkGxhJq3FCSHdzMdf4+hEi+IzKyWwEIRuMAW6nGGbX7ZWkIjiSGfo7rPk?= =?us-ascii?Q?VdlB52y3GraYNmLGlXXuU92mv184fujDGWOW+Oj2L5GxxJOCPbeiURMwtPUS?= =?us-ascii?Q?rfG1DG3OvGpaLl2jtgVZmF1lNnZ9JSch?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY5PR12MB6369.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g3YPDLViNlVsuoRPi1s8UCKCYTjldTHVz986q8LMoD1OfUwZ7EOJvZLE5xJh?= =?us-ascii?Q?eptRW+HGmXesZ3ODybzNlzSH2S+HrQY2gS+iwkLo+gF8FtJF/OYvTuk5kfCU?= =?us-ascii?Q?eU7nnbi97hr6UruWmN1gvmm+BiGYzLXUwWtHW4cJMjn1aMyAPiy0QVK5yWvt?= =?us-ascii?Q?iZbs7Z4bwErRM9hhub03w0tOEPjCOEyfT9SUco9LO6Q3t1Kw+jlVvj/sRWvh?= =?us-ascii?Q?E91E6BiyV2qtDlCRjIKhO2s3NLLZL9vodntHO2xHMctMoLcPUBca2IMwJn7t?= =?us-ascii?Q?mcIOVyJBDbMBdzGggVdoeosYtNHgqJcJVtVcLVX1/LA2H2pTzBSUTech7YIW?= =?us-ascii?Q?wUkEXF6gSjVpOcB0F04fDYuwu74hKOEq/x7pimejP0b7gssQefv8sYDuJI5f?= =?us-ascii?Q?ZtZY2A2Db+r2fJlr4l6EcEoovueNKMZlD1eJxuGxYFreYnUCbLCvawKYRF5Z?= =?us-ascii?Q?JCx7mqs1HO9o9CLLUGxI1z6x0L8m69BPDpxmABJFqsYgSHbyw0pD3hmYzB8F?= =?us-ascii?Q?P3tpCE+2nPsafiX77H3+mXhSNla2WmrguFsbiAH8o1MMxvLjTALV3bbYblIX?= =?us-ascii?Q?pwz2UFWMjou8f0usbJ1DBF+Xo7knTtkfB9eWV/JtNQFiqZlT/0bC9DgEGgxL?= =?us-ascii?Q?M+DrVjByJ0k4rgnPaP492RpUn2W3L3wYKBD2GZfl4oI+OO9WPcJzpLdlptLf?= =?us-ascii?Q?YZeCYtrbRE8mNw/p0X3w5XizsT3JDrYYtGhBGqaEj3W6hFscXSJtQfhf71tg?= =?us-ascii?Q?1CklH0AdcBTLC7Bamn+nDodNBaTM5o4gK9kW8N58mwSumVOPTsj1PnpK9mPg?= =?us-ascii?Q?jPjWPSa43FngP6qIbTkHbxojYx37S2Hi4x/fNev/MI8x52RMmtE/uQl5ucsd?= =?us-ascii?Q?9N2erbIOPbyFifIn1Eo4/o/g7dhk437iTJGoRaxjB2dPkK+ISDtbB5dKfJSJ?= =?us-ascii?Q?YwuTjiGGxlWf2wOrm8dDdEsn0BTf7pG3pbm9//tUDs8jb5mKm6W1eoSSNzci?= =?us-ascii?Q?dHBLayFFFr0W9XB+g4rqK7nZr8uOvBqz5skz+zg22l0Gx1zDbzGv/AWL8JKk?= =?us-ascii?Q?1EkEfPtEPenrbGykuhGds4Z2onyqFjI2YsrMqDwbA4awBxdREJ7cGfNbFJnY?= =?us-ascii?Q?JT1N/o2FVWPTBkviw6/CGiLjRgkptgF6pieayGDy9mCyR4lHkrOYWr3pns6s?= =?us-ascii?Q?JIVa9JSoiWRwwlOeaVRucpeT47oszQ40nTwltM422nUSMcm7iD7fTmjzDZDg?= =?us-ascii?Q?lRzP4AaqIzFR8B/Zl9R3IYPZXS92EG1o4KBoHxq1E0RIbh6fqkSQvQ2yPZGC?= =?us-ascii?Q?BB32olICm4cm21Q5+lqdXWhl4pyqPKEbfOPjKqRbEPbe3mHc9vxUma33X6rN?= =?us-ascii?Q?dR936FMNxaXoPMyYtxceyJtjZEatKc+3twJRa7yVVk+iiSL7l9OMDNpxeMV5?= =?us-ascii?Q?zp1nKBYn+34NcEKD4dEpLXjkhp/Ldx3NOCgvCFJU4HDeTBGneVGFxsEZqrYE?= =?us-ascii?Q?qzTY4D6u5FGnYQpitp3G8imk9NgQo5gz9jeabmd9RZ1wKlQ52k6gPJyDQQjb?= =?us-ascii?Q?AFLbBGnuyYiOJxBsx66G+HPX5R+iXW2NBt+XZDpB?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae87d278-91a9-4f23-3b90-08de3e4cb657 X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6369.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2025 15:47:13.2275 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9J9Jfo2Q+Yt6H2Y7KPDeAIoQTeTJE21poqB6TeLESBaMKviOMtuMTb1nrsQ4uu6tEYQmB+GD1pyF3YjINrn61Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6537 On Wed, Dec 17, 2025 at 03:21:17PM -0600, Mario Limonciello wrote: > On 12/17/25 3:18 PM, Yazen Ghannam wrote: > > On Tue, Dec 16, 2025 at 06:33:54AM -0600, Mario Limonciello (AMD) wrote: > > > On AMD Zen platforms that are running AGESA, there is sometimes > > > DMI additional string for the AGESA version that can be helpful when > > > debugging an issue. If this string is found output to kernel logs. > > > > > > Signed-off-by: Mario Limonciello (AMD) > > > --- > > > arch/x86/kernel/cpu/amd.c | 18 ++++++++++++++++++ > > > 1 file changed, 18 insertions(+) > > > > > > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c > > > index c19c4ee74dd1f..8f44439d3f993 100644 > > > --- a/arch/x86/kernel/cpu/amd.c > > > +++ b/arch/x86/kernel/cpu/amd.c > > > @@ -1,6 +1,7 @@ > > > // SPDX-License-Identifier: GPL-2.0-only > > > #define pr_fmt(fmt) "x86/amd: " fmt > > > +#include > > > #include > > > #include > > > #include > > > @@ -1406,3 +1407,20 @@ static __init int print_s5_reset_status_mmio(void) > > > return 0; > > > } > > > late_initcall(print_s5_reset_status_mmio); > > > + > > > +#ifdef CONFIG_DMI > > > +static __init int print_agesa_dmi_info(void) > > > +{ > > > + const struct dmi_device *dev = NULL; > > > + > > > + while ((dev = dmi_find_device(DMI_DEV_TYPE_ADDITIONAL, NULL, dev))) { > > > + if (!strncmp(dev->name, "AGESA", 5)) { > > > + pr_info("%s\n", dev->name); > > > + break; > > > + } > > > + } > > > + > > > + return 0; > > > +} > > > +late_initcall(print_agesa_dmi_info); > > > +#endif > > > > > > > The Zen check is gone. Is that intentional? > > > > No it's not, it's a good catch. We don't have an AGESA version in SMBIOS > data on pre-zen hardware. > > I'll add in a check like we do for print_s5_reset_status_mmio() for the next > spin. > > if (!cpu_feature_enabled(X86_FEATURE_ZEN)) > return 0; > In that case, please consider a wrapper function that checks for Zen and calls the two functions: AGESA and S5_RESET_STATUS. Thanks, Yazen