From: Rakuram Eswaran <rakuram.e96@gmail.com>
To: socketcan@hartkopp.net
Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
mailhol@kernel.org, mkl@pengutronix.de, rakuram.e96@gmail.com
Subject: Re: [RFC PATCH 0/2] can: add dummy_can termination and update SocketCAN docs for CAN XL
Date: Thu, 18 Dec 2025 21:36:26 +0530 [thread overview]
Message-ID: <20251218160630.7862-1-rakuram.e96@gmail.com> (raw)
In-Reply-To: f33bb7a6-75c7-4ee4-baae-755ff25d81d6@hartkopp.net
On Tue, 9 Dec 2025 at 21:47, Oliver Hartkopp <socketcan@hartkopp.net> wrote:
>
> Hello Rakuram,
>
> On 08.12.25 15:19, Rakuram Eswaran wrote:
> > On Fri, 28 Nov 2025 at 00:49, Rakuram Eswaran <rakuram.e96@gmail.com> wrote:
> >>
> >> This RFC series introduces two changes related to CAN XL support:
> >>
> >> 1. Add termination configuration support to the dummy_can driver,
> >> enabling termination testing with iproute2.
> >>
> >> 2. Update the SocketCAN documentation to describe CAN XL operation,
> >> including MTU changes, bittiming/XBTR settings, mixed-mode
> >> behaviour, error signalling, and example iproute2 usage.
> >>
> >> The goal of this RFC is to validate whether the proposed behaviour and
> >> documentation match the expectations for the ongoing CAN XL upstream
> >> work. Feedback from the maintainers is highly appreciated.
> >>
> >> Base commit:
> >> commit 30f09200cc4a ("Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux")
> >>
> >> For testing, this series was applied on top of the following patchsets:
> >>
> >> * "treewide: remove can_change_mtu()" (Vincent Mailhol)
> >> b4 am 20251003-remove-can_change_mtu-v1-1-337f8bc21181@kernel.org
> >> git am ./20251003_mailhol_can_treewide_remove_can_change_mtu.mbx
> >>
> >> * "can: netlink: add CAN XL support" (Marc Kleine-Budde)
> >> b4 am 20251126-canxl-v8-0-e7e3eb74f889@pengutronix.de
> >> git am ./v8_20251126_mkl_can_netlink_add_can_xl_support.mbx
> >>
> >> Testing was performed using the iproute2-next tree (canxl-netlink branch),
> >> which contains the required CAN XL netlink support for validating
> >> these changes.
> >>
> >
> > Hello,
> >
> > Gentle ping — any feedback on this documentation update patch series?
>
> Many thanks for the patches.
>
> The termination patch should be commented by Vincent, who is currently
> pretty busy.
>
Understood. I will wait for Vincent’s feedback on the termination patch.
> But as the next merge windows is far away this can be managed in
> January. No hurry.
>
> The documentation is almost fine but still has error-signalling in the
> ip options and there's definitely no xl-cc-len16-dlc option.
>
> Please use the latest iproute2 code to generate the examples:
> https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/
>
Acknowledged. I will update the examples to align with the current iproute2
tree. I will respin the documentation update accordingly and plan to send the
next revision in the first week of January.
Best Regards,
Rakuram
prev parent reply other threads:[~2025-12-18 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 19:18 [RFC PATCH 0/2] can: add dummy_can termination and update SocketCAN docs for CAN XL Rakuram Eswaran
2025-11-27 19:18 ` [RFC PATCH 1/2] can: dummy_can: add CAN termination support Rakuram Eswaran
2025-12-23 21:33 ` Vincent Mailhol
2025-12-25 7:28 ` Rakuram Eswaran
2025-12-25 11:10 ` Vincent Mailhol
2025-11-27 19:18 ` [RFC PATCH 2/2] docs: can: update SocketCAN documentation for CAN XL Rakuram Eswaran
2025-12-08 14:19 ` [RFC PATCH 0/2] can: add dummy_can termination and update SocketCAN docs " Rakuram Eswaran
2025-12-09 16:17 ` Oliver Hartkopp
2025-12-18 16:06 ` Rakuram Eswaran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251218160630.7862-1-rakuram.e96@gmail.com \
--to=rakuram.e96@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox